From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 32AA52BCD for ; Wed, 30 Nov 2016 03:26:37 +0100 (CET) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga104.fm.intel.com with ESMTP; 29 Nov 2016 18:26:36 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,719,1473145200"; d="scan'208";a="1065951923" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by orsmga001.jf.intel.com with ESMTP; 29 Nov 2016 18:26:36 -0800 Received: from fmsmsx157.amr.corp.intel.com (10.18.116.73) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.248.2; Tue, 29 Nov 2016 18:26:36 -0800 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by FMSMSX157.amr.corp.intel.com (10.18.116.73) with Microsoft SMTP Server (TLS) id 14.3.248.2; Tue, 29 Nov 2016 18:26:35 -0800 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.96]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.96]) with mapi id 14.03.0248.002; Wed, 30 Nov 2016 10:26:32 +0800 From: "Zhang, Qi Z" To: "Yigit, Ferruh" , "Wu, Jingjing" , "Zhang, Helin" CC: "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH 1/1] net/i40e: enable auto link update for XXV710 Thread-Index: AQHSRueyknjg1BZ9kkKNIim/1ZSEH6DvvPYAgAEObNA= Date: Wed, 30 Nov 2016 02:26:31 +0000 Message-ID: <039ED4275CED7440929022BC67E7061150672A60@SHSMSX103.ccr.corp.intel.com> References: <1480031006-15702-1-git-send-email-qi.z.zhang@intel.com> <2219dc42-a414-0e23-6f77-b3706949af8e@intel.com> In-Reply-To: <2219dc42-a414-0e23-6f77-b3706949af8e@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYWU1NjRhMTQtMDc3Mi00NDhkLTg1MTMtMDI4MjQ4MDZjMWNhIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IkhkdVdFbUZySkl2aFpzN0hObE9RdzAxQUxXeHRRTjVoXC9YelZEaE1WXC82dz0ifQ== x-ctpclassification: CTP_IC x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 1/1] net/i40e: enable auto link update for XXV710 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Nov 2016 02:26:38 -0000 Hi Ferruh: > -----Original Message----- > From: Yigit, Ferruh > Sent: Wednesday, November 30, 2016 1:46 AM > To: Zhang, Qi Z ; Wu, Jingjing ; > Zhang, Helin > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH 1/1] net/i40e: enable auto link update for > XXV710 >=20 > Hi Qi, >=20 > On 11/24/2016 11:43 PM, Qi Zhang wrote: > > This patch remove the limitation that XXV710 device does >=20 > XXV710 is 25G device, and support added in 16.11 (please correct me if th= is is > wrong.), but I can't find any DPDK documentation for this device. >=20 > Can you please add some documentation, at least to http://dpdk.org/doc/ni= cs > and http://dpdk.org/doc/guides/nics/i40e.html > in a different patch? For 16.11, since XXV710 is not officially supported, so they are missing in= document. For 17.02 this will be updated. Thanks for remind. >=20 > > not support auto link update. >=20 > Can you please add more details that why we can remove the limitation now= ? Ok, will update in v2. >=20 > > > > Signed-off-by: Qi Zhang > > --- > > drivers/net/i40e/i40e_ethdev.c | 8 ++++---- > > 1 file changed, 4 insertions(+), 4 deletions(-) > > > > diff --git a/drivers/net/i40e/i40e_ethdev.c > > b/drivers/net/i40e/i40e_ethdev.c index 67778ba..b7a916d 100644 > > --- a/drivers/net/i40e/i40e_ethdev.c > > +++ b/drivers/net/i40e/i40e_ethdev.c > > @@ -1628,6 +1628,8 @@ i40e_phy_conf_link(struct i40e_hw *hw, > > > > /* use get_phy_abilities_resp value for the rest */ > > phy_conf.phy_type =3D phy_ab.phy_type; > > + phy_conf.phy_type_ext =3D phy_ab.phy_type_ext; > > + phy_conf.fec_config =3D phy_ab.mod_type_ext; >=20 > And these changes look like called for all device types, just to double c= heck, are > these 25G specific? Actually only XXV710 need this two lines, but base on firmware engineer's i= nput,=20 this could be implemented in generic way since no impact for other i40e dev= ices. >=20 > > phy_conf.eee_capability =3D phy_ab.eee_capability; > > phy_conf.eeer =3D phy_ab.eeer_val; > > phy_conf.low_power_ctrl =3D phy_ab.d3_lpan; @@ -1653,8 +1655,7 @@ > > i40e_apply_link_speed(struct rte_eth_dev *dev) > > struct rte_eth_conf *conf =3D &dev->data->dev_conf; > > > > speed =3D i40e_parse_link_speeds(conf->link_speeds); > > - if (!I40E_PHY_TYPE_SUPPORT_25G(hw->phy.phy_types)) > > - abilities |=3D I40E_AQ_PHY_ENABLE_ATOMIC_LINK; > > + abilities |=3D I40E_AQ_PHY_ENABLE_ATOMIC_LINK; > > if (!(conf->link_speeds & ETH_LINK_SPEED_FIXED)) > > abilities |=3D I40E_AQ_PHY_AN_ENABLED; > > abilities |=3D I40E_AQ_PHY_LINK_ENABLED; @@ -1990,8 +1991,7 @@ > > i40e_dev_set_link_down(struct rte_eth_dev *dev) > > uint8_t abilities =3D 0; > > struct i40e_hw *hw =3D > I40E_DEV_PRIVATE_TO_HW(dev->data->dev_private); > > > > - if (!I40E_PHY_TYPE_SUPPORT_25G(hw->phy.phy_types)) > > - abilities =3D I40E_AQ_PHY_ENABLE_ATOMIC_LINK; > > + abilities =3D I40E_AQ_PHY_ENABLE_ATOMIC_LINK; > > return i40e_phy_conf_link(hw, abilities, speed); } > > > > Thanks! Qi