From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id A5F211023 for ; Wed, 25 Jan 2017 02:58:24 +0100 (CET) Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga103.jf.intel.com with ESMTP; 24 Jan 2017 17:58:23 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,281,1477983600"; d="scan'208";a="52128537" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga004.jf.intel.com with ESMTP; 24 Jan 2017 17:58:23 -0800 Received: from fmsmsx123.amr.corp.intel.com (10.18.125.38) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.248.2; Tue, 24 Jan 2017 17:58:23 -0800 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by fmsmsx123.amr.corp.intel.com (10.18.125.38) with Microsoft SMTP Server (TLS) id 14.3.248.2; Tue, 24 Jan 2017 17:58:22 -0800 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.20]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.177]) with mapi id 14.03.0248.002; Wed, 25 Jan 2017 09:58:20 +0800 From: "Zhang, Qi Z" To: "Wu, Jingjing" , "Zhang, Helin" CC: "dev@dpdk.org" Thread-Topic: [PATCH] net/i40e: fix x86 vPMD Rx checksum flag Thread-Index: AQHSdq3Ty5RlFbENw0+Qdktt4lXg3aFIbx9w Date: Wed, 25 Jan 2017 01:58:19 +0000 Message-ID: <039ED4275CED7440929022BC67E706115305662F@SHSMSX103.ccr.corp.intel.com> References: <1485283755-10944-1-git-send-email-qi.z.zhang@intel.com> In-Reply-To: <1485283755-10944-1-git-send-email-qi.z.zhang@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZTY3NmEwZGYtYjVmYy00NDVkLTkzOWUtMTYxNGI2MTIyMzQ4IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6Im12cEZKd1RIYnArekVoTHVkTVNpRWwxSnRVMHVCVU5UdHgwOFRyWVBlcEk9In0= x-ctpclassification: CTP_IC x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] net/i40e: fix x86 vPMD Rx checksum flag X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Jan 2017 01:58:25 -0000 Please ignore this, I forgot to remove the debug line. > -----Original Message----- > From: Zhang, Qi Z > Sent: Wednesday, January 25, 2017 2:49 AM > To: Wu, Jingjing ; Zhang, Helin > > Cc: dev@dpdk.org; Zhang, Qi Z > Subject: [PATCH] net/i40e: fix x86 vPMD Rx checksum flag >=20 > When no error reported in Rx descriptor, we should set CKSUM_GOOD flag > before return. >=20 > Fixes: 9966a00a0688 ("net/i40e: enable bad checksum flags in vector Rx")p= le >=20 > Signed-off-by: Qi Zhang > --- > drivers/net/i40e/i40e_rxtx_vec_sse.c | 38 > ++++++++++++++++++++++++++++-------- > 1 file changed, 30 insertions(+), 8 deletions(-) >=20 > diff --git a/drivers/net/i40e/i40e_rxtx_vec_sse.c > b/drivers/net/i40e/i40e_rxtx_vec_sse.c > index 7c84a41..2c4061c 100644 > --- a/drivers/net/i40e/i40e_rxtx_vec_sse.c > +++ b/drivers/net/i40e/i40e_rxtx_vec_sse.c > @@ -148,6 +148,20 @@ desc_to_olflags_v(__m128i descs[4], struct rte_mbuf > **rx_pkts) > const __m128i rss_vlan_msk =3D _mm_set_epi32( > 0x1c03804, 0x1c03804, 0x1c03804, 0x1c03804); >=20 > + const __m128i cksum_mask =3D _mm_set_epi32( > + PKT_RX_IP_CKSUM_GOOD | PKT_RX_IP_CKSUM_BAD | > + PKT_RX_L4_CKSUM_GOOD | PKT_RX_L4_CKSUM_BAD | > + PKT_RX_EIP_CKSUM_BAD, > + PKT_RX_IP_CKSUM_GOOD | PKT_RX_IP_CKSUM_BAD | > + PKT_RX_L4_CKSUM_GOOD | PKT_RX_L4_CKSUM_BAD | > + PKT_RX_EIP_CKSUM_BAD, > + PKT_RX_IP_CKSUM_GOOD | PKT_RX_IP_CKSUM_BAD | > + PKT_RX_L4_CKSUM_GOOD | PKT_RX_L4_CKSUM_BAD | > + PKT_RX_EIP_CKSUM_BAD, > + PKT_RX_IP_CKSUM_GOOD | PKT_RX_IP_CKSUM_BAD | > + PKT_RX_L4_CKSUM_GOOD | PKT_RX_L4_CKSUM_BAD | > + PKT_RX_EIP_CKSUM_BAD); > + > /* map rss and vlan type to rss hash and vlan flag */ > const __m128i vlan_flags =3D _mm_set_epi8(0, 0, 0, 0, > 0, 0, 0, 0, > @@ -160,14 +174,17 @@ desc_to_olflags_v(__m128i descs[4], struct > rte_mbuf **rx_pkts) > 0, 0, PKT_RX_FDIR, 0); >=20 > const __m128i l3_l4e_flags =3D _mm_set_epi8(0, 0, 0, 0, 0, 0, 0, 0, > - PKT_RX_EIP_CKSUM_BAD | PKT_RX_L4_CKSUM_BAD | > PKT_RX_IP_CKSUM_BAD, > - PKT_RX_EIP_CKSUM_BAD | PKT_RX_L4_CKSUM_BAD, > - PKT_RX_EIP_CKSUM_BAD | PKT_RX_IP_CKSUM_BAD, > - PKT_RX_EIP_CKSUM_BAD, > - PKT_RX_L4_CKSUM_BAD | PKT_RX_IP_CKSUM_BAD, > - PKT_RX_L4_CKSUM_BAD, > - PKT_RX_IP_CKSUM_BAD, > - 0); > + /* shift right 1 bit to make sure it not exceed 255 */ > + (PKT_RX_EIP_CKSUM_BAD | PKT_RX_L4_CKSUM_BAD | > + PKT_RX_IP_CKSUM_BAD) >> 1, > + (PKT_RX_IP_CKSUM_GOOD | PKT_RX_EIP_CKSUM_BAD | > + PKT_RX_L4_CKSUM_BAD) >> 1, > + (PKT_RX_EIP_CKSUM_BAD | PKT_RX_IP_CKSUM_BAD) >> 1, > + (PKT_RX_IP_CKSUM_GOOD | PKT_RX_EIP_CKSUM_BAD) >> 1, > + (PKT_RX_L4_CKSUM_BAD | PKT_RX_IP_CKSUM_BAD) >> 1, > + (PKT_RX_IP_CKSUM_GOOD | PKT_RX_L4_CKSUM_BAD) >> 1, > + PKT_RX_IP_CKSUM_BAD >> 1, > + (PKT_RX_IP_CKSUM_GOOD | PKT_RX_L4_CKSUM_GOOD) >> 1); >=20 > vlan0 =3D _mm_unpackhi_epi32(descs[0], descs[1]); > vlan1 =3D _mm_unpackhi_epi32(descs[2], descs[3]); @@ -181,6 +198,10 > @@ desc_to_olflags_v(__m128i descs[4], struct rte_mbuf **rx_pkts) >=20 > l3_l4e =3D _mm_srli_epi32(vlan1, 22); > l3_l4e =3D _mm_shuffle_epi8(l3_l4e_flags, l3_l4e); > + /* then we shift left 1 bit */ > + l3_l4e =3D _mm_slli_epi32(l3_l4e, 1); > + /* we need to mask out the reduntant bits */ > + l3_l4e =3D _mm_and_si128(l3_l4e, cksum_mask); >=20 > vlan0 =3D _mm_or_si128(vlan0, rss); > vlan0 =3D _mm_or_si128(vlan0, l3_l4e); > @@ -189,6 +210,7 @@ desc_to_olflags_v(__m128i descs[4], struct rte_mbuf > **rx_pkts) > rx_pkts[1]->ol_flags =3D _mm_extract_epi16(vlan0, 2); > rx_pkts[2]->ol_flags =3D _mm_extract_epi16(vlan0, 4); > rx_pkts[3]->ol_flags =3D _mm_extract_epi16(vlan0, 6); > + printf("ol_flags =3D %lx\n", rx_pkts[0]->ol_flags); > } > #else > #define desc_to_olflags_v(desc, rx_pkts) do {} while (0) > -- > 2.7.4