From: "Zhang, Qi Z" <qi.z.zhang@intel.com>
To: "Xing, Beilei" <beilei.xing@intel.com>,
"Wu, Jingjing" <jingjing.wu@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2] net/i40e: fix testpmd setup error when bulk is disabled
Date: Thu, 20 Apr 2017 08:57:41 +0000 [thread overview]
Message-ID: <039ED4275CED7440929022BC67E706115308DBC1@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <1492678296-115636-1-git-send-email-beilei.xing@intel.com>
> -----Original Message-----
> From: Xing, Beilei
> Sent: Thursday, April 20, 2017 4:52 PM
> To: Wu, Jingjing <jingjing.wu@intel.com>; Zhang, Qi Z <qi.z.zhang@intel.com>
> Cc: dev@dpdk.org
> Subject: [PATCH v2] net/i40e: fix testpmd setup error when bulk is disabled
>
> Testpmd failed to start when
> CONFIG_RTE_LIBRTE_I40E_RX_ALLOW_BULK_ALLOC
> is disabled, the root cause is the length of sw_ring and queue are incorrect
> with the above configuration.
>
> Fixes: 0be295312966 ("net/i40e: fix compile error")
>
> Signed-off-by: Beilei Xing <beilei.xing@intel.com>
> ---
> v2 change:
> Correct the length of queue when BULK is disabled.
>
> drivers/net/i40e/i40e_rxtx.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/drivers/net/i40e/i40e_rxtx.c b/drivers/net/i40e/i40e_rxtx.c index
> e5471b1..9f697d7 100644
> --- a/drivers/net/i40e/i40e_rxtx.c
> +++ b/drivers/net/i40e/i40e_rxtx.c
> @@ -1791,13 +1791,11 @@ i40e_dev_rx_queue_setup(struct rte_eth_dev
> *dev,
> /* Allocate the maximun number of RX ring hardware descriptor. */
> len = I40E_MAX_RING_DESC;
>
> -#ifdef RTE_LIBRTE_I40E_RX_ALLOW_BULK_ALLOC
> /**
> * Allocating a little more memory because vectorized/bulk_alloc Rx
> * functions doesn't check boundaries each time.
> */
> len += RTE_PMD_I40E_RX_MAX_BURST;
> -#endif
>
> ring_size = RTE_ALIGN(len * sizeof(union i40e_rx_desc),
> I40E_DMA_MEM_ALIGN);
> @@ -1816,11 +1814,7 @@ i40e_dev_rx_queue_setup(struct rte_eth_dev
> *dev,
> rxq->rx_ring_phys_addr = rte_mem_phy2mch(rz->memseg_id,
> rz->phys_addr);
> rxq->rx_ring = (union i40e_rx_desc *)rz->addr;
>
> -#ifdef RTE_LIBRTE_I40E_RX_ALLOW_BULK_ALLOC
> len = (uint16_t)(nb_desc + RTE_PMD_I40E_RX_MAX_BURST); -#else
> - len = nb_desc;
> -#endif
>
> /* Allocate the software ring. */
> rxq->sw_ring =
> --
> 2.5.5
Acked-by: Qi Zhang <qi.z.zhang@intel.com>
prev parent reply other threads:[~2017-04-20 8:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-20 8:51 Beilei Xing
2017-04-20 8:57 ` Zhang, Qi Z [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=039ED4275CED7440929022BC67E706115308DBC1@SHSMSX103.ccr.corp.intel.com \
--to=qi.z.zhang@intel.com \
--cc=beilei.xing@intel.com \
--cc=dev@dpdk.org \
--cc=jingjing.wu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).