From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id A498F7CE8 for ; Fri, 2 Jun 2017 04:00:17 +0200 (CEST) Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 01 Jun 2017 19:00:16 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.39,282,1493708400"; d="scan'208";a="93833628" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by orsmga004.jf.intel.com with ESMTP; 01 Jun 2017 19:00:16 -0700 Received: from fmsmsx113.amr.corp.intel.com (10.18.116.7) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 1 Jun 2017 19:00:16 -0700 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by FMSMSX113.amr.corp.intel.com (10.18.116.7) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 1 Jun 2017 19:00:15 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.116]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.197]) with mapi id 14.03.0319.002; Fri, 2 Jun 2017 10:00:13 +0800 From: "Zhang, Qi Z" To: "Lu, Wenzhuo" , "Zhang, Helin" CC: "dev@dpdk.org" Thread-Topic: [PATCH v2 3/3] net/ixgbe: enable flex bytes for generic flow API Thread-Index: AQHS2oIciFgtRINzc0G3bFmVJis1v6IQSb8AgACIIoA= Date: Fri, 2 Jun 2017 02:00:13 +0000 Message-ID: <039ED4275CED7440929022BC67E70611530A71E0@SHSMSX103.ccr.corp.intel.com> References: <1496259940-15547-1-git-send-email-qi.z.zhang@intel.com> <1496259940-15547-4-git-send-email-qi.z.zhang@intel.com> <6A0DE07E22DDAD4C9103DF62FEBC09093B5CAFB2@shsmsx102.ccr.corp.intel.com> In-Reply-To: <6A0DE07E22DDAD4C9103DF62FEBC09093B5CAFB2@shsmsx102.ccr.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 10.0.102.7 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 3/3] net/ixgbe: enable flex bytes for generic flow API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Jun 2017 02:00:19 -0000 > -----Original Message----- > From: Lu, Wenzhuo > Sent: Friday, June 2, 2017 9:49 AM > To: Zhang, Qi Z ; Zhang, Helin > > Cc: dev@dpdk.org > Subject: RE: [PATCH v2 3/3] net/ixgbe: enable flex bytes for generic flow= API >=20 > Hi Qi, >=20 >=20 > > -----Original Message----- > > From: Zhang, Qi Z > > Sent: Thursday, June 1, 2017 3:46 AM > > To: Lu, Wenzhuo; Zhang, Helin > > Cc: dev@dpdk.org; Zhang, Qi Z > > Subject: [PATCH v2 3/3] net/ixgbe: enable flex bytes for generic flow > > API > > > > Add fdir flex byte support for rte_flow APIs. > > > > Signed-off-by: Qi Zhang > > --- > > > > v2: > > - fix couple checkpatch errors. > > > > drivers/net/ixgbe/ixgbe_ethdev.h | 3 + > > drivers/net/ixgbe/ixgbe_fdir.c | 31 ++++++++- > > drivers/net/ixgbe/ixgbe_flow.c | 137 > > ++++++++++++++++++++++++++++++++++++++- > > 3 files changed, 167 insertions(+), 4 deletions(-) >=20 >=20 > > diff --git a/drivers/net/ixgbe/ixgbe_fdir.c > > b/drivers/net/ixgbe/ixgbe_fdir.c index 7f6c7b5..950f5ba 100644 > > --- a/drivers/net/ixgbe/ixgbe_fdir.c > > +++ b/drivers/net/ixgbe/ixgbe_fdir.c > > @@ -302,7 +302,7 @@ fdir_set_input_mask_82599(struct rte_eth_dev > *dev) > > * mask VM pool and DIPv6 since there are currently not supported > > * mask FLEX byte, it will be set in flex_conf > > */ > > - uint32_t fdirm =3D IXGBE_FDIRM_POOL | IXGBE_FDIRM_DIPv6 | > > IXGBE_FDIRM_FLEX; > > + uint32_t fdirm =3D IXGBE_FDIRM_POOL | IXGBE_FDIRM_DIPv6; > > uint32_t fdirtcpm; /* TCP source and destination port masks. */ > > uint32_t fdiripv6m; /* IPv6 source and destination masks. */ > > volatile uint32_t *reg; > > @@ -333,6 +333,10 @@ fdir_set_input_mask_82599(struct rte_eth_dev > *dev) > > return -EINVAL; > > } > > > > + /* flex byte mask */ > > + if (info->mask.flex_bytes_mask =3D=3D 0) > > + fdirm |=3D IXGBE_FDIRM_FLEX; > > + > > IXGBE_WRITE_REG(hw, IXGBE_FDIRM, fdirm); > Should the same change be done for x550? >=20 Currently I didn't see it is necessary. Because I saw fdir_set_input_mask_x550 will only be used for mac-vlan and t= unneling filter where flex byte is not considered in this patch. so keep it disabled Please correct if I miss something.