From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id C5E7925E5 for ; Wed, 29 Nov 2017 07:54:08 +0100 (CET) Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 28 Nov 2017 22:54:07 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.44,471,1505804400"; d="scan'208";a="181441899" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by fmsmga005.fm.intel.com with ESMTP; 28 Nov 2017 22:54:07 -0800 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 28 Nov 2017 22:54:07 -0800 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.213]) by SHSMSX104.ccr.corp.intel.com ([169.254.5.152]) with mapi id 14.03.0319.002; Wed, 29 Nov 2017 14:54:05 +0800 From: "Zhang, Qi Z" To: zhouyangchao , "dev@dpdk.org" CC: "qi.z.zhang@intel.comqi.z.zhang@intel.com" Thread-Topic: [PATCH] net/fm10k: remove RSS restriction with num of queues Thread-Index: AQHTaNkXqIIRh4/Qg0WsxOm+1/ilJKMq6kog Date: Wed, 29 Nov 2017 06:54:04 +0000 Message-ID: <039ED4275CED7440929022BC67E706115311736D@SHSMSX103.ccr.corp.intel.com> References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] net/fm10k: remove RSS restriction with num of queues X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Nov 2017 06:54:09 -0000 Hi: > -----Original Message----- > From: zhouyangchao [mailto:zhouyates@gmail.com] > Sent: Wednesday, November 29, 2017 2:12 PM > To: dev@dpdk.org > Cc: qi.z.zhang@intel.comqi.z.zhang@intel.com > Subject: [PATCH] net/fm10k: remove RSS restriction with num of queues >=20 > FM10K HW does not have such restrictions. >=20 > Signed-off-by: Yangchao Zhou > --- > drivers/net/fm10k/fm10k_ethdev.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) >=20 > diff --git a/drivers/net/fm10k/fm10k_ethdev.c > b/drivers/net/fm10k/fm10k_ethdev.c > index 2d05a46..403f6c5 100644 > --- a/drivers/net/fm10k/fm10k_ethdev.c > +++ b/drivers/net/fm10k/fm10k_ethdev.c > @@ -533,9 +533,8 @@ fm10k_dev_rss_configure(struct rte_eth_dev *dev) > 0x6A, 0x42, 0xB7, 0x3B, 0xBE, 0xAC, 0x01, 0xFA, > }; >=20 > - if (dev->data->nb_rx_queues =3D=3D 1 || > - dev_conf->rxmode.mq_mode !=3D ETH_MQ_RX_RSS || > - dev_conf->rx_adv_conf.rss_conf.rss_hf =3D=3D 0) { Yes, you can enable RSS with single queue, but it is not necessary. > + if (dev_conf->rxmode.mq_mode !=3D ETH_MQ_RX_RSS || > + dev_conf->rx_adv_conf.rss_conf.rss_hf =3D=3D 0) { > FM10K_WRITE_REG(hw, FM10K_MRQC(0), 0); > return; > } > -- > 2.9.0.windows.1 >=20 >=20 Regards Qi