From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 578432A5D for ; Tue, 5 Dec 2017 02:51:34 +0100 (CET) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Dec 2017 17:51:33 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,362,1508828400"; d="scan'208";a="9597575" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by fmsmga004.fm.intel.com with ESMTP; 04 Dec 2017 17:51:33 -0800 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 4 Dec 2017 17:51:33 -0800 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.213]) by shsmsx102.ccr.corp.intel.com ([169.254.2.175]) with mapi id 14.03.0319.002; Tue, 5 Dec 2017 09:51:31 +0800 From: "Zhang, Qi Z" To: zhouyangchao , "dev@dpdk.org" Thread-Topic: [PATCH] net/fm10k: remove RSS restriction with num of queues Thread-Index: AQHTbMql61YgeO6JhE27SFjI/I7OsaMz933Q Date: Tue, 5 Dec 2017 01:51:30 +0000 Message-ID: <039ED4275CED7440929022BC67E7061153119185@SHSMSX103.ccr.corp.intel.com> References: <889ce4b6-5f2e-4830-a750-4c75ee0c7749@zyc-PC.local> In-Reply-To: <889ce4b6-5f2e-4830-a750-4c75ee0c7749@zyc-PC.local> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] net/fm10k: remove RSS restriction with num of queues X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Dec 2017 01:51:35 -0000 > -----Original Message----- > From: zhouyangchao [mailto:zhouyates@gmail.com] > Sent: Monday, December 4, 2017 2:38 PM > To: dev@dpdk.org > Cc: Zhang, Qi Z ; Zhang, Qi Z > Subject: [PATCH] net/fm10k: remove RSS restriction with num of queues >=20 > FM10K HW does not have such restrictions. >=20 > Enabling RSS with single queue is not used to distribute flow but to comp= ute > a RSS hash value. > It can reduce cpu cycles of computing a hash value with five tuples. > In addition, there is an explicit method to disable RSS instead of an obs= cure > way. >=20 > Signed-off-by: Yangchao Zhou > --- > drivers/net/fm10k/fm10k_ethdev.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) >=20 > diff --git a/drivers/net/fm10k/fm10k_ethdev.c > b/drivers/net/fm10k/fm10k_ethdev.c > index 2d05a46..403f6c5 100644 > --- a/drivers/net/fm10k/fm10k_ethdev.c > +++ b/drivers/net/fm10k/fm10k_ethdev.c > @@ -533,9 +533,8 @@ fm10k_dev_rss_configure(struct rte_eth_dev *dev) > 0x6A, 0x42, 0xB7, 0x3B, 0xBE, 0xAC, 0x01, 0xFA, > }; >=20 > - if (dev->data->nb_rx_queues =3D=3D 1 || > - dev_conf->rxmode.mq_mode !=3D ETH_MQ_RX_RSS || > - dev_conf->rx_adv_conf.rss_conf.rss_hf =3D=3D 0) { > + if (dev_conf->rxmode.mq_mode !=3D ETH_MQ_RX_RSS || > + dev_conf->rx_adv_conf.rss_conf.rss_hf =3D=3D 0) { > FM10K_WRITE_REG(hw, FM10K_MRQC(0), 0); > return; > } > -- > 2.9.0.windows.1 >=20 >=20 Acked-by: Qi Zhang Regards Qi=09