From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id CCB4523D for ; Tue, 19 Dec 2017 14:21:01 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Dec 2017 05:21:00 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,426,1508828400"; d="scan'208";a="13577518" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga003.jf.intel.com with ESMTP; 19 Dec 2017 05:21:00 -0800 Received: from fmsmsx119.amr.corp.intel.com (10.18.124.207) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 19 Dec 2017 05:21:00 -0800 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by FMSMSX119.amr.corp.intel.com (10.18.124.207) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 19 Dec 2017 05:20:59 -0800 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.213]) by shsmsx102.ccr.corp.intel.com ([169.254.2.175]) with mapi id 14.03.0319.002; Tue, 19 Dec 2017 21:20:57 +0800 From: "Zhang, Qi Z" To: "Xing, Beilei" CC: "dev@dpdk.org" Thread-Topic: [PATCH] net/i40e: fix FDIR input set conflict Thread-Index: AQHTd7/wS04rAxXbp0CG8fyQt7gGtqNKqNpQ Date: Tue, 19 Dec 2017 13:20:56 +0000 Message-ID: <039ED4275CED7440929022BC67E7061153122DB1@SHSMSX103.ccr.corp.intel.com> References: <1513574457-47623-1-git-send-email-beilei.xing@intel.com> In-Reply-To: <1513574457-47623-1-git-send-email-beilei.xing@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] net/i40e: fix FDIR input set conflict X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Dec 2017 13:21:02 -0000 > -----Original Message----- > From: Xing, Beilei > Sent: Monday, December 18, 2017 1:21 PM > To: Zhang, Qi Z > Cc: dev@dpdk.org > Subject: [PATCH] net/i40e: fix FDIR input set conflict >=20 > The first FDIR rule for some PCTYPE will configure input set and create f= low, > the following flows must use the same input set, otherwise will cause inp= ut > set conflict and fail to create flow. > But if creating the first rule after flow flush, input set should be > re-configured. >=20 > Fixes: 42044b69c67d ("net/i40e: support input set selection for FDIR") > c: stable@dpdk.org >=20 > Signed-off-by: Beilei Xing > --- > drivers/net/i40e/i40e_flow.c | 5 +++++ > 1 file changed, 5 insertions(+) >=20 > diff --git a/drivers/net/i40e/i40e_flow.c b/drivers/net/i40e/i40e_flow.c = index > 7e4936e..a9e7a0d 100644 > --- a/drivers/net/i40e/i40e_flow.c > +++ b/drivers/net/i40e/i40e_flow.c > @@ -4406,6 +4406,7 @@ i40e_flow_flush_fdir_filter(struct i40e_pf *pf) > struct rte_eth_dev *dev =3D pf->adapter->eth_dev; > struct i40e_fdir_info *fdir_info =3D &pf->fdir; > struct i40e_fdir_filter *fdir_filter; > + enum i40e_filter_pctype pctype; > struct rte_flow *flow; > void *temp; > int ret; > @@ -4427,6 +4428,10 @@ i40e_flow_flush_fdir_filter(struct i40e_pf *pf) > rte_free(flow); > } > } > + > + for (pctype =3D I40E_FILTER_PCTYPE_NONF_IPV4_UDP; > + pctype <=3D I40E_FILTER_PCTYPE_L2_PAYLOAD; pctype++) > + pf->fdir.inset_flag[pctype] =3D 0; > } >=20 > return ret; > -- > 2.5.5 Acked-by: Qi Zhang BTW, do we also need a fix for flow destroy? When the last flow that use in= put set be destroyed, inset_flag also need to be reset? Regards Qi