Re: [dpdk-dev] [PATCH] net/i40e: fix issues for RSS flow API

["Zhang, Qi Z" <qi.z.zhang@intel.com>]

Hi Wei:
	

> -----Original Message-----
> From: Zhao1, Wei
> Sent: Tuesday, January 23, 2018 2:43 PM
> To: dev@dpdk.org
> Cc: Zhang, Qi Z <qi.z.zhang@intel.com>; Zhao1, Wei <wei.zhao1@intel.com>
> Subject: [PATCH] net/i40e: fix issues for RSS flow API
> 
> This patch fix issues check from DPDK coverity issues.
> 
> Fixes: ecad87d22383e ("net/i40e: move RSS to flow API") Coverity issues:
> 257020 257024 257037
> 
> Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
> ---
>  drivers/net/i40e/i40e_ethdev.c | 2 +-
>  drivers/net/i40e/i40e_flow.c   | 4 ++--
>  2 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c
> index 5ea9f99..b0db458 100644
> --- a/drivers/net/i40e/i40e_ethdev.c
> +++ b/drivers/net/i40e/i40e_ethdev.c
> @@ -11681,7 +11681,7 @@ i40e_config_rss_filter(struct i40e_pf *pf,
>  							sizeof(uint32_t);
>  	}
> 
> -	return i40e_hw_rss_hash_set(pf, &rss_conf);
> +	i40e_hw_rss_hash_set(pf, &rss_conf);
> 
>  	rte_memcpy(rss_info,
>  		conf, sizeof(struct i40e_rte_flow_rss_conf)); diff --git
> a/drivers/net/i40e/i40e_flow.c b/drivers/net/i40e/i40e_flow.c index
> cd9a9b6..a23f485 100644
> --- a/drivers/net/i40e/i40e_flow.c
> +++ b/drivers/net/i40e/i40e_flow.c
> @@ -4201,6 +4201,7 @@ i40e_flow_parse_rss_action(struct rte_eth_dev
> *dev,
>  	struct i40e_rte_flow_rss_conf *rss_info = &pf->rss_info;
>  	uint16_t i, j, n, tmp;
>  	uint32_t index = 0;
> +	uint64_t hf_bit = 1;
> 
>  	NEXT_ITEM_OF_ACTION(act, actions, index);
>  	rss = (const struct rte_flow_action_rss *)act->conf; @@ -4219,7
> +4220,7 @@ i40e_flow_parse_rss_action(struct rte_eth_dev *dev,
> 
>  	if (action_flag) {
>  		for (n = 0; n < 64; n++) {
> -			if (rss->rss_conf->rss_hf & (1 << n)) {
> +			if (rss->rss_conf->rss_hf & (hf_bit << n)) {
>  				conf_info->region[0].hw_flowtype[0] = n;
>  				conf_info->region[0].flowtype_num = 1;
>  				conf_info->queue_region_number = 1; @@ -4313,7
> +4314,6 @@ i40e_flow_parse_rss_action(struct rte_eth_dev *dev,
>  		}
> 
>  		rss_config->queue_region_conf = TRUE;
> -		return 0;
>  	}

Seems if you remove return 0, rss_config->queue_region_conf will be overwrite by FALSE at end, right?
> 
>  	if (!rss || !rss->num) {
> --
> 2.9.3