From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 86F56199B0 for ; Thu, 25 Jan 2018 08:49:49 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Jan 2018 23:49:48 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,411,1511856000"; d="scan'208";a="24591009" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga004.fm.intel.com with ESMTP; 24 Jan 2018 23:49:48 -0800 Received: from fmsmsx113.amr.corp.intel.com (10.18.116.7) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 24 Jan 2018 23:49:47 -0800 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by FMSMSX113.amr.corp.intel.com (10.18.116.7) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 24 Jan 2018 23:49:47 -0800 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.213]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.159]) with mapi id 14.03.0319.002; Thu, 25 Jan 2018 15:49:45 +0800 From: "Zhang, Qi Z" To: "Yang, Zhiyong" , "Xing, Beilei" CC: "dev@dpdk.org" , "Zhao1, Wei" Thread-Topic: [dpdk-dev] [PATCH] net/i40e: fix bug in RSS flow action parser Thread-Index: AQHTlZrov0IzAg0DxUyRuhRQaM8WGqODkuqAgACa2RA= Date: Thu, 25 Jan 2018 07:49:45 +0000 Message-ID: <039ED4275CED7440929022BC67E706115313392B@SHSMSX103.ccr.corp.intel.com> References: <20180125051033.40453-1-qi.z.zhang@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] net/i40e: fix bug in RSS flow action parser X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 25 Jan 2018 07:49:50 -0000 > -----Original Message----- > From: Yang, Zhiyong > Sent: Thursday, January 25, 2018 2:03 PM > To: Zhang, Qi Z ; Xing, Beilei > Cc: dev@dpdk.org; Zhao1, Wei ; Zhang, Qi Z > > Subject: RE: [dpdk-dev] [PATCH] net/i40e: fix bug in RSS flow action pars= er >=20 > Hi Qi, >=20 > > -----Original Message----- > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Qi Zhang > > Sent: Thursday, January 25, 2018 1:11 PM > > To: Xing, Beilei > > Cc: dev@dpdk.org; Zhao1, Wei ; Zhang, Qi Z > > > > Subject: [dpdk-dev] [PATCH] net/i40e: fix bug in RSS flow action > > parser > > > > Parameter action_flag is not used correctly in i40e_flow_parse_rss_acti= on. > > Also change it from point type to value type since it is not an output > > parameter. > > > > Fixes: ecad87d22383e ("net/i40e: move RSS to flow API") > > > > Signed-off-by: Qi Zhang > > --- > > drivers/net/i40e/i40e_flow.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/net/i40e/i40e_flow.c > > b/drivers/net/i40e/i40e_flow.c index a74fa08ab..74708f168 100644 > > --- a/drivers/net/i40e/i40e_flow.c > > +++ b/drivers/net/i40e/i40e_flow.c > > @@ -4188,7 +4188,7 @@ static int > > i40e_flow_parse_rss_action(struct rte_eth_dev *dev, > > const struct rte_flow_action *actions, > > struct rte_flow_error *error, > > - uint8_t *action_flag, > > + uint8_t action_flag, > > struct i40e_queue_regions *conf_info, > > union i40e_filter_t *filter) > > { > > @@ -4378,7 +4378,7 @@ i40e_parse_rss_filter(struct rte_eth_dev *dev, > > return ret; > > > > ret =3D i40e_flow_parse_rss_action(dev, actions, error, > > - &action_flag, &info, filter); > > + action_flag, &info, filter); >=20 > I wonder if action_flag =3D=3D ture targets to handle only the case > RTE_FLOW_ITEM_TYPE_ETH ? Base on Zhao Wei's current design, action_flag is the flag to distinguish i= f queue region RSS is based on specific flow type ( when it is true) or bas= ed on vlan priority (when it is false) Action_flag is decide by the pattern sequence eth only =3D> 1, or eth +vla= n | vlan only =3D> 0 Regards Qi >=20 > Thanks > Zhiyong >=20 > > if (ret) > > return ret; > > > > -- > > 2.13.6 >=20