From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 74537A496 for ; Wed, 14 Mar 2018 13:58:56 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 Mar 2018 05:58:54 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.47,470,1515484800"; d="scan'208";a="37314682" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga004.fm.intel.com with ESMTP; 14 Mar 2018 05:58:54 -0700 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 14 Mar 2018 05:58:54 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.235]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.166]) with mapi id 14.03.0319.002; Wed, 14 Mar 2018 20:58:42 +0800 From: "Zhang, Qi Z" To: "Rybalchenko, Kirill" , "Wu, Yanglong" , "dev@dpdk.org" CC: "Lu, Wenzhuo" , "Wu, Yanglong" Thread-Topic: [dpdk-dev] [PATCH] net/i40e:fix VSI stats error Thread-Index: AQHTmwJI829pozNRjkKXvj3wWQTJ2aPPW7+AgACT7mA= Date: Wed, 14 Mar 2018 12:58:42 +0000 Message-ID: <039ED4275CED7440929022BC67E706115316DC62@SHSMSX103.ccr.corp.intel.com> References: <20180201021128.174110-1-yanglong.wu@intel.com> <696B43C21188DF4F9C9091AAE4789B824E2D633D@IRSMSX108.ger.corp.intel.com> In-Reply-To: <696B43C21188DF4F9C9091AAE4789B824E2D633D@IRSMSX108.ger.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] net/i40e:fix VSI stats error X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Mar 2018 12:58:57 -0000 > -----Original Message----- > From: Rybalchenko, Kirill > Sent: Wednesday, March 14, 2018 8:00 PM > To: Wu, Yanglong ; dev@dpdk.org > Cc: Zhang, Qi Z ; Lu, Wenzhuo > ; Wu, Yanglong > Subject: RE: [dpdk-dev] [PATCH] net/i40e:fix VSI stats error >=20 >=20 > > -----Original Message----- > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Yanglong Wu > > Sent: Thursday 1 February 2018 02:11 > > To: dev@dpdk.org > > Cc: Zhang, Qi Z ; Lu, Wenzhuo > > ; Wu, Yanglong > > Subject: [dpdk-dev] [PATCH] net/i40e:fix VSI stats error > > > > In VF, the number of ibytes read from register have been stripped out This is not correct, statistic read from register I40E_GLV_GORCH|L does inc= lude CRC. It should be excluded. Regards Qi > > CRC already, but in stats, it subtracts CRC bytes again. So it lead to > > RX bytes is smaller than TX bytes. Do you mean, CRC is double stripped by software, or you assume=20 > > > > Fixes: 98abce23(fix VF statistics) > > Signed-off-by: Yanglong Wu > > --- > > drivers/net/i40e/i40e_ethdev.c | 4 ---- > > 1 file changed, 4 deletions(-) > > > > diff --git a/drivers/net/i40e/i40e_ethdev.c > > b/drivers/net/i40e/i40e_ethdev.c index c4df65df0..84e82889a 100644 > > --- a/drivers/net/i40e/i40e_ethdev.c > > +++ b/drivers/net/i40e/i40e_ethdev.c > > @@ -2440,10 +2440,6 @@ i40e_update_vsi_stats(struct i40e_vsi *vsi) > > i40e_stat_update_48(hw, I40E_GLV_BPRCH(idx), I40E_GLV_BPRCL(idx), > > vsi->offset_loaded, &oes->rx_broadcast, > > &nes->rx_broadcast); > > - /* exclude CRC bytes */ > > - nes->rx_bytes -=3D (nes->rx_unicast + nes->rx_multicast + > > - nes->rx_broadcast) * ETHER_CRC_LEN; > > - > > i40e_stat_update_32(hw, I40E_GLV_RDPC(idx), vsi->offset_loaded, > > &oes->rx_discards, &nes->rx_discards); > > /* GLV_REPC not supported */ > > -- > > 2.11.0 >=20 > Reviewed-by: Kirill Rybalchenko >=20 >=20