From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id E0CE72C12 for ; Thu, 15 Mar 2018 04:13:57 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 Mar 2018 20:13:56 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,308,1517904000"; d="scan'208";a="35141663" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga003.jf.intel.com with ESMTP; 14 Mar 2018 20:13:56 -0700 Received: from fmsmsx154.amr.corp.intel.com (10.18.116.70) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 14 Mar 2018 20:13:56 -0700 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by FMSMSX154.amr.corp.intel.com (10.18.116.70) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 14 Mar 2018 20:13:55 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.235]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.166]) with mapi id 14.03.0319.002; Thu, 15 Mar 2018 11:13:54 +0800 From: "Zhang, Qi Z" To: "Ananyev, Konstantin" , "thomas@monjalon.net" CC: "dev@dpdk.org" , "Xing, Beilei" , "Wu, Jingjing" , "Lu, Wenzhuo" Thread-Topic: [dpdk-dev] [PATCH v2 1/4] ether: support deferred queue setup Thread-Index: AQHTsdzO/92qABmyvEqdvvZYHITpPKPPNw0AgAFIbcA= Date: Thu, 15 Mar 2018 03:13:54 +0000 Message-ID: <039ED4275CED7440929022BC67E706115316DF0F@SHSMSX103.ccr.corp.intel.com> References: <20180212045314.171616-1-qi.z.zhang@intel.com> <20180302041306.90324-1-qi.z.zhang@intel.com> <20180302041306.90324-2-qi.z.zhang@intel.com> <2601191342CEEE43887BDE71AB9772589E28FA63@irsmsx105.ger.corp.intel.com> In-Reply-To: <2601191342CEEE43887BDE71AB9772589E28FA63@irsmsx105.ger.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 1/4] ether: support deferred queue setup X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Mar 2018 03:13:58 -0000 Hi Konstantin: > -----Original Message----- > From: Ananyev, Konstantin > Sent: Wednesday, March 14, 2018 8:32 PM > To: Zhang, Qi Z ; thomas@monjalon.net > Cc: dev@dpdk.org; Xing, Beilei ; Wu, Jingjing > ; Lu, Wenzhuo ; Zhang, Qi Z > > Subject: RE: [dpdk-dev] [PATCH v2 1/4] ether: support deferred queue setu= p >=20 > Hi Qi, >=20 > > > > The patch let etherdev driver expose the capability flag through > > rte_eth_dev_info_get when it support deferred queue configuraiton, > > then base on the flag rte_eth_[rx|tx]_queue_setup could decide > > continue to setup the queue or just return fail when device already > > started. > > > > Signed-off-by: Qi Zhang > > --- > > doc/guides/nics/features.rst | 8 ++++++++ > > lib/librte_ether/rte_ethdev.c | 30 ++++++++++++++++++------------ > > lib/librte_ether/rte_ethdev.h | 11 +++++++++++ > > 3 files changed, 37 insertions(+), 12 deletions(-) > > > > diff --git a/doc/guides/nics/features.rst > > b/doc/guides/nics/features.rst index 1b4fb979f..36ad21a1f 100644 > > --- a/doc/guides/nics/features.rst > > +++ b/doc/guides/nics/features.rst > > @@ -892,7 +892,15 @@ Documentation describes performance values. > > > > See ``dpdk.org/doc/perf/*``. > > > > +.. _nic_features_queue_deferred_setup_capabilities: > > > > +Queue deferred setup capabilities > > +--------------------------------- > > + > > +Supports queue setup / release after device started. > > + > > +* **[provides] rte_eth_dev_info**: > > > ``deferred_queue_config_capa:DEV_DEFERRED_RX_QUEUE_SETUP,DEV_DEFE > RRED_ > > TX_QUEUE_SETUP,DEV_DEFERRED_RX_QUEUE_RELE > > ASE,DEV_DEFERRED_TX_QUEUE_RELEASE``. > > +* **[related] API**: ``rte_eth_dev_info_get()``. > > > > .. _nic_features_other: > > > > diff --git a/lib/librte_ether/rte_ethdev.c > > b/lib/librte_ether/rte_ethdev.c index a6ce2a5ba..6c906c4df 100644 > > --- a/lib/librte_ether/rte_ethdev.c > > +++ b/lib/librte_ether/rte_ethdev.c > > @@ -1425,12 +1425,6 @@ rte_eth_rx_queue_setup(uint16_t port_id, > uint16_t rx_queue_id, > > return -EINVAL; > > } > > > > - if (dev->data->dev_started) { > > - RTE_PMD_DEBUG_TRACE( > > - "port %d must be stopped to allow configuration\n", port_id); > > - return -EBUSY; > > - } > > - > > RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->dev_infos_get, > -ENOTSUP); > > RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->rx_queue_setup, > -ENOTSUP); > > > > @@ -1474,10 +1468,19 @@ rte_eth_rx_queue_setup(uint16_t port_id, > uint16_t rx_queue_id, > > return -EINVAL; > > } > > > > + if (dev->data->dev_started && > > + !(dev_info.deferred_queue_config_capa & > > + DEV_DEFERRED_RX_QUEUE_SETUP)) > > + return -EINVAL; > > + >=20 > I think now you have to check here that the queue is stopped. > Otherwise you might attempt to reconfigure running queue. I'm not sure if it's necessary to let application use different API sequenc= e for a deferred configure and deferred re-configure. Can we just call dev_ops->rx_queue_stop before rx_queue_release here >=20 >=20 > > rxq =3D dev->data->rx_queues; > > if (rxq[rx_queue_id]) { > > RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->rx_queue_release, > > -ENOTSUP); >=20 > I don't think it is *that* straightforward. > rx_queue_setup() parameters can imply different rx function (and related = dev > icesettings) that are already setuped by previous queue_setup()/dev_start= . > So I think you need to do one of 2 things: > 1. rework ethdev layer to introduce a separate rx function (and related > settings) for each queue. > 2. at rx_queue_setup() if it is invoked after dev_start - check that give= n > queue settings wouldn't contradict with current device settings (rx func= tion, > etc.). > If they do - return an error. Yes, I think what we have is option 2 here, the dev_ops->rx_queue_setup wil= l return fail if conflict with previous setting I'm also thinking about option 1, the idea is to move per queue rx/tx funct= ion into driver layer, so it will not break existing API. 1. driver can expose the capability like per_queue_rx or per_queue_tx 2. application can enable this capability by dev_config with rte_eth_conf 3, if per_queue_rx is not enable, nothing change, so we are at option 2 4. if per_queue_rx is enabled, driver will set rx_pkt_burst with a hook fun= ction which redirect to an function ptr in a per queue rx function tables (= I guess performance is impacted somehow, but this is the cost if you want = different offload for different queue) >=20 > From my perspective - 1) is a better choice though it required more work, > and possibly ABI breakage. > I did some work in that direction as RFC: > http://dpdk.org/dev/patchwork/patch/31866/ I will learn this, thanks for the heads up. >=20 > 2) might be also possible, but looks a bit clumsy as rx_queue_setup() mig= ht > now fail even with valid parameters - all depends on previous queue > configurations. >=20 > Same story applies for TX. >=20 >=20 > > + if (dev->data->dev_started && > > + !(dev_info.deferred_queue_config_capa & > > + DEV_DEFERRED_RX_QUEUE_RELEASE)) > > + return -EINVAL; > > (*dev->dev_ops->rx_queue_release)(rxq[rx_queue_id]); > > rxq[rx_queue_id] =3D NULL; > > } > > @@ -1573,12 +1576,6 @@ rte_eth_tx_queue_setup(uint16_t port_id, > uint16_t tx_queue_id, > > return -EINVAL; > > } > > > > - if (dev->data->dev_started) { > > - RTE_PMD_DEBUG_TRACE( > > - "port %d must be stopped to allow configuration\n", port_id); > > - return -EBUSY; > > - } > > - > > RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->dev_infos_get, > -ENOTSUP); > > RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->tx_queue_setup, > -ENOTSUP); > > > > @@ -1596,10 +1593,19 @@ rte_eth_tx_queue_setup(uint16_t port_id, > uint16_t tx_queue_id, > > return -EINVAL; > > } > > > > + if (dev->data->dev_started && > > + !(dev_info.deferred_queue_config_capa & > > + DEV_DEFERRED_TX_QUEUE_SETUP)) > > + return -EINVAL; > > + > > txq =3D dev->data->tx_queues; > > if (txq[tx_queue_id]) { > > RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->tx_queue_release, > > -ENOTSUP); > > + if (dev->data->dev_started && > > + !(dev_info.deferred_queue_config_capa & > > + DEV_DEFERRED_TX_QUEUE_RELEASE)) > > + return -EINVAL; > > (*dev->dev_ops->tx_queue_release)(txq[tx_queue_id]); > > txq[tx_queue_id] =3D NULL; > > } > > diff --git a/lib/librte_ether/rte_ethdev.h > > b/lib/librte_ether/rte_ethdev.h index 036153306..410e58c50 100644 > > --- a/lib/librte_ether/rte_ethdev.h > > +++ b/lib/librte_ether/rte_ethdev.h > > @@ -981,6 +981,15 @@ struct rte_eth_conf { > > */ > > #define DEV_TX_OFFLOAD_SECURITY 0x00020000 > > > > +#define DEV_DEFERRED_RX_QUEUE_SETUP 0x00000001 /**< Deferred > setup rx > > +queue */ #define DEV_DEFERRED_TX_QUEUE_SETUP 0x00000002 /**< > Deferred > > +setup tx queue */ #define DEV_DEFERRED_RX_QUEUE_RELEASE > 0x00000004 > > +/**< Deferred release rx queue */ #define > > +DEV_DEFERRED_TX_QUEUE_RELEASE 0x00000008 /**< Deferred release > tx > > +queue */ > > + >=20 > I don't think we do need flags for both setup a and release. > If runtime setup is supported - surely dynamic release should be supporte= d > too. > Also probably RUNTIME_RX_QUEUE_SETUP sounds a bit better. Agree Thanks Qi >=20 > Konstantin >=20 > > /* > > * If new Tx offload capabilities are defined, they also must be > > * mentioned in rte_tx_offload_names in rte_ethdev.c file. > > @@ -1029,6 +1038,8 @@ struct rte_eth_dev_info { > > /** Configured number of rx/tx queues */ > > uint16_t nb_rx_queues; /**< Number of RX queues. */ > > uint16_t nb_tx_queues; /**< Number of TX queues. */ > > + uint64_t deferred_queue_config_capa; > > + /**< queues can be setup/release after dev_start (DEV_DEFERRED_). */ > > }; > > > > /** > > -- > > 2.13.6