From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id 823802C12 for ; Tue, 20 Mar 2018 11:01:43 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Mar 2018 03:01:40 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,334,1517904000"; d="scan'208";a="209749040" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga005.jf.intel.com with ESMTP; 20 Mar 2018 03:01:40 -0700 Received: from fmsmsx118.amr.corp.intel.com (10.18.116.18) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 20 Mar 2018 03:01:39 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by fmsmsx118.amr.corp.intel.com (10.18.116.18) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 20 Mar 2018 03:01:39 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.235]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.108]) with mapi id 14.03.0319.002; Tue, 20 Mar 2018 18:01:36 +0800 From: "Zhang, Qi Z" To: wangyunjian , "dev@dpdk.org" , "Rybalchenko, Kirill" CC: "caihe@huawei.com" Thread-Topic: [dpdk-dev] [PATCH v4] net/i40e: fix intr callback unregister by adding retry Thread-Index: AQHTwBlf2cezpsa99EuR3VzT3Bnbh6PY5GfQ Date: Tue, 20 Mar 2018 10:01:36 +0000 Message-ID: <039ED4275CED7440929022BC67E706115316FD79@SHSMSX103.ccr.corp.intel.com> References: <1521529284-15468-1-git-send-email-wangyunjian@huawei.com> In-Reply-To: <1521529284-15468-1-git-send-email-wangyunjian@huawei.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v4] net/i40e: fix intr callback unregister by adding retry X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Mar 2018 10:01:44 -0000 > -----Original Message----- > From: wangyunjian [mailto:wangyunjian@huawei.com] > Sent: Tuesday, March 20, 2018 3:01 PM > To: dev@dpdk.org; Zhang, Qi Z ; Rybalchenko, Kirill > > Cc: caihe@huawei.com; Yunjian Wang > Subject: [dpdk-dev] [PATCH v4] net/i40e: fix intr callback unregister by > adding retry >=20 > From: Yunjian Wang >=20 > The nic's interrupt source has some active callbacks, when the port hotpl= ug. > Add a retry to give more port's a chance to uninit before returning an er= ror. >=20 > Fixes: d42aaf30008b ("i40e: support port hotplug") >=20 > Signed-off-by: Yunjian Wang > Reviewed-by: Kirill Rybalchenko > Acked-by: Qi Zhang > --- > v2: > * Fix return value check > --- > v3: > * Fix comment suggested by Kirill Rybalchenko > --- > v4: > * Enlarge the timeout interval to 500ms suggested by Qi Zhang > --- > drivers/net/i40e/i40e_ethdev.c | 18 +++++++++++++++--- > 1 file changed, 15 insertions(+), 3 deletions(-) >=20 > diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethde= v.c > index 508b417..b99be27 100644 > --- a/drivers/net/i40e/i40e_ethdev.c > +++ b/drivers/net/i40e/i40e_ethdev.c > @@ -1533,6 +1533,7 @@ void i40e_flex_payload_reg_set_default(struct > i40e_hw *hw) > struct rte_flow *p_flow; > int ret; > uint8_t aq_fail =3D 0; > + int retries =3D 0; >=20 > PMD_INIT_FUNC_TRACE(); >=20 > @@ -1574,9 +1575,20 @@ void i40e_flex_payload_reg_set_default(struct > i40e_hw *hw) > /* disable uio intr before callback unregister */ > rte_intr_disable(intr_handle); >=20 > - /* register callback func to eal lib */ > - rte_intr_callback_unregister(intr_handle, > - i40e_dev_interrupt_handler, dev); > + /* unregister callback func to eal lib */ > + do { > + ret =3D rte_intr_callback_unregister(intr_handle, > + i40e_dev_interrupt_handler, dev); > + if (ret >=3D 0) { > + break; > + } else if (ret !=3D -EAGAIN) { > + PMD_INIT_LOG(ERR, > + "intr callback unregister failed: %d", > + ret); > + return ret; > + } > + i40e_msec_delay(500); > + } while (retries++ < 5); >=20 > i40e_rm_ethtype_filter_list(pf); > i40e_rm_tunnel_filter_list(pf); > -- > 1.8.3.1 >=20 Acked-by: Qi Zhang