Re: [dpdk-dev] [PATCH] net/i40e: remove unnecessary FDIR mask configuration

["Zhang, Qi Z" <qi.z.zhang@intel.com>]

> -----Original Message-----
> From: Rybalchenko, Kirill
> Sent: Wednesday, March 14, 2018 11:17 PM
> To: Xing, Beilei <beilei.xing@intel.com>; Zhang, Qi Z <qi.z.zhang@intel.com>
> Cc: dev@dpdk.org
> Subject: RE: [dpdk-dev] [PATCH] net/i40e: remove unnecessary FDIR mask
> configuration
> 
> 
> 
> > -----Original Message-----
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Beilei Xing
> > Sent: Sunday 11 February 2018 07:10
> > To: Zhang, Qi Z <qi.z.zhang@intel.com>
> > Cc: dev@dpdk.org
> > Subject: [dpdk-dev] [PATCH] net/i40e: remove unnecessary FDIR mask
> > configuration
> >
> > Remove unnecessary FDIR mask configuration, otherwise flow directory
> > mask will be changed when configuring hash input set.
> >
> > Signed-off-by: Beilei Xing <beilei.xing@intel.com>
> > ---
> >  drivers/net/i40e/rte_pmd_i40e.c | 4 ----
> >  1 file changed, 4 deletions(-)
> >
> > diff --git a/drivers/net/i40e/rte_pmd_i40e.c
> > b/drivers/net/i40e/rte_pmd_i40e.c index 1288c51..b684249 100644
> > --- a/drivers/net/i40e/rte_pmd_i40e.c
> > +++ b/drivers/net/i40e/rte_pmd_i40e.c
> > @@ -3094,10 +3094,6 @@ rte_pmd_i40e_inset_set(uint16_t port, uint8_t
> > pctype,
> >  		return -ENOTSUP;
> >  	}
> >
> > -	/* Clear mask first */
> > -	for (i = 0; i < 2; i++)
> > -		i40e_check_write_reg(hw, I40E_GLQF_FD_MSK(i, pctype),
> > 0);
> > -
> >  	inset_reg = inset->inset;
> >  	for (i = 0; i < 2; i++)
> >  		mask_reg[i] = (inset->mask[i].field_idx << 16) |
> > --
> > 2.5.5
> 
> 
> Reviewed-by: Kirill Rybalchenko <kirill.rybalchenko@intel.com>
> 
> 
Acked-by: Qi Zhang <qi.z.zhang@intel.com>