From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id E4CCFA48D for ; Mon, 26 Mar 2018 05:15:31 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Mar 2018 20:15:29 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,363,1517904000"; d="scan'208";a="41183364" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by fmsmga001.fm.intel.com with ESMTP; 25 Mar 2018 20:15:29 -0700 Received: from fmsmsx126.amr.corp.intel.com (10.18.125.43) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.319.2; Sun, 25 Mar 2018 20:15:29 -0700 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by FMSMSX126.amr.corp.intel.com (10.18.125.43) with Microsoft SMTP Server (TLS) id 14.3.319.2; Sun, 25 Mar 2018 20:15:28 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.235]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.166]) with mapi id 14.03.0319.002; Mon, 26 Mar 2018 11:15:27 +0800 From: "Zhang, Qi Z" To: "Rybalchenko, Kirill" , "Xing, Beilei" CC: "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] net/i40e: remove unnecessary FDIR mask configuration Thread-Index: AQHTu6dw6Uk38JKmvkGcJZ+knNkk4aPh6eiw Date: Mon, 26 Mar 2018 03:15:26 +0000 Message-ID: <039ED4275CED7440929022BC67E7061153174027@SHSMSX103.ccr.corp.intel.com> References: <1518332974-86392-1-git-send-email-beilei.xing@intel.com> <696B43C21188DF4F9C9091AAE4789B824E2D65CC@IRSMSX108.ger.corp.intel.com> In-Reply-To: <696B43C21188DF4F9C9091AAE4789B824E2D65CC@IRSMSX108.ger.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] net/i40e: remove unnecessary FDIR mask configuration X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Mar 2018 03:15:32 -0000 > -----Original Message----- > From: Rybalchenko, Kirill > Sent: Wednesday, March 14, 2018 11:17 PM > To: Xing, Beilei ; Zhang, Qi Z > Cc: dev@dpdk.org > Subject: RE: [dpdk-dev] [PATCH] net/i40e: remove unnecessary FDIR mask > configuration >=20 >=20 >=20 > > -----Original Message----- > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Beilei Xing > > Sent: Sunday 11 February 2018 07:10 > > To: Zhang, Qi Z > > Cc: dev@dpdk.org > > Subject: [dpdk-dev] [PATCH] net/i40e: remove unnecessary FDIR mask > > configuration > > > > Remove unnecessary FDIR mask configuration, otherwise flow directory > > mask will be changed when configuring hash input set. > > > > Signed-off-by: Beilei Xing > > --- > > drivers/net/i40e/rte_pmd_i40e.c | 4 ---- > > 1 file changed, 4 deletions(-) > > > > diff --git a/drivers/net/i40e/rte_pmd_i40e.c > > b/drivers/net/i40e/rte_pmd_i40e.c index 1288c51..b684249 100644 > > --- a/drivers/net/i40e/rte_pmd_i40e.c > > +++ b/drivers/net/i40e/rte_pmd_i40e.c > > @@ -3094,10 +3094,6 @@ rte_pmd_i40e_inset_set(uint16_t port, uint8_t > > pctype, > > return -ENOTSUP; > > } > > > > - /* Clear mask first */ > > - for (i =3D 0; i < 2; i++) > > - i40e_check_write_reg(hw, I40E_GLQF_FD_MSK(i, pctype), > > 0); > > - > > inset_reg =3D inset->inset; > > for (i =3D 0; i < 2; i++) > > mask_reg[i] =3D (inset->mask[i].field_idx << 16) | > > -- > > 2.5.5 >=20 >=20 > Reviewed-by: Kirill Rybalchenko >=20 >=20 Acked-by: Qi Zhang