From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 5FBF923C; Wed, 28 Mar 2018 08:43:39 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Mar 2018 23:43:38 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,370,1517904000"; d="scan'208";a="28683833" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga007.jf.intel.com with ESMTP; 27 Mar 2018 23:43:37 -0700 Received: from fmsmsx154.amr.corp.intel.com (10.18.116.70) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 27 Mar 2018 23:42:33 -0700 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by FMSMSX154.amr.corp.intel.com (10.18.116.70) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 27 Mar 2018 23:42:32 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.235]) by shsmsx102.ccr.corp.intel.com ([169.254.2.80]) with mapi id 14.03.0319.002; Wed, 28 Mar 2018 14:42:31 +0800 From: "Zhang, Qi Z" To: "Yigit, Ferruh" , "Wu, Jingjing" , "Lu, Wenzhuo" CC: "dev@dpdk.org" , "Yigit, Ferruh" , "stable@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] net/avf: fix link autoneg value Thread-Index: AQHTt9ALfXGqlEGapUKuJk07Xiq0hqPlT3Yg Date: Wed, 28 Mar 2018 06:42:31 +0000 Message-ID: <039ED4275CED7440929022BC67E70611531754F1@SHSMSX103.ccr.corp.intel.com> References: <20180309175631.242976-1-ferruh.yigit@intel.com> In-Reply-To: <20180309175631.242976-1-ferruh.yigit@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] net/avf: fix link autoneg value X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Mar 2018 06:43:39 -0000 Hi Ferruh: > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Ferruh Yigit > Sent: Saturday, March 10, 2018 1:57 AM > To: Wu, Jingjing ; Lu, Wenzhuo > > Cc: dev@dpdk.org; Yigit, Ferruh ; stable@dpdk.org > Subject: [dpdk-dev] [PATCH] net/avf: fix link autoneg value >=20 > Intention of the logic is: > If ETH_LINK_SPEED_FIXED is set in dev_conf, set link_autoneg to > ETH_LINK_FIXED, else set it to ETH_LINK_AUTONEG >=20 > ETH_LINK_SPEED_FIXED value is 1, and ETH_LINK_FIXED is 0; >=20 > Current logic is broken, fix it according above values. >=20 > Fixes: 48de41ca11f0 ("net/avf: enable link status update") > Cc: jingjing.wu@intel.com > Cc: stable@dpdk.org >=20 > Signed-off-by: Ferruh Yigit Acked-by: Qi Zhang BTW, I saw the same issue on i40evf, will you also fix that? Thanks Qi