From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id A9550255 for ; Thu, 29 Mar 2018 08:08:56 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 28 Mar 2018 23:08:54 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,375,1517904000"; d="scan'208";a="28498839" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by fmsmga008.fm.intel.com with ESMTP; 28 Mar 2018 23:08:54 -0700 Received: from fmsmsx114.amr.corp.intel.com (10.18.116.8) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 28 Mar 2018 23:08:54 -0700 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by FMSMSX114.amr.corp.intel.com (10.18.116.8) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 28 Mar 2018 23:08:54 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.235]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.166]) with mapi id 14.03.0319.002; Thu, 29 Mar 2018 14:08:51 +0800 From: "Zhang, Qi Z" To: "Dai, Wei" , "Wang, Xiao W" CC: "'dev@dpdk.org'" Thread-Topic: [PATCH v2 1/2] net/fm10k: convert to new Rx offloads API Thread-Index: AQHTxmsFdVov/alHW0S+SK3Uq+MqlaPlagfQgAFQigA= Date: Thu, 29 Mar 2018 06:08:50 +0000 Message-ID: <039ED4275CED7440929022BC67E7061153175E35@SHSMSX103.ccr.corp.intel.com> References: <20180302141105.4954-1-wei.dai@intel.com> <20180328080037.16207-1-wei.dai@intel.com> <20180328080037.16207-2-wei.dai@intel.com> <039ED4275CED7440929022BC67E706115317576C@SHSMSX103.ccr.corp.intel.com> In-Reply-To: <039ED4275CED7440929022BC67E706115317576C@SHSMSX103.ccr.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 1/2] net/fm10k: convert to new Rx offloads API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Mar 2018 06:08:57 -0000 > -----Original Message----- > From: Zhang, Qi Z > Sent: Wednesday, March 28, 2018 6:08 PM > To: Dai, Wei ; Wang, Xiao W > Cc: dev@dpdk.org > Subject: RE: [PATCH v2 1/2] net/fm10k: convert to new Rx offloads API >=20 > Hi Daiwei: >=20 > > +static uint64_t fm10k_get_rx_queue_offloads_capa(struct rte_eth_dev > > +*dev) { > > + RTE_SET_USED(dev); > > + > > + return (uint64_t)(DEV_RX_OFFLOAD_SCATTER); > > +} >=20 > why per queue rx scattered feature here? > My understanding is either we use scattered rx function that enable this > feature for all queues or we use non-scattered rx function that disable t= his > feature for all queues, right? Checked with Dai Wei offline, fm10k have per queue register that can be con= figured to support rx scattered, So it is per queue offload. >=20 > Regards > Qi