From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id C2F0B16E for ; Thu, 29 Mar 2018 11:51:03 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 29 Mar 2018 02:51:02 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,376,1517904000"; d="scan'208";a="42277850" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by fmsmga001.fm.intel.com with ESMTP; 29 Mar 2018 02:51:02 -0700 Received: from fmsmsx151.amr.corp.intel.com (10.18.125.4) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 29 Mar 2018 02:51:02 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by FMSMSX151.amr.corp.intel.com (10.18.125.4) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 29 Mar 2018 02:51:02 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.235]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.129]) with mapi id 14.03.0319.002; Thu, 29 Mar 2018 17:51:00 +0800 From: "Zhang, Qi Z" To: "Ananyev, Konstantin" , "Dai, Wei" , "Wang, Xiao W" CC: "'dev@dpdk.org'" Thread-Topic: [dpdk-dev] [PATCH v2 1/2] net/fm10k: convert to new Rx offloads API Thread-Index: AQHTx0BimSrqaZQOBk2fxPum/zQTZKPm8qug Date: Thu, 29 Mar 2018 09:51:00 +0000 Message-ID: <039ED4275CED7440929022BC67E7061153175FD0@SHSMSX103.ccr.corp.intel.com> References: <20180302141105.4954-1-wei.dai@intel.com> <20180328080037.16207-1-wei.dai@intel.com> <20180328080037.16207-2-wei.dai@intel.com> <039ED4275CED7440929022BC67E706115317576C@SHSMSX103.ccr.corp.intel.com> <039ED4275CED7440929022BC67E7061153175E35@SHSMSX103.ccr.corp.intel.com> <2601191342CEEE43887BDE71AB977258A0AB5BB9@irsmsx105.ger.corp.intel.com> In-Reply-To: <2601191342CEEE43887BDE71AB977258A0AB5BB9@irsmsx105.ger.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 1/2] net/fm10k: convert to new Rx offloads API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Mar 2018 09:51:04 -0000 Hi Konstantin: > -----Original Message----- > From: Ananyev, Konstantin > Sent: Thursday, March 29, 2018 5:29 PM > To: Zhang, Qi Z ; Dai, Wei ; Wan= g, > Xiao W > Cc: 'dev@dpdk.org' > Subject: RE: [dpdk-dev] [PATCH v2 1/2] net/fm10k: convert to new Rx > offloads API >=20 >=20 >=20 > > -----Original Message----- > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Zhang, Qi Z > > Sent: Thursday, March 29, 2018 7:09 AM > > To: Dai, Wei ; Wang, Xiao W > > Cc: 'dev@dpdk.org' > > Subject: Re: [dpdk-dev] [PATCH v2 1/2] net/fm10k: convert to new Rx > > offloads API > > > > > > > > > -----Original Message----- > > > From: Zhang, Qi Z > > > Sent: Wednesday, March 28, 2018 6:08 PM > > > To: Dai, Wei ; Wang, Xiao W > > > > > > Cc: dev@dpdk.org > > > Subject: RE: [PATCH v2 1/2] net/fm10k: convert to new Rx offloads > > > API > > > > > > Hi Daiwei: > > > > > > > +static uint64_t fm10k_get_rx_queue_offloads_capa(struct > > > > +rte_eth_dev > > > > +*dev) { > > > > + RTE_SET_USED(dev); > > > > + > > > > + return (uint64_t)(DEV_RX_OFFLOAD_SCATTER); > > > > +} > > > > > > why per queue rx scattered feature here? > > > My understanding is either we use scattered rx function that enable > > > this feature for all queues or we use non-scattered rx function that > > > disable this feature for all queues, right? > > > > Checked with Dai Wei offline, fm10k have per queue register that can > > be configured to support rx scattered, So it is per queue offload. >=20 > Ok, but these days we have one RX function per device. > Looking at fm10k - it clearly has different RX function for scattered and > non-scattered case. > Yes, HW does support scatter/non-scatter selection per queue, but our SW = - > doesn't (same for ixgbe and i40e) So how it could be per queue offload? We saw the implementation of fm10k is a little bit different with i40e. It set per queue register "FM10K_SRRCTL_BUFFER_CHAINING_EN" to turn on mult= i-seg feature when offload is required. That means two queues can have different behavior when process a packet tha= t exceed the buffer size base on the register setting, though we use the same rx scattered function, so we think this is per queue= feature, is that make sense? Regards Qi > Konstantin >=20 > > > > > > Regards > > > Qi