From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id 8AE8258C6 for ; Mon, 2 Apr 2018 05:35:16 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 01 Apr 2018 20:35:12 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,393,1517904000"; d="scan'208";a="213178959" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by orsmga005.jf.intel.com with ESMTP; 01 Apr 2018 20:35:12 -0700 Received: from FMSMSX109.amr.corp.intel.com (10.18.116.9) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.319.2; Sun, 1 Apr 2018 20:35:11 -0700 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by fmsmsx109.amr.corp.intel.com (10.18.116.9) with Microsoft SMTP Server (TLS) id 14.3.319.2; Sun, 1 Apr 2018 20:35:11 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.235]) by shsmsx102.ccr.corp.intel.com ([169.254.2.80]) with mapi id 14.03.0319.002; Mon, 2 Apr 2018 11:35:09 +0800 From: "Zhang, Qi Z" To: "Pattan, Reshma" , "adrien.mazarguil@6wind.com" CC: "dev@dpdk.org" , "Doherty, Declan" , "Chandran, Sugesh" , "Glynn, Michael J" , "Liu, Yu Y" , "Ananyev, Konstantin" , "Richardson, Bruce" Thread-Topic: [dpdk-dev] [PATCH 4/4] ether: add packet modification aciton in flow API Thread-Index: AQHTx3HcfXVpDcsaa0Sgj4pQLWKP96Ps03pg Date: Mon, 2 Apr 2018 03:35:09 +0000 Message-ID: <039ED4275CED7440929022BC67E7061153177634@SHSMSX103.ccr.corp.intel.com> References: <1522279780-34842-1-git-send-email-qi.z.zhang@intel.com> <1522279780-34842-5-git-send-email-qi.z.zhang@intel.com> <3AEA2BF9852C6F48A459DA490692831F2A2BBD18@irsmsx110.ger.corp.intel.com> In-Reply-To: <3AEA2BF9852C6F48A459DA490692831F2A2BBD18@irsmsx110.ger.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 4/4] ether: add packet modification aciton in flow API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 Apr 2018 03:35:17 -0000 Hi Reshma: Thanks for your review and I accepted most of your comments except: 1. doc and code will still be merged in one patch to follow the usual way = when we add a new API. 2. code re-org for "ifndef _cpluscplus", is not the scope of the patch, it= could be done separately. For others I will fix in v2. Thanks. Qi > -----Original Message----- > From: Pattan, Reshma > Sent: Thursday, March 29, 2018 11:23 PM > To: Zhang, Qi Z ; adrien.mazarguil@6wind.com > Cc: dev@dpdk.org; Doherty, Declan ; Chandran, > Sugesh ; Glynn, Michael J > ; Liu, Yu Y ; Ananyev, > Konstantin ; Richardson, Bruce > ; Zhang, Qi Z > Subject: RE: [dpdk-dev] [PATCH 4/4] ether: add packet modification aciton= in > flow API >=20 > Hi, >=20 > > Subject: [dpdk-dev] [PATCH 4/4] ether: add packet modification aciton i= n > flow >=20 > Typo in the commit message header "action" >=20 > > +/** RTE_FLOW_ACTION_TYPE_FIELD_INCREMENT > > + * > > + * Increment 1 on specific field of the packet. > > + * > > + * Typical usage: increase TTL > > + */ > > +struct rte_flow_action_field_increment { > > + const struct rte_flow_item *item; /**< specify the data to modify. */ > > + uint8_t layer; > > + /**< 0 means outermost matched pattern, 1 means next-to- > > outermost... > > +*/ }; > > + > > +/** RTE_FLOW_ACTION_TYPE_FIELD_DECREMENT > > + * > > + * Decrement 1 on specific field of the packet. > > + * > > + * Typical usage: Decrease TTL > > + */ > > +struct rte_flow_action_field_decrement { > > + const struct rte_flow_item *item; /**< Specify the data to modify. */ > > + uint8_t layer; > > + /**< 0 means outermost matched pattern, 1 means next-to- > > outermost... > > +*/ }; > > + >=20 > Can you have only one struct to represent both increment/decrements > operations instead of two structs? As I see both use same data types . >=20 > Thanks, > Reshma