From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 682FFAAD2 for ; Mon, 2 Apr 2018 14:14:05 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 Apr 2018 05:14:04 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,395,1517904000"; d="scan'208";a="29461441" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga008.fm.intel.com with ESMTP; 02 Apr 2018 05:14:03 -0700 Received: from fmsmsx126.amr.corp.intel.com (10.18.125.43) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 2 Apr 2018 05:14:03 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by FMSMSX126.amr.corp.intel.com (10.18.125.43) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 2 Apr 2018 05:14:03 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.235]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.108]) with mapi id 14.03.0319.002; Mon, 2 Apr 2018 20:14:01 +0800 From: "Zhang, Qi Z" To: "eduser25@gmail.com" CC: "dev@dpdk.org" Thread-Topic: [PATCH] net/i40e/vf: reset scatter_rx flag when configuration complies Thread-Index: AQHTx5psXDB8xyapk0S2ZYXJZOOtzqPtZ5uA Date: Mon, 2 Apr 2018 12:14:00 +0000 Message-ID: <039ED4275CED7440929022BC67E706115317784D@SHSMSX103.ccr.corp.intel.com> References: <1522354407-90598-1-git-send-email-eduser25@gmail.com> In-Reply-To: <1522354407-90598-1-git-send-email-eduser25@gmail.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] net/i40e/vf: reset scatter_rx flag when configuration complies X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 Apr 2018 12:14:06 -0000 Hi Serra: > -----Original Message----- > From: eduser25@gmail.com [mailto:eduser25@gmail.com] > Sent: Friday, March 30, 2018 4:13 AM > To: Zhang, Qi Z > Cc: dev@dpdk.org; Eduard Serra > Subject: [PATCH] net/i40e/vf: reset scatter_rx flag when configuration > complies >=20 > From: Eduard Serra >=20 > Scatter RX (scattered_rx) flag is currently not being resetted when new > configuration is suplied to reconfigure a port, rendering the rx callback= logic to s/suplied/supplied > always fall through the scatter branch. >=20 > Signed-off-by: Eduard Serra > --- > drivers/net/i40e/i40e_ethdev_vf.c | 2 ++ > drivers/net/i40e/i40e_rxtx.c | 2 ++ > 2 files changed, 4 insertions(+) >=20 > diff --git a/drivers/net/i40e/i40e_ethdev_vf.c > b/drivers/net/i40e/i40e_ethdev_vf.c > index 750d849..a072154 100644 > --- a/drivers/net/i40e/i40e_ethdev_vf.c > +++ b/drivers/net/i40e/i40e_ethdev_vf.c > @@ -1750,6 +1750,8 @@ i40evf_rxq_init(struct rte_eth_dev *dev, struct > i40e_rx_queue *rxq) > if (dev_data->dev_conf.rxmode.enable_scatter || > (rxq->max_pkt_len + 2 * I40E_VLAN_TAG_SIZE) > buf_size) { > dev_data->scattered_rx =3D 1; > + } else { > + dev_data->scattered_rx =3D 0; Scattered_rx should not be reset if any queue already required You should reset it before the queue loop=20 > } >=20 > return 0; > diff --git a/drivers/net/i40e/i40e_rxtx.c b/drivers/net/i40e/i40e_rxtx.c = index > 1217e5a..8698747 100644 > --- a/drivers/net/i40e/i40e_rxtx.c > +++ b/drivers/net/i40e/i40e_rxtx.c > @@ -2561,6 +2561,8 @@ i40e_rx_queue_init(struct i40e_rx_queue *rxq) > /* Check if scattered RX needs to be used. */ > if ((rxq->max_pkt_len + 2 * I40E_VLAN_TAG_SIZE) > buf_size) { > dev_data->scattered_rx =3D 1; > + } else { > + dev_data->scattered_rx =3D 0; Same as above. Regards Qi > } >=20 > /* Init the RX tail regieter. */ > -- > 2.7.4