DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Zhang, Qi Z" <qi.z.zhang@intel.com>
To: "Zhao1, Wei" <wei.zhao1@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] net/i40e: fix flow RSS tci using error
Date: Tue, 3 Apr 2018 14:03:22 +0000	[thread overview]
Message-ID: <039ED4275CED7440929022BC67E7061153178676@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <1522735776-27118-1-git-send-email-wei.zhao1@intel.com>



> -----Original Message-----
> From: Zhao1, Wei
> Sent: Tuesday, April 3, 2018 2:10 PM
> To: dev@dpdk.org
> Cc: Zhang, Qi Z <qi.z.zhang@intel.com>; Zhao1, Wei <wei.zhao1@intel.com>
> Subject: [PATCH] net/i40e: fix flow RSS tci using error
> 
> Vlan tci configuration from testpmd is store in big endian, so it need to be
> change to little endian before using.
> 
> Fixes: ecad87d22383 ("net/i40e: move RSS to flow API")
> Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
> Tested-by: Peng Yuan <yuan.peng@intel.com>

Acked-by: Qi Zhang <qi.z.zhang@intel.com>

Please don't forget to Cc: stable@dpdk.org, if you fix an issue for previous release.

Regards
Qi

> ---
>  drivers/net/i40e/i40e_flow.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/i40e/i40e_flow.c b/drivers/net/i40e/i40e_flow.c index
> fa562d3..8d0a36b 100644
> --- a/drivers/net/i40e/i40e_flow.c
> +++ b/drivers/net/i40e/i40e_flow.c
> @@ -4151,7 +4151,8 @@ i40e_flow_parse_rss_pattern(__rte_unused struct
> rte_eth_dev *dev,
>  				if (vlan_mask->tci ==
>  					rte_cpu_to_be_16(I40E_TCI_MASK)) {
>  					info->region[0].user_priority[0] =
> -						(vlan_spec->tci >> 13) & 0x7;
> +						(rte_be_to_cpu_16(
> +						vlan_spec->tci) >> 13) & 0x7;
>  					info->region[0].user_priority_num = 1;
>  					info->queue_region_number = 1;
>  					*action_flag = 0;
> --
> 2.7.5

  reply	other threads:[~2018-04-03 14:03 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-03  6:09 Wei Zhao
2018-04-03 14:03 ` Zhang, Qi Z [this message]
2018-04-03 15:17   ` Zhang, Helin
2018-04-04  1:29   ` Zhao1, Wei

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=039ED4275CED7440929022BC67E7061153178676@SHSMSX103.ccr.corp.intel.com \
    --to=qi.z.zhang@intel.com \
    --cc=dev@dpdk.org \
    --cc=wei.zhao1@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).