From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id B2E5C1CC95 for ; Fri, 6 Apr 2018 18:01:06 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 06 Apr 2018 09:00:58 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,415,1517904000"; d="scan'208";a="44026744" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by fmsmga004.fm.intel.com with ESMTP; 06 Apr 2018 09:00:58 -0700 Received: from fmsmsx117.amr.corp.intel.com (10.18.116.17) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.319.2; Fri, 6 Apr 2018 09:00:58 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by fmsmsx117.amr.corp.intel.com (10.18.116.17) with Microsoft SMTP Server (TLS) id 14.3.319.2; Fri, 6 Apr 2018 09:00:57 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.241]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.163]) with mapi id 14.03.0319.002; Sat, 7 Apr 2018 00:00:55 +0800 From: "Zhang, Qi Z" To: "Zhang, Helin" , "eduser25@gmail.com" CC: "dev@dpdk.org" Thread-Topic: [PATCH] net/i40e/vf: reset scatter_rx flag when configuration complies Thread-Index: AQHTx5psXDB8xyapk0S2ZYXJZOOtzqPtZ5uAgAYQccCAAHd6kIAAAgeg Date: Fri, 6 Apr 2018 16:00:55 +0000 Message-ID: <039ED4275CED7440929022BC67E70611531838C3@SHSMSX103.ccr.corp.intel.com> References: <1522354407-90598-1-git-send-email-eduser25@gmail.com> <039ED4275CED7440929022BC67E706115317784D@SHSMSX103.ccr.corp.intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] net/i40e/vf: reset scatter_rx flag when configuration complies X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 Apr 2018 16:01:07 -0000 > -----Original Message----- > From: Zhang, Helin > Sent: Friday, April 6, 2018 11:54 PM > To: Zhang, Qi Z ; eduser25@gmail.com > Cc: dev@dpdk.org > Subject: RE: [PATCH] net/i40e/vf: reset scatter_rx flag when configuratio= n > complies >=20 >=20 >=20 > > -----Original Message----- > > From: Zhang, Helin > > Sent: Friday, April 6, 2018 4:46 PM > > To: Zhang, Qi Z; eduser25@gmail.com > > Cc: dev@dpdk.org > > Subject: RE: [PATCH] net/i40e/vf: reset scatter_rx flag when > > configuration complies > > > > > > > > > -----Original Message----- > > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Zhang, Qi Z > > > Sent: Monday, April 2, 2018 8:14 PM > > > To: eduser25@gmail.com > > > Cc: dev@dpdk.org > > > Subject: Re: [dpdk-dev] [PATCH] net/i40e/vf: reset scatter_rx flag > > > when configuration complies > > > > > > Hi Serra: > > > > > > > -----Original Message----- > > > > From: eduser25@gmail.com [mailto:eduser25@gmail.com] > > > > Sent: Friday, March 30, 2018 4:13 AM > > > > To: Zhang, Qi Z > > > > Cc: dev@dpdk.org; Eduard Serra > > > > Subject: [PATCH] net/i40e/vf: reset scatter_rx flag when > > > > configuration complies > > > > > > > > From: Eduard Serra > > > > > > > > Scatter RX (scattered_rx) flag is currently not being resetted > > > > when new configuration is suplied to reconfigure a port, rendering > > > > the rx callback logic to > > > > > > s/suplied/supplied > > > > > > > always fall through the scatter branch. > > > > > > > > Signed-off-by: Eduard Serra > > > > --- > > > > drivers/net/i40e/i40e_ethdev_vf.c | 2 ++ > > > > drivers/net/i40e/i40e_rxtx.c | 2 ++ > > > > 2 files changed, 4 insertions(+) > > > > > > > > diff --git a/drivers/net/i40e/i40e_ethdev_vf.c > > > > b/drivers/net/i40e/i40e_ethdev_vf.c > > > > index 750d849..a072154 100644 > > > > --- a/drivers/net/i40e/i40e_ethdev_vf.c > > > > +++ b/drivers/net/i40e/i40e_ethdev_vf.c > > > > @@ -1750,6 +1750,8 @@ i40evf_rxq_init(struct rte_eth_dev *dev, > > > > struct i40e_rx_queue *rxq) > > > > if (dev_data->dev_conf.rxmode.enable_scatter || > > > > (rxq->max_pkt_len + 2 * I40E_VLAN_TAG_SIZE) > buf_size) { > > > > dev_data->scattered_rx =3D 1; > > > > + } else { > > > > + dev_data->scattered_rx =3D 0; > > > > > > Scattered_rx should not be reset if any queue already required You > > > should reset it before the queue loop > > Does it mean a NACK? Yes the fix is not correct. > > > > /Helin > Anyway, please fix the checkpatch warnings reported on patchwork. Thanks! >=20 > /Helin > > > > > > > > > } > > > > > > > > return 0; > > > > diff --git a/drivers/net/i40e/i40e_rxtx.c > > > > b/drivers/net/i40e/i40e_rxtx.c index > > > > 1217e5a..8698747 100644 > > > > --- a/drivers/net/i40e/i40e_rxtx.c > > > > +++ b/drivers/net/i40e/i40e_rxtx.c > > > > @@ -2561,6 +2561,8 @@ i40e_rx_queue_init(struct i40e_rx_queue *rxq) > > > > /* Check if scattered RX needs to be used. */ > > > > if ((rxq->max_pkt_len + 2 * I40E_VLAN_TAG_SIZE) > buf_size) { > > > > dev_data->scattered_rx =3D 1; > > > > + } else { > > > > + dev_data->scattered_rx =3D 0; > > > > > > Same as above. > > > > > > Regards > > > Qi > > > > > > > } > > > > > > > > /* Init the RX tail regieter. */ > > > > -- > > > > 2.7.4