From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 7B8091C7F7 for ; Sun, 8 Apr 2018 04:20:42 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 07 Apr 2018 19:20:41 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,421,1517904000"; d="scan'208";a="45914302" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by orsmga001.jf.intel.com with ESMTP; 07 Apr 2018 19:20:40 -0700 Received: from FMSMSX109.amr.corp.intel.com (10.18.116.9) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.319.2; Sat, 7 Apr 2018 19:20:40 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by fmsmsx109.amr.corp.intel.com (10.18.116.9) with Microsoft SMTP Server (TLS) id 14.3.319.2; Sat, 7 Apr 2018 19:20:40 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.151]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.197]) with mapi id 14.03.0319.002; Sun, 8 Apr 2018 10:20:37 +0800 From: "Zhang, Qi Z" To: "Rosen, Rami" , "thomas@monjalon.net" , "Ananyev, Konstantin" CC: "dev@dpdk.org" , "Xing, Beilei" , "Wu, Jingjing" , "Lu, Wenzhuo" Thread-Topic: [dpdk-dev] [PATCH v5 1/3] ether: support runtime queue setup Thread-Index: AQHTyi6jTPp/RqEe60GtUK6xOur/W6PzpDKAgAKHtvA= Date: Sun, 8 Apr 2018 02:20:37 +0000 Message-ID: <039ED4275CED7440929022BC67E706115318A372@SHSMSX103.ccr.corp.intel.com> References: <20180212045314.171616-1-qi.z.zhang@intel.com> <20180402025935.33312-1-qi.z.zhang@intel.com> <20180402025935.33312-2-qi.z.zhang@intel.com> <9B0331B6EBBD0E4684FBFAEDA55776F95319D7A0@HASMSX110.ger.corp.intel.com> In-Reply-To: <9B0331B6EBBD0E4684FBFAEDA55776F95319D7A0@HASMSX110.ger.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v5 1/3] ether: support runtime queue setup X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 08 Apr 2018 02:20:43 -0000 > -----Original Message----- > From: Rosen, Rami > Sent: Saturday, April 7, 2018 3:42 AM > To: Zhang, Qi Z ; thomas@monjalon.net; Ananyev, > Konstantin > Cc: dev@dpdk.org; Xing, Beilei ; Wu, Jingjing > ; Lu, Wenzhuo ; Zhang, Qi Z > > Subject: RE: [dpdk-dev] [PATCH v5 1/3] ether: support runtime queue setup >=20 > Hi Qi, > Thanks for these patches. > See my comment below. >=20 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Qi Zhang > Sent: Monday, April 02, 2018 06:00 > To: thomas@monjalon.net; Ananyev, Konstantin > > Cc: dev@dpdk.org; Xing, Beilei ; Wu, Jingjing > ; Lu, Wenzhuo ; Zhang, Qi Z > > Subject: [dpdk-dev] [PATCH v5 1/3] ether: support runtime queue setup >=20 > The patch let etherdev driver expose the capability flag through > rte_eth_dev_info_get when it support runtime queue configuraiton, then ba= se > on the flag rte_eth_[rx|tx]_queue_setup could decide continue to setup th= e > queue or just return fail when device already started. >=20 > Signed-off-by: Qi Zhang > --- > doc/guides/nics/features.rst | 8 ++++++++ lib/librte_ether/rte_ethdev= .c > | 30 ++++++++++++++++++------------ lib/librte_ether/rte_ethdev.h | 7 > +++++++ > 3 files changed, 33 insertions(+), 12 deletions(-) >=20 > diff --git a/doc/guides/nics/features.rst b/doc/guides/nics/features.rst = index > 1b4fb979f..6983faa4e 100644 > --- a/doc/guides/nics/features.rst > +++ b/doc/guides/nics/features.rst > @@ -892,7 +892,15 @@ Documentation describes performance values. >=20 > See ``dpdk.org/doc/perf/*``. >=20 > +.. _nic_features_queue_runtime_setup_capabilities: >=20 > +Queue runtime setup capabilities > +--------------------------------- > + > +Supports queue setup / release after device started. > + > +* **[provides] rte_eth_dev_info**: > ``runtime_queue_config_capa:DEV_RUNTIME_RX_QUEUE_SETUP,DEV_RUNTI > ME_TX_QUEUE_SETUP``. > +* **[related] API**: ``rte_eth_dev_info_get()``. >=20 > .. _nic_features_other: >=20 > diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.= c index > 0590f0c10..343b1a6c0 100644 > --- a/lib/librte_ether/rte_ethdev.c > +++ b/lib/librte_ether/rte_ethdev.c > @@ -1425,12 +1425,6 @@ rte_eth_rx_queue_setup(uint16_t port_id, uint16_t > rx_queue_id, > return -EINVAL; > } >=20 > - if (dev->data->dev_started) { > - RTE_PMD_DEBUG_TRACE( > - "port %d must be stopped to allow configuration\n", port_id); > - return -EBUSY; > - } > - > RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->dev_infos_get, > -ENOTSUP); > RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->rx_queue_setup, > -ENOTSUP); >=20 > @@ -1474,6 +1468,15 @@ rte_eth_rx_queue_setup(uint16_t port_id, uint16_t > rx_queue_id, > return -EINVAL; > } >=20 > + if (dev->data->dev_started && > + !(dev_info.runtime_queue_setup_capa & > + DEV_RUNTIME_RX_QUEUE_SETUP)) > + return -EBUSY; > + > + if (dev->data->rx_queue_state[rx_queue_id] !=3D > + RTE_ETH_QUEUE_STATE_STOPPED) > + return -EBUSY; > + > rxq =3D dev->data->rx_queues; > if (rxq[rx_queue_id]) { > RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->rx_queue_release, > @@ -1573,12 +1576,6 @@ rte_eth_tx_queue_setup(uint16_t port_id, uint16_t > tx_queue_id, > return -EINVAL; > } >=20 > - if (dev->data->dev_started) { > - RTE_PMD_DEBUG_TRACE( > - "port %d must be stopped to allow configuration\n", port_id); > - return -EBUSY; > - } > - > RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->dev_infos_get, > -ENOTSUP); > RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->tx_queue_setup, > -ENOTSUP); >=20 > @@ -1596,6 +1593,15 @@ rte_eth_tx_queue_setup(uint16_t port_id, uint16_t > tx_queue_id, > return -EINVAL; > } >=20 > + if (dev->data->dev_started && > + !(dev_info.runtime_queue_setup_capa & > + DEV_RUNTIME_TX_QUEUE_SETUP)) > + return -EBUSY; > + > [Rami Rosen] Shouldn't it be here: dev->data->tx_queue_state[...] instead= of: > dev->data->rx_queue_state[...] ? we are dealing > with the TX queue. Thanks, will fix. >=20 > + if (dev->data->rx_queue_state[tx_queue_id] !=3D > + RTE_ETH_QUEUE_STATE_STOPPED) > + return -EBUSY; > + > txq =3D dev->data->tx_queues; > if (txq[tx_queue_id]) { > RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->tx_queue_release, > diff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev.= h index > 036153306..4e2088458 100644 > --- a/lib/librte_ether/rte_ethdev.h > +++ b/lib/librte_ether/rte_ethdev.h > @@ -981,6 +981,11 @@ struct rte_eth_conf { > */ > #define DEV_TX_OFFLOAD_SECURITY 0x00020000 >=20 > +#define DEV_RUNTIME_RX_QUEUE_SETUP 0x00000001 /**< Deferred setup > rx > +queue */ #define DEV_RUNTIME_TX_QUEUE_SETUP 0x00000002 /**< > Deferred > +setup tx queue */ > + > /* > * If new Tx offload capabilities are defined, they also must be > * mentioned in rte_tx_offload_names in rte_ethdev.c file. > @@ -1029,6 +1034,8 @@ struct rte_eth_dev_info { > /** Configured number of rx/tx queues */ > uint16_t nb_rx_queues; /**< Number of RX queues. */ > uint16_t nb_tx_queues; /**< Number of TX queues. */ > + uint64_t runtime_queue_setup_capa; > + /**< queues can be setup after dev_start (DEV_DEFERRED_). */ > }; >=20 > /** > -- > 2.13.6