From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 7B2BB1B72B; Mon, 9 Apr 2018 09:18:13 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Apr 2018 00:18:12 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,426,1517904000"; d="scan'208";a="35594389" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga002.fm.intel.com with ESMTP; 09 Apr 2018 00:18:11 -0700 Received: from fmsmsx151.amr.corp.intel.com (10.18.125.4) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 9 Apr 2018 00:18:11 -0700 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by FMSMSX151.amr.corp.intel.com (10.18.125.4) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 9 Apr 2018 00:18:11 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.151]) by shsmsx102.ccr.corp.intel.com ([169.254.2.184]) with mapi id 14.03.0319.002; Mon, 9 Apr 2018 15:18:09 +0800 From: "Zhang, Qi Z" To: "Zhao1, Wei" , "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [PATCH] net/i40e: fix flow RSS queue index check error Thread-Index: AQHTzv5G0iWwF9yp6EaadJh3UJxUuaP4BQWw Date: Mon, 9 Apr 2018 07:18:09 +0000 Message-ID: <039ED4275CED7440929022BC67E706115318CDA6@SHSMSX103.ccr.corp.intel.com> References: <1523165844-5362-1-git-send-email-wei.zhao1@intel.com> In-Reply-To: <1523165844-5362-1-git-send-email-wei.zhao1@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] net/i40e: fix flow RSS queue index check error X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Apr 2018 07:18:15 -0000 > -----Original Message----- > From: Zhao1, Wei > Sent: Sunday, April 8, 2018 1:37 PM > To: dev@dpdk.org; stable@dpdk.org > Cc: Zhang, Qi Z ; Zhao1, Wei > Subject: [PATCH] net/i40e: fix flow RSS queue index check error >=20 > Ther is a error in queue index check for RSS queue region configuration. What is the error? Would you explain more and please add this in commit log? Regards Qi >=20 > Fixes: ecad87d22383 ("net/i40e: move RSS to flow API") > Signed-off-by: Wei Zhao > Tested-by: Peng Yuan > --- > drivers/net/i40e/i40e_flow.c | 19 ++++++++----------- > 1 file changed, 8 insertions(+), 11 deletions(-) >=20 > diff --git a/drivers/net/i40e/i40e_flow.c b/drivers/net/i40e/i40e_flow.c = index > f4d08bb..fb7ad51 100644 > --- a/drivers/net/i40e/i40e_flow.c > +++ b/drivers/net/i40e/i40e_flow.c > @@ -4240,6 +4240,14 @@ i40e_flow_parse_rss_action(struct rte_eth_dev > *dev, > return -rte_errno; > } > } > + > + if (rss_info->num < rss->num) { > + rte_flow_error_set(error, EINVAL, > + RTE_FLOW_ERROR_TYPE_ACTION, > + act, > + "no valid queues"); > + return -rte_errno; > + } > } >=20 > for (n =3D 0; n < conf_info->queue_region_number; n++) { @@ -4264,17 > +4272,6 @@ i40e_flow_parse_rss_action(struct rte_eth_dev *dev, > return -rte_errno; > } >=20 > - if (rss_info->num < rss->num || > - rss->queue[0] < rss_info->queue[0] || > - (rss->queue[0] + rss->num > > - rss_info->num + rss_info->queue[0])) { > - rte_flow_error_set(error, EINVAL, > - RTE_FLOW_ERROR_TYPE_ACTION, > - act, > - "no valid queues"); > - return -rte_errno; > - } > - > for (i =3D 0; i < info->queue_region_number; i++) { > if (info->region[i].queue_num =3D=3D rss->num && > info->region[i].queue_start_index =3D=3D > -- > 2.7.5