[dpdk-dev] [PATCH] net/i40e: add comment for flow RSS parse function

[dpdk-dev] [PATCH] net/i40e: add comment for flow RSS parse function

[Wei Zhao]

This patch add comment for flow rss parse function in
order to explain some important info.

Fixes: ecad87d22383 ("net/i40e: move RSS to flow API")
Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
---
 drivers/net/i40e/i40e_flow.c | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/drivers/net/i40e/i40e_flow.c b/drivers/net/i40e/i40e_flow.c
index 2068026..6404168 100644
--- a/drivers/net/i40e/i40e_flow.c
+++ b/drivers/net/i40e/i40e_flow.c
@@ -4171,6 +4171,19 @@ i40e_flow_parse_rss_pattern(__rte_unused struct rte_eth_dev *dev,
 	return 0;
 }
 
+/**
+ * This function is used to parse rss queue index, total queue number and
+ * hash functions, If the purpose of this configuration is for queue region
+ * configuration, it will set queue_region_conf flag to TRUE, else to FALSE.
+ * In queue region configuration, it also need to parse hardware flowtype
+ * and user_priority from configuration, it will also cheeck the validity
+ * of these parameters. For example, The queue region sizes should
+ * be any of the following values: 1, 2, 4, 8, 16, 32, 64, the
+ * hw_flowtype or PCTYPE max index should be 63, the user priority
+ * max index should be 7, and so on. And also, queue index should be
+ * continuous sequence and queue region index should be part of rss
+ * queue index for this port.
+ */
 static int
 i40e_flow_parse_rss_action(struct rte_eth_dev *dev,
 			    const struct rte_flow_action *actions,
-- 
2.7.5

Re: [dpdk-dev] [PATCH] net/i40e: add comment for flow RSS parse function

[Zhang, Qi Z]

No need separate patch, 
please merge this with another patch for queue index check since they are related.
And please Cc stable@dpdk.org in commit for a fix for previous release.

Regards
Qi


> -----Original Message-----
> From: Zhao1, Wei
> Sent: Monday, April 9, 2018 2:19 PM
> To: dev@dpdk.org
> Cc: stable@dpdk.org; Zhang, Qi Z <qi.z.zhang@intel.com>; Zhao1, Wei
> <wei.zhao1@intel.com>
> Subject: [PATCH] net/i40e: add comment for flow RSS parse function
> 
> This patch add comment for flow rss parse function in order to explain some
> important info.
> 
> Fixes: ecad87d22383 ("net/i40e: move RSS to flow API")
> Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
> ---
>  drivers/net/i40e/i40e_flow.c | 13 +++++++++++++
>  1 file changed, 13 insertions(+)
> 
> diff --git a/drivers/net/i40e/i40e_flow.c b/drivers/net/i40e/i40e_flow.c index
> 2068026..6404168 100644
> --- a/drivers/net/i40e/i40e_flow.c
> +++ b/drivers/net/i40e/i40e_flow.c
> @@ -4171,6 +4171,19 @@ i40e_flow_parse_rss_pattern(__rte_unused struct
> rte_eth_dev *dev,
>  	return 0;
>  }
> 
> +/**
> + * This function is used to parse rss queue index, total queue number
> +and
> + * hash functions, If the purpose of this configuration is for queue
> +region
> + * configuration, it will set queue_region_conf flag to TRUE, else to FALSE.
> + * In queue region configuration, it also need to parse hardware
> +flowtype
> + * and user_priority from configuration, it will also cheeck the
> +validity
> + * of these parameters. For example, The queue region sizes should
> + * be any of the following values: 1, 2, 4, 8, 16, 32, 64, the
> + * hw_flowtype or PCTYPE max index should be 63, the user priority
> + * max index should be 7, and so on. And also, queue index should be
> + * continuous sequence and queue region index should be part of rss
> + * queue index for this port.
> + */
>  static int
>  i40e_flow_parse_rss_action(struct rte_eth_dev *dev,
>  			    const struct rte_flow_action *actions,
> --
> 2.7.5