From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id BBCFA1B768 for ; Mon, 9 Apr 2018 09:35:50 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Apr 2018 00:35:49 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,426,1517904000"; d="scan'208";a="44601840" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by fmsmga004.fm.intel.com with ESMTP; 09 Apr 2018 00:35:49 -0700 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 9 Apr 2018 00:35:48 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.151]) by SHSMSX104.ccr.corp.intel.com ([169.254.5.239]) with mapi id 14.03.0319.002; Mon, 9 Apr 2018 15:35:38 +0800 From: "Zhang, Qi Z" To: "Zhao1, Wei" , "dev@dpdk.org" Thread-Topic: [PATCH] net/i40e: add comment for flow RSS parse function Thread-Index: AQHTz81OQ7wd+u1yZUSUDj9j+HUcbqP4CZHw Date: Mon, 9 Apr 2018 07:35:38 +0000 Message-ID: <039ED4275CED7440929022BC67E706115318CDDD@SHSMSX103.ccr.corp.intel.com> References: <1523254741-36400-1-git-send-email-wei.zhao1@intel.com> In-Reply-To: <1523254741-36400-1-git-send-email-wei.zhao1@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] net/i40e: add comment for flow RSS parse function X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Apr 2018 07:35:51 -0000 No need separate patch,=20 please merge this with another patch for queue index check since they are r= elated. And please Cc stable@dpdk.org in commit for a fix for previous release. Regards Qi > -----Original Message----- > From: Zhao1, Wei > Sent: Monday, April 9, 2018 2:19 PM > To: dev@dpdk.org > Cc: stable@dpdk.org; Zhang, Qi Z ; Zhao1, Wei > > Subject: [PATCH] net/i40e: add comment for flow RSS parse function >=20 > This patch add comment for flow rss parse function in order to explain so= me > important info. >=20 > Fixes: ecad87d22383 ("net/i40e: move RSS to flow API") > Signed-off-by: Wei Zhao > --- > drivers/net/i40e/i40e_flow.c | 13 +++++++++++++ > 1 file changed, 13 insertions(+) >=20 > diff --git a/drivers/net/i40e/i40e_flow.c b/drivers/net/i40e/i40e_flow.c = index > 2068026..6404168 100644 > --- a/drivers/net/i40e/i40e_flow.c > +++ b/drivers/net/i40e/i40e_flow.c > @@ -4171,6 +4171,19 @@ i40e_flow_parse_rss_pattern(__rte_unused struct > rte_eth_dev *dev, > return 0; > } >=20 > +/** > + * This function is used to parse rss queue index, total queue number > +and > + * hash functions, If the purpose of this configuration is for queue > +region > + * configuration, it will set queue_region_conf flag to TRUE, else to FA= LSE. > + * In queue region configuration, it also need to parse hardware > +flowtype > + * and user_priority from configuration, it will also cheeck the > +validity > + * of these parameters. For example, The queue region sizes should > + * be any of the following values: 1, 2, 4, 8, 16, 32, 64, the > + * hw_flowtype or PCTYPE max index should be 63, the user priority > + * max index should be 7, and so on. And also, queue index should be > + * continuous sequence and queue region index should be part of rss > + * queue index for this port. > + */ > static int > i40e_flow_parse_rss_action(struct rte_eth_dev *dev, > const struct rte_flow_action *actions, > -- > 2.7.5