From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 2A9941B785; Tue, 10 Apr 2018 12:45:03 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Apr 2018 03:45:02 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,431,1517904000"; d="scan'208";a="42153540" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga003.jf.intel.com with ESMTP; 10 Apr 2018 03:45:02 -0700 Received: from fmsmsx152.amr.corp.intel.com (10.18.125.5) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 10 Apr 2018 03:45:02 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by FMSMSX152.amr.corp.intel.com (10.18.125.5) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 10 Apr 2018 03:45:02 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.151]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.197]) with mapi id 14.03.0319.002; Tue, 10 Apr 2018 18:45:00 +0800 From: "Zhang, Qi Z" To: "Zhao1, Wei" , "dev@dpdk.org" CC: "stable@dpdk.org" Thread-Topic: [PATCH v2] net/i40e: fix flow RSS queue index check error Thread-Index: AQHTz+CxobwWHtFbXUyo5aQGpGEfkKP4cY+wgABNLwCAARJsEA== Date: Tue, 10 Apr 2018 10:45:00 +0000 Message-ID: <039ED4275CED7440929022BC67E706115318E985@SHSMSX103.ccr.corp.intel.com> References: <1523165844-5362-1-git-send-email-wei.zhao1@intel.com> <1523263064-11378-1-git-send-email-wei.zhao1@intel.com> <039ED4275CED7440929022BC67E706115318D355@SHSMSX103.ccr.corp.intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2] net/i40e: fix flow RSS queue index check error X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Apr 2018 10:45:05 -0000 > -----Original Message----- > From: Zhao1, Wei > Sent: Tuesday, April 10, 2018 10:19 AM > To: Zhang, Qi Z ; dev@dpdk.org > Cc: stable@dpdk.org > Subject: RE: [PATCH v2] net/i40e: fix flow RSS queue index check error >=20 >=20 >=20 > > -----Original Message----- > > From: Zhang, Qi Z > > Sent: Monday, April 9, 2018 9:57 PM > > To: Zhao1, Wei ; dev@dpdk.org > > Cc: stable@dpdk.org > > Subject: RE: [PATCH v2] net/i40e: fix flow RSS queue index check error > > > > > > > > > -----Original Message----- > > > From: Zhao1, Wei > > > Sent: Monday, April 9, 2018 4:38 PM > > > To: dev@dpdk.org > > > Cc: stable@dpdk.org; Zhang, Qi Z ; Zhao1, Wei > > > > > > Subject: [PATCH v2] net/i40e: fix flow RSS queue index check error > > > > > > There is an error in queue index check for RSS queue region > > > configuration.If the queue index is not continuous sequence for RSS, > > > but queue region index is continuous sequence, in this case we can > > > not use the old method for queue index check. > > > This patch also add comment for flow rss parse function in order to > > > explain some important info. > > > > > > Fixes: ecad87d22383 ("net/i40e: move RSS to flow API") > > > Signed-off-by: Wei Zhao > > > Tested-by: Peng Yuan > > > > > > --- > > > > > > v2: > > > -merge this with another patch for function comment, add git log info= . > > > --- > > > drivers/net/i40e/i40e_flow.c | 32 +++++++++++++++++++++----------- > > > 1 file changed, 21 insertions(+), 11 deletions(-) > > > > > > diff --git a/drivers/net/i40e/i40e_flow.c > > > b/drivers/net/i40e/i40e_flow.c index > > > f4d08bb..40f15c2 100644 > > > --- a/drivers/net/i40e/i40e_flow.c > > > +++ b/drivers/net/i40e/i40e_flow.c > > > @@ -4171,6 +4171,19 @@ i40e_flow_parse_rss_pattern(__rte_unused > > struct > > > rte_eth_dev *dev, > > > return 0; > > > } > > > > > > +/** > > > + * This function is used to parse rss queue index, total queue > > > +number and > > > + * hash functions, If the purpose of this configuration is for > > > +queue region > > > + * configuration, it will set queue_region_conf flag to TRUE, else t= o FALSE. > > > + * In queue region configuration, it also need to parse hardware > > > +flowtype > > > + * and user_priority from configuration, it will also cheeck the > > > +validity > > > + * of these parameters. For example, The queue region sizes should > > > + * be any of the following values: 1, 2, 4, 8, 16, 32, 64, the > > > + * hw_flowtype or PCTYPE max index should be 63, the user priority > > > + * max index should be 7, and so on. And also, queue index should > > > +be > > > + * continuous sequence and queue region index should be part of rss > > > + * queue index for this port. > > > + */ > > > static int > > > i40e_flow_parse_rss_action(struct rte_eth_dev *dev, > > > const struct rte_flow_action *actions, @@ -4240,6 > > > +4253,14 @@ i40e_flow_parse_rss_action(struct rte_eth_dev *dev, > > > return -rte_errno; > > > } > > > } > > > + > > > + if (rss_info->num < rss->num) { > > > + rte_flow_error_set(error, EINVAL, > > > + RTE_FLOW_ERROR_TYPE_ACTION, > > > + act, > > > + "no valid queues"); > > > + return -rte_errno; > > > + } > > > } > > > > > > for (n =3D 0; n < conf_info->queue_region_number; n++) { @@ - > > 4264,17 > > > +4285,6 @@ i40e_flow_parse_rss_action(struct rte_eth_dev *dev, > > > return -rte_errno; > > > } > > > > > > - if (rss_info->num < rss->num || > > > - rss->queue[0] < rss_info->queue[0] || > > > - (rss->queue[0] + rss->num > > > > - rss_info->num + rss_info->queue[0])) > > { > > > - rte_flow_error_set(error, EINVAL, > > > - RTE_FLOW_ERROR_TYPE_ACTION, > > > - act, > > > - "no valid queues"); > > > - return -rte_errno; > > > - } > > > > Is this a code clean? > > I didn't see anything wrong with the code you removed, but they just > > looks redundant. > > Btw why you still check (rss_info->num < rss->num) ?, previous, I > > think you already iterate all rss queue to make sure they are matched > > by a rss_info queue so it already proved rss_info->num >=3D rss->num. >=20 > After thinking it over, I think we had better keep this check for (rss_in= fo->num > < rss->num) because customer may input a wrong number for this parameter, > although queue index maybe rightly match rss span. So, v3 may be not need= . If rss->num > rss_info->num, it should already failed in below code, so I s= till think it's no necessary. /* each rss queue must match a rss_info queue */ for (i =3D 0; i < rss->num; i++) { for (j =3D 0; j < rss_info->num; j++) { if (rss->queue[i] =3D=3D rss_info->queue[j]= ) break; } if (j =3D=3D rss_info->num) { rte_flow_error_set(error, EINVAL, RTE_FLOW_ERROR_TYPE_ACTION, act, "no valid queues"); return -rte_errno; } } =09 /* rss queue must be continues */ for (i =3D 0; i < rss->num - 1; i++) { if (rss->queue[i + 1] !=3D rss->queue[i] + 1) { rte_flow_error_set(error, EINVAL, RTE_FLOW_ERROR_TYPE_ACTION, act, "no valid queues"); return -rte_errno; } } >=20 >=20 > > > > > > > for (i =3D 0; i < info->queue_region_number; i++) { > > > if (info->region[i].queue_num =3D=3D rss->num > > && > > > info->region[i].queue_start_index =3D=3D > > > -- > > > 2.7.5