From: "Zhang, Qi Z" <qi.z.zhang@intel.com>
To: Shweta Choudaha <shweta.choudaha@gmail.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "Lu, Wenzhuo" <wenzhuo.lu@intel.com>,
"Ananyev, Konstantin" <konstantin.ananyev@intel.com>,
"Zhang, Helin" <helin.zhang@intel.com>,
"Yigit, Ferruh" <ferruh.yigit@intel.com>,
"shweta.choudaha@att.com" <shweta.choudaha@att.com>
Subject: Re: [dpdk-dev] [PATCH v3] net/ixgbe: Add access and locking APIs for MDIO
Date: Fri, 13 Apr 2018 02:37:54 +0000 [thread overview]
Message-ID: <039ED4275CED7440929022BC67E70611531909EA@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <20180411135935.61232-1-shweta.choudaha@gmail.com>
Hi Choudaha:
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Shweta Choudaha
> Sent: Wednesday, April 11, 2018 10:00 PM
> To: dev@dpdk.org
> Cc: Lu, Wenzhuo <wenzhuo.lu@intel.com>; Ananyev, Konstantin
> <konstantin.ananyev@intel.com>; Zhang, Helin <helin.zhang@intel.com>; Yigit,
> Ferruh <ferruh.yigit@intel.com>; shweta.choudaha@att.com
> Subject: [dpdk-dev] [PATCH v3] net/ixgbe: Add access and locking APIs for
> MDIO
Nitpick: title should not start with uppercase.
> +
> +EXPERIMENTAL {
> + global:
> +
> + rte_pmd_ixgbe_lock_mdio;
> + rte_pmd_ixgbe_unlock_mdio;
Can we rename to rte_pmd_ixgbe_mdio_lock and rte_pmd_ixgbe_mdio_unlock, so all mdio functions can be list closely when follow the alphabet sequence?
> + rte_pmd_ixgbe_mdio_read_unlocked;
> + rte_pmd_ixgbe_mdio_write_unlocked;
And this could be rte_pmd_ixgbe_mdio_unlocked_read/write to follow the same pattern that action after object
Regards
Qi
> +} DPDK_18.05;
> --
> 2.11.0
next prev parent reply other threads:[~2018-04-13 2:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-21 17:36 [dpdk-dev] [PATCH v2 0/1] net/ixgbe: Add read/write PMD MDIO API Shweta Choudaha
2018-03-21 17:36 ` [dpdk-dev] [PATCH v2 1/1] net/ixgbe: Add access and locking APIs for MDIO Shweta Choudaha
2018-04-04 2:15 ` Lu, Wenzhuo
2018-04-11 14:01 ` Shweta Choudaha
2018-04-11 13:59 ` [dpdk-dev] [PATCH v3] " Shweta Choudaha
2018-04-13 2:37 ` Zhang, Qi Z [this message]
2018-04-13 16:41 ` Shweta Choudaha
2018-04-13 16:35 ` [dpdk-dev] [PATCH v4] net/ixgbe: add " Shweta Choudaha
2018-04-15 13:32 ` Zhang, Qi Z
2018-04-17 16:14 ` Zhang, Helin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=039ED4275CED7440929022BC67E70611531909EA@SHSMSX103.ccr.corp.intel.com \
--to=qi.z.zhang@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=helin.zhang@intel.com \
--cc=konstantin.ananyev@intel.com \
--cc=shweta.choudaha@att.com \
--cc=shweta.choudaha@gmail.com \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).