From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 7474A7CA9 for ; Tue, 17 Apr 2018 15:31:33 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Apr 2018 06:31:32 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,463,1517904000"; d="scan'208";a="217249214" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by orsmga005.jf.intel.com with ESMTP; 17 Apr 2018 06:31:30 -0700 Received: from fmsmsx157.amr.corp.intel.com (10.18.116.73) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 17 Apr 2018 06:31:30 -0700 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by FMSMSX157.amr.corp.intel.com (10.18.116.73) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 17 Apr 2018 06:31:29 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.79]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.40]) with mapi id 14.03.0319.002; Tue, 17 Apr 2018 21:31:28 +0800 From: "Zhang, Qi Z" To: "Xu, Rosen" , "dev@dpdk.org" CC: "Xing, Beilei" , "Zhang, Helin" , "Wu, Jingjing" Thread-Topic: [PATCH v3] drivers/net/i40e: fix missing promiscuous disable at device disable Thread-Index: AQHT1fhW+AgHoryi0EK0NsUGTr4SnqQE6okg Date: Tue, 17 Apr 2018 13:31:27 +0000 Message-ID: <039ED4275CED7440929022BC67E706115319A0CE@shsmsx102.ccr.corp.intel.com> References: <1521090873-50595-1-git-send-email-rosen.xu@intel.com> <1523934168-128914-1-git-send-email-rosen.xu@intel.com> In-Reply-To: <1523934168-128914-1-git-send-email-rosen.xu@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMmFhNTY4NzUtOWViMy00NjZmLTk3MmItZTUyMjA0MjQyM2NjIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjIuNS4xOCIsIlRydXN0ZWRMYWJlbEhhc2giOiJvM2hcL2ZIbzdaOVJ5amFZNVBoYkJWOU50NjZCM2lEaGNSSExXZk9LMGUwaFptZDFjRlBSVEZ1MVBHVStYVkhcL0cifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.200.100 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3] drivers/net/i40e: fix missing promiscuous disable at device disable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Apr 2018 13:31:34 -0000 Hi Rosen: > -----Original Message----- > From: Xu, Rosen > Sent: Tuesday, April 17, 2018 11:03 AM > To: dev@dpdk.org > Cc: Xing, Beilei ; Zhang, Helin > ; Zhang, Qi Z ; Wu, Jingjing > > Subject: [PATCH v3] drivers/net/i40e: fix missing promiscuous disable at > device disable >=20 > v3 updates: > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > - Move modification from device close to device disable > - i40evf_reset_vf() will cause kernel driver enable all vlan promiscuous= , > so unicast/multicast promiscuous disable should set before reset. >=20 > v2 updates: > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > - Add more comments Version log can be added after ---, so it will not be included by commit lo= g. >=20 > In scenario of Kernel Driver runs on PF and PMD runs on VF, PMD exit > doesn't disable promiscuous mode, this will cause vlan filter set by Kern= el > Driver will not take effect. >=20 > This patch will fix it, add promiscuous disable at device disable. >=20 > Signed-off-by: Rosen Xu > --- > drivers/net/i40e/i40e_ethdev_vf.c | 2 ++ > 1 file changed, 2 insertions(+) >=20 > diff --git a/drivers/net/i40e/i40e_ethdev_vf.c > b/drivers/net/i40e/i40e_ethdev_vf.c > index 031c706..40012b0 100644 > --- a/drivers/net/i40e/i40e_ethdev_vf.c > +++ b/drivers/net/i40e/i40e_ethdev_vf.c > @@ -2288,6 +2288,8 @@ static int eth_i40evf_pci_remove(struct > rte_pci_device *pci_dev) >=20 > i40evf_dev_stop(dev); > i40e_dev_free_queues(dev); I think it's better to add some comment here,=20 since this is a workaround solution and it is not the normal way we disable promiscuous mode, people need to be noticed here.=20 Regards Qi > + i40evf_dev_promiscuous_disable(dev); > + i40evf_dev_allmulticast_disable(dev); > i40evf_reset_vf(hw); > i40e_shutdown_adminq(hw); > /* disable uio intr before callback unregister */ > -- > 1.8.3.1