From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id C6A8710B7 for ; Wed, 25 Apr 2018 07:33:22 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Apr 2018 22:33:21 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,325,1520924400"; d="scan'208";a="194184405" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by orsmga004.jf.intel.com with ESMTP; 24 Apr 2018 22:33:21 -0700 Received: from fmsmsx101.amr.corp.intel.com (10.18.124.199) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 24 Apr 2018 22:33:20 -0700 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by fmsmsx101.amr.corp.intel.com (10.18.124.199) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 24 Apr 2018 22:33:20 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.210]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.40]) with mapi id 14.03.0319.002; Wed, 25 Apr 2018 13:33:18 +0800 From: "Zhang, Qi Z" To: Thomas Monjalon CC: "dev@dpdk.org" , "Ananyev, Konstantin" , "Xing, Beilei" , "Wu, Jingjing" , "Lu, Wenzhuo" , "Yigit, Ferruh" , "Doherty, Declan" Thread-Topic: [dpdk-dev] [PATCH v6 1/3] ether: support runtime queue setup Thread-Index: AQHTzuM55lsVY2HYzUy+3ZgnUJHJIqP5hEeAgBZe34CAARXmwA== Date: Wed, 25 Apr 2018 05:33:18 +0000 Message-ID: <039ED4275CED7440929022BC67E70611531A7E9E@SHSMSX103.ccr.corp.intel.com> References: <20180212045314.171616-1-qi.z.zhang@intel.com> <20180408024221.228450-2-qi.z.zhang@intel.com> <9581683.2joz8NotYG@xps> <2014014.MPIIikSFdI@xps> In-Reply-To: <2014014.MPIIikSFdI@xps> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZDRhNzc1NTEtZjNiZS00MTRlLWIwNzktNDA4MzcxNWZiNjFmIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjIuNS4xOCIsIlRydXN0ZWRMYWJlbEhhc2giOiI3K1FlWTkyaFhZODJ3YnpwRXJFdVlFY1NLQlNNdTNSb0dxRm9jVFVpVFcwMXh0TGFIK0xha3F5TlorckVweUVMIn0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.200.100 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v6 1/3] ether: support runtime queue setup X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Apr 2018 05:33:23 -0000 Hi Thomas: > -----Original Message----- > From: Thomas Monjalon [mailto:thomas@monjalon.net] > Sent: Wednesday, April 25, 2018 3:36 AM > To: Zhang, Qi Z > Cc: dev@dpdk.org; Ananyev, Konstantin ; > Xing, Beilei ; Wu, Jingjing ; > Lu, Wenzhuo ; Yigit, Ferruh > ; Doherty, Declan > Subject: Re: [dpdk-dev] [PATCH v6 1/3] ether: support runtime queue setup >=20 > 10/04/2018 15:59, Thomas Monjalon: > > > --- a/lib/librte_ether/rte_ethdev.h > > > +++ b/lib/librte_ether/rte_ethdev.h > > > +#define DEV_RUNTIME_RX_QUEUE_SETUP 0x00000001 /**< Deferred > setup > > > +rx queue */ #define DEV_RUNTIME_TX_QUEUE_SETUP 0x00000002 > /**< > > > +Deferred setup tx queue */ > > > > Please use RTE_ETH_ prefix. Actually I saw all the offload flag is started with DEV_, so Should I still need rename to RTE_ETH_DEV_CAPA_***?=20 >=20 > Qi, you missed this comment. > It must be fixed by a new patch, please. >=20 > And the field must mention the related flags prefix. OK I will add this.=20 Regards Qi