From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 0C6C220BD for ; Wed, 2 May 2018 05:05:16 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 01 May 2018 20:05:15 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,353,1520924400"; d="scan'208";a="42289294" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by fmsmga002.fm.intel.com with ESMTP; 01 May 2018 20:05:14 -0700 Received: from fmsmsx158.amr.corp.intel.com (10.18.116.75) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 1 May 2018 20:05:14 -0700 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by fmsmsx158.amr.corp.intel.com (10.18.116.75) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 1 May 2018 20:05:14 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.210]) by shsmsx102.ccr.corp.intel.com ([169.254.2.79]) with mapi id 14.03.0319.002; Wed, 2 May 2018 11:05:07 +0800 From: "Zhang, Qi Z" To: "Yigit, Ferruh" , "Ananyev, Konstantin" CC: "dev@dpdk.org" , "Xing, Beilei" Thread-Topic: [PATCH 2/2] net/i40e: remove dependence on Tx queue flags Thread-Index: AQHT4b9li81G4BF2v0GRwXzUGB0ptqQbwJng Date: Wed, 2 May 2018 03:05:06 +0000 Message-ID: <039ED4275CED7440929022BC67E70611531AADC4@SHSMSX103.ccr.corp.intel.com> References: <20180502024346.275514-1-qi.z.zhang@intel.com> <20180502024346.275514-2-qi.z.zhang@intel.com> In-Reply-To: <20180502024346.275514-2-qi.z.zhang@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNGFiZDVlZDUtNzFlOC00MDRkLWFiNDAtMzQ3NzFmZDE4NzA3IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjIuNS4xOCIsIlRydXN0ZWRMYWJlbEhhc2giOiIzbVZXdTdpdmxGQ1RpTmJRV1BoSDhWSkcxcmxtWmtYUXBFcHl1bWJjbHlNVXhUTTdNbXg0a2NuTlNSZ29pNHdcLyJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.200.100 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 2/2] net/i40e: remove dependence on Tx queue flags X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 May 2018 03:05:17 -0000 Hi Ferruh: > -----Original Message----- > From: Zhang, Qi Z > Sent: Wednesday, May 2, 2018 10:44 AM > To: Yigit, Ferruh ; Ananyev, Konstantin > > Cc: dev@dpdk.org; Xing, Beilei ; Zhang, Qi Z > > Subject: [PATCH 2/2] net/i40e: remove dependence on Tx queue flags >=20 > Since we move to new offload APIs, txq_flags is no long needed. > This patch remove the dependence on that. >=20 > Fixes: 7497d3e2f777 ("net/i40e: convert to new Tx offloads API") > Fixes: c3ac7c5b0b8a ("net/i40e: convert to new Rx offloads API") The above fix line or RX should be removed, if no other issue for the patch= , Would you capture this when apply? Thanks Qi >=20 > Signed-off-by: Qi Zhang > --- > drivers/net/i40e/i40e_ethdev.c | 2 -- > drivers/net/i40e/i40e_ethdev_vf.c | 2 -- > drivers/net/i40e/i40e_rxtx.c | 4 +--- > drivers/net/i40e/i40e_rxtx.h | 1 - > drivers/net/i40e/i40e_vf_representor.c | 2 -- > 5 files changed, 1 insertion(+), 10 deletions(-) >=20 > diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethde= v.c > index a001d5b99..92ee6c5ae 100644 > --- a/drivers/net/i40e/i40e_ethdev.c > +++ b/drivers/net/i40e/i40e_ethdev.c > @@ -3343,8 +3343,6 @@ i40e_dev_info_get(struct rte_eth_dev *dev, struct > rte_eth_dev_info *dev_info) > }, > .tx_free_thresh =3D I40E_DEFAULT_TX_FREE_THRESH, > .tx_rs_thresh =3D I40E_DEFAULT_TX_RSBIT_THRESH, > - .txq_flags =3D ETH_TXQ_FLAGS_NOMULTSEGS | > - ETH_TXQ_FLAGS_NOOFFLOADS, > .offloads =3D 0, > }; >=20 > diff --git a/drivers/net/i40e/i40e_ethdev_vf.c > b/drivers/net/i40e/i40e_ethdev_vf.c > index de5f460e9..b9dea2e5b 100644 > --- a/drivers/net/i40e/i40e_ethdev_vf.c > +++ b/drivers/net/i40e/i40e_ethdev_vf.c > @@ -2236,8 +2236,6 @@ i40evf_dev_info_get(struct rte_eth_dev *dev, > struct rte_eth_dev_info *dev_info) > }, > .tx_free_thresh =3D I40E_DEFAULT_TX_FREE_THRESH, > .tx_rs_thresh =3D I40E_DEFAULT_TX_RSBIT_THRESH, > - .txq_flags =3D ETH_TXQ_FLAGS_NOMULTSEGS | > - ETH_TXQ_FLAGS_NOOFFLOADS, > .offloads =3D 0, > }; >=20 > diff --git a/drivers/net/i40e/i40e_rxtx.c b/drivers/net/i40e/i40e_rxtx.c = index > 755109ee5..62985c3a9 100644 > --- a/drivers/net/i40e/i40e_rxtx.c > +++ b/drivers/net/i40e/i40e_rxtx.c > @@ -1237,7 +1237,7 @@ i40e_tx_free_bufs(struct i40e_tx_queue *txq) > for (i =3D 0; i < txq->tx_rs_thresh; i++) > rte_prefetch0((txep + i)->mbuf); >=20 > - if (txq->txq_flags & (uint32_t)ETH_TXQ_FLAGS_NOREFCOUNT) { > + if (txq->offloads & DEV_TX_OFFLOAD_MBUF_FAST_FREE) { > for (i =3D 0; i < txq->tx_rs_thresh; ++i, ++txep) { > rte_mempool_put(txep->mbuf->pool, txep->mbuf); > txep->mbuf =3D NULL; > @@ -2297,7 +2297,6 @@ i40e_dev_tx_queue_setup(struct rte_eth_dev > *dev, > txq->queue_id =3D queue_idx; > txq->reg_idx =3D reg_idx; > txq->port_id =3D dev->data->port_id; > - txq->txq_flags =3D tx_conf->txq_flags; > txq->offloads =3D tx_conf->offloads; > txq->vsi =3D vsi; > txq->tx_deferred_start =3D tx_conf->tx_deferred_start; @@ -2951,7 > +2950,6 @@ i40e_txq_info_get(struct rte_eth_dev *dev, uint16_t queue_id, >=20 > qinfo->conf.tx_free_thresh =3D txq->tx_free_thresh; > qinfo->conf.tx_rs_thresh =3D txq->tx_rs_thresh; > - qinfo->conf.txq_flags =3D txq->txq_flags; > qinfo->conf.tx_deferred_start =3D txq->tx_deferred_start; } >=20 > diff --git a/drivers/net/i40e/i40e_rxtx.h b/drivers/net/i40e/i40e_rxtx.h = index > 10feec4a2..ea73a8a1b 100644 > --- a/drivers/net/i40e/i40e_rxtx.h > +++ b/drivers/net/i40e/i40e_rxtx.h > @@ -142,7 +142,6 @@ struct i40e_tx_queue { > uint16_t port_id; /**< Device port identifier. */ > uint16_t queue_id; /**< TX queue index. */ > uint16_t reg_idx; > - uint32_t txq_flags; > struct i40e_vsi *vsi; /**< the VSI this queue belongs to */ > uint16_t tx_next_dd; > uint16_t tx_next_rs; > diff --git a/drivers/net/i40e/i40e_vf_representor.c > b/drivers/net/i40e/i40e_vf_representor.c > index 7b67e23ae..068404f75 100644 > --- a/drivers/net/i40e/i40e_vf_representor.c > +++ b/drivers/net/i40e/i40e_vf_representor.c > @@ -79,8 +79,6 @@ i40e_vf_representor_dev_infos_get(struct rte_eth_dev > *ethdev, > }, > .tx_free_thresh =3D I40E_DEFAULT_TX_FREE_THRESH, > .tx_rs_thresh =3D I40E_DEFAULT_TX_RSBIT_THRESH, > - .txq_flags =3D ETH_TXQ_FLAGS_NOMULTSEGS | > - ETH_TXQ_FLAGS_NOOFFLOADS, > .offloads =3D 0, > }; >=20 > -- > 2.13.6