From: "Zhang, Qi Z" <qi.z.zhang@intel.com>
To: "Zhao1, Wei" <wei.zhao1@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "adrien.mazarguil@6wind.com" <adrien.mazarguil@6wind.com>
Subject: Re: [dpdk-dev] [PATCH] net/i40e: fix flow RSS key array error
Date: Mon, 7 May 2018 06:27:44 +0000 [thread overview]
Message-ID: <039ED4275CED7440929022BC67E70611531AD5BE@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <1525671240-38485-1-git-send-email-wei.zhao1@intel.com>
> -----Original Message-----
> From: Zhao1, Wei
> Sent: Monday, May 7, 2018 1:34 PM
> To: dev@dpdk.org
> Cc: Zhang, Qi Z <qi.z.zhang@intel.com>; adrien.mazarguil@6wind.com; Zhao1,
> Wei <wei.zhao1@intel.com>
> Subject: [PATCH] net/i40e: fix flow RSS key array error
>
> This is a bug introduced into RSS key array span.
>
> Fixes: ac8d22de2394 ("ethdev: flatten RSS configuration in flow API")
Is this correct fix line? Looks like a bug already exist at beginning. Below definition is obviously wrong
uint8_t key[(I40E_VFQF_HKEY_MAX_INDEX > I40E_PFQF_HKEY_MAX_INDEX ?
I40E_VFQF_HKEY_MAX_INDEX : I40E_PFQF_HKEY_MAX_INDEX) + 1 *
sizeof(uint32_t)]; /* Hash key. */
> Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
> ---
> drivers/net/i40e/i40e_ethdev.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/i40e/i40e_ethdev.h b/drivers/net/i40e/i40e_ethdev.h
> index 2cccc4f..4dd50eb 100644
> --- a/drivers/net/i40e/i40e_ethdev.h
> +++ b/drivers/net/i40e/i40e_ethdev.h
> @@ -886,7 +886,7 @@ struct i40e_rte_flow_rss_conf {
> struct rte_flow_action_rss conf; /**< RSS parameters. */
> uint16_t queue_region_conf; /**< Queue region config flag */
> uint8_t key[(I40E_VFQF_HKEY_MAX_INDEX >
> I40E_PFQF_HKEY_MAX_INDEX ?
> - I40E_VFQF_HKEY_MAX_INDEX : I40E_PFQF_HKEY_MAX_INDEX)
> + 1 *
> + I40E_VFQF_HKEY_MAX_INDEX : I40E_PFQF_HKEY_MAX_INDEX
> + 1) *
> sizeof(uint32_t)]; /* Hash key. */
> uint16_t queue[I40E_MAX_Q_PER_TC]; /**< Queues indices to use. */ };
> --
> 2.7.5
next prev parent reply other threads:[~2018-05-07 6:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-07 5:34 Wei Zhao
2018-05-07 6:27 ` Zhang, Qi Z [this message]
2018-05-07 6:30 ` Zhao1, Wei
2018-05-07 6:35 ` Zhang, Qi Z
2018-05-07 6:40 ` Zhang, Qi Z
2018-05-08 1:56 ` Zhang, Helin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=039ED4275CED7440929022BC67E70611531AD5BE@SHSMSX103.ccr.corp.intel.com \
--to=qi.z.zhang@intel.com \
--cc=adrien.mazarguil@6wind.com \
--cc=dev@dpdk.org \
--cc=wei.zhao1@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).