From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id EB4A32BAE for ; Mon, 7 May 2018 08:35:41 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 06 May 2018 23:35:40 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,373,1520924400"; d="scan'208";a="53749927" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga001.jf.intel.com with ESMTP; 06 May 2018 23:35:40 -0700 Received: from FMSMSX110.amr.corp.intel.com (10.18.116.10) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.319.2; Sun, 6 May 2018 23:35:33 -0700 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by fmsmsx110.amr.corp.intel.com (10.18.116.10) with Microsoft SMTP Server (TLS) id 14.3.319.2; Sun, 6 May 2018 23:35:33 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.210]) by SHSMSX104.ccr.corp.intel.com ([169.254.5.240]) with mapi id 14.03.0319.002; Mon, 7 May 2018 14:35:32 +0800 From: "Zhang, Qi Z" To: "Zhao1, Wei" , "dev@dpdk.org" CC: "adrien.mazarguil@6wind.com" Thread-Topic: [PATCH] net/i40e: fix flow RSS key array error Thread-Index: AQHT5cfFEBzxTBng1kyN0+395ZiQGqQjy5rQ//98iACAAIbIgA== Date: Mon, 7 May 2018 06:35:31 +0000 Message-ID: <039ED4275CED7440929022BC67E70611531AD5E8@SHSMSX103.ccr.corp.intel.com> References: <1525671240-38485-1-git-send-email-wei.zhao1@intel.com> <039ED4275CED7440929022BC67E70611531AD5BE@SHSMSX103.ccr.corp.intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNTc2MDEyNzQtOTllNy00Y2U1LWI0MDItOTQxYTNiZDUxOTcxIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjIuNS4xOCIsIlRydXN0ZWRMYWJlbEhhc2giOiJ4N3V1V1hYUXA2UVdHSGx6WnhWazBxZTNORzNHb1hoR3hXNXdZN3g1KzNWZ1wvZHhCcG1xR2NURExQNVh3TUlaMiJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.200.100 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] net/i40e: fix flow RSS key array error X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 May 2018 06:35:42 -0000 > -----Original Message----- > From: Zhao1, Wei > Sent: Monday, May 7, 2018 2:31 PM > To: Zhang, Qi Z ; dev@dpdk.org > Cc: adrien.mazarguil@6wind.com > Subject: RE: [PATCH] net/i40e: fix flow RSS key array error >=20 >=20 >=20 > > -----Original Message----- > > From: Zhang, Qi Z > > Sent: Monday, May 7, 2018 2:28 PM > > To: Zhao1, Wei ; dev@dpdk.org > > Cc: adrien.mazarguil@6wind.com > > Subject: RE: [PATCH] net/i40e: fix flow RSS key array error > > > > > > > > > -----Original Message----- > > > From: Zhao1, Wei > > > Sent: Monday, May 7, 2018 1:34 PM > > > To: dev@dpdk.org > > > Cc: Zhang, Qi Z ; adrien.mazarguil@6wind.com; > > > Zhao1, Wei > > > Subject: [PATCH] net/i40e: fix flow RSS key array error > > > > > > This is a bug introduced into RSS key array span. > > > > > > Fixes: ac8d22de2394 ("ethdev: flatten RSS configuration in flow > > > API") > > > > Is this correct fix line? Looks like a bug already exist at beginning. > > Below definition is obviously wrong > > > > uint8_t key[(I40E_VFQF_HKEY_MAX_INDEX > > > I40E_PFQF_HKEY_MAX_INDEX ? > > I40E_VFQF_HKEY_MAX_INDEX : > > I40E_PFQF_HKEY_MAX_INDEX) + > > 1 * > > sizeof(uint32_t)]; /* Hash key. */' >=20 > Yes, this is as adrien.mazarguil request. OK, the wrong code is part of the patch. Thanks Qi >=20 > > > > > Signed-off-by: Wei Zhao > > > --- > > > drivers/net/i40e/i40e_ethdev.h | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/drivers/net/i40e/i40e_ethdev.h > > > b/drivers/net/i40e/i40e_ethdev.h index 2cccc4f..4dd50eb 100644 > > > --- a/drivers/net/i40e/i40e_ethdev.h > > > +++ b/drivers/net/i40e/i40e_ethdev.h > > > @@ -886,7 +886,7 @@ struct i40e_rte_flow_rss_conf { > > > struct rte_flow_action_rss conf; /**< RSS parameters. */ > > > uint16_t queue_region_conf; /**< Queue region config flag */ > > > uint8_t key[(I40E_VFQF_HKEY_MAX_INDEX > > > I40E_PFQF_HKEY_MAX_INDEX ? > > > - I40E_VFQF_HKEY_MAX_INDEX : > > I40E_PFQF_HKEY_MAX_INDEX) > > > + 1 * > > > + I40E_VFQF_HKEY_MAX_INDEX : > > I40E_PFQF_HKEY_MAX_INDEX > > > + 1) * > > > sizeof(uint32_t)]; /* Hash key. */ > > > uint16_t queue[I40E_MAX_Q_PER_TC]; /**< Queues indices to use. > > */ > > > }; > > > -- > > > 2.7.5