DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Zhang, Qi Z" <qi.z.zhang@intel.com>
To: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>,
	"Wu, Yanglong" <yanglong.wu@intel.com>,
	"dev@dpdk.org" <dev@dpdk.org>
Cc: "Lu, Wenzhuo" <wenzhuo.lu@intel.com>,
	"Wu, Yanglong" <yanglong.wu@intel.com>
Subject: Re: [dpdk-dev] [PATCH] ethdev: fix checking Rx/Tx queue status
Date: Fri, 11 May 2018 12:34:06 +0000	[thread overview]
Message-ID: <039ED4275CED7440929022BC67E70611531B14E8@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <2601191342CEEE43887BDE71AB977258AEDC5DA4@irsmsx105.ger.corp.intel.com>



> -----Original Message-----
> From: Ananyev, Konstantin
> Sent: Friday, May 11, 2018 5:51 PM
> To: Zhang, Qi Z <qi.z.zhang@intel.com>; Wu, Yanglong
> <yanglong.wu@intel.com>; dev@dpdk.org
> Cc: Lu, Wenzhuo <wenzhuo.lu@intel.com>; Wu, Yanglong
> <yanglong.wu@intel.com>
> Subject: RE: [dpdk-dev] [PATCH] ethdev: fix checking Rx/Tx queue status
> 
> 
> 
> > -----Original Message-----
> > From: Zhang, Qi Z
> > Sent: Friday, May 11, 2018 10:24 AM
> > To: Ananyev, Konstantin <konstantin.ananyev@intel.com>; Wu, Yanglong
> > <yanglong.wu@intel.com>; dev@dpdk.org
> > Cc: Lu, Wenzhuo <wenzhuo.lu@intel.com>; Wu, Yanglong
> > <yanglong.wu@intel.com>
> > Subject: RE: [dpdk-dev] [PATCH] ethdev: fix checking Rx/Tx queue
> > status
> >
> >
> >
> > > -----Original Message-----
> > > From: Ananyev, Konstantin
> > > Sent: Friday, May 11, 2018 4:39 PM
> > > To: Wu, Yanglong <yanglong.wu@intel.com>; dev@dpdk.org
> > > Cc: Zhang, Qi Z <qi.z.zhang@intel.com>; Lu, Wenzhuo
> > > <wenzhuo.lu@intel.com>; Wu, Yanglong <yanglong.wu@intel.com>
> > > Subject: RE: [dpdk-dev] [PATCH] ethdev: fix checking Rx/Tx queue
> > > status
> > >
> > >
> > >
> > > > -----Original Message-----
> > > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Yanglong Wu
> > > > Sent: Friday, May 11, 2018 9:22 AM
> > > > To: dev@dpdk.org
> > > > Cc: Zhang, Qi Z <qi.z.zhang@intel.com>; Lu, Wenzhuo
> > > > <wenzhuo.lu@intel.com>; Wu, Yanglong <yanglong.wu@intel.com>
> > > > Subject: [dpdk-dev] [PATCH] ethdev: fix checking Rx/Tx queue
> > > > status
> > > >
> > > > Relax the check for queue setup, since some device may not update
> > > > queue states during dev_stop.
> > > >
> > > > Fixes: cac923cfea47 ("ethdev: support runtime queue setup")
> > > > Signed-off-by: Yanglong Wu <yanglong.wu@intel.com>
> > > > ---
> > > >  lib/librte_ethdev/rte_ethdev.c | 10 ++++++----
> > > >  1 file changed, 6 insertions(+), 4 deletions(-)
> > > >
> > > > diff --git a/lib/librte_ethdev/rte_ethdev.c
> > > > b/lib/librte_ethdev/rte_ethdev.c index a357ee09f..34379642a 100644
> > > > --- a/lib/librte_ethdev/rte_ethdev.c
> > > > +++ b/lib/librte_ethdev/rte_ethdev.c
> > > > @@ -1479,8 +1479,9 @@ rte_eth_rx_queue_setup(uint16_t port_id,
> > > uint16_t rx_queue_id,
> > > >  			RTE_ETH_DEV_CAPA_RUNTIME_RX_QUEUE_SETUP))
> > > >  		return -EBUSY;
> > > >
> > > > -	if (dev->data->rx_queue_state[rx_queue_id] !=
> > > > -		RTE_ETH_QUEUE_STATE_STOPPED)
> > > > +	if (dev->data->dev_started &&
> > > > +		(dev->data->rx_queue_state[rx_queue_id] !=
> > > > +			RTE_ETH_QUEUE_STATE_STOPPED))
> > > >  		return -EBUSY;
> > > >
> > > >  	rxq = dev->data->rx_queues;
> > > > @@ -1611,8 +1612,9 @@ rte_eth_tx_queue_setup(uint16_t port_id,
> > > uint16_t tx_queue_id,
> > > >  			RTE_ETH_DEV_CAPA_RUNTIME_TX_QUEUE_SETUP))
> > > >  		return -EBUSY;
> > > >
> > > > -	if (dev->data->tx_queue_state[tx_queue_id] !=
> > > > -		RTE_ETH_QUEUE_STATE_STOPPED)
> > > > +	if (dev->data->dev_started &&
> > > > +		(dev->data->tx_queue_state[tx_queue_id] !=
> > > > +			RTE_ETH_QUEUE_STATE_STOPPED))
> > > >  		return -EBUSY;
> > > >
> > > >  	txq = dev->data->tx_queues;
> > > > --
> > >
> > > That would break runtime queue setup.
> >
> > Em... would you explain more, I can't figure out why this break runtime
> queue setup so far.
> 
> Ah yes, it was me not reading code properly.
> So yep - you right  it wouldn't break things.
> 
> >
> > > Why not fix offending PMDs instead?
> >
> > Ixgbe, i40e have this issue, not sure what about others.
> > probably we should fix at rte_eth_dev_stop to save all PMD?
> 
> Probably yes, that's a good thing to do in long term anyway.

I'm thinking if it's better to move all queue state change into ethdev layer.
So there could be a patch to update queue states properly at dev_start/dev_stop/queue_start/queue_stop and maintainer help them self to cleanup PMD, and I think our proposed fix should be part of this.
But for now, can we just keep current simple fix?

Regards
Qi

> 
> >
> > >
> > > > 2.11.0
> 
> Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>

  reply	other threads:[~2018-05-11 12:34 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-11  8:22 Yanglong Wu
2018-05-11  8:39 ` Ananyev, Konstantin
2018-05-11  9:23   ` Zhang, Qi Z
2018-05-11  9:51     ` Ananyev, Konstantin
2018-05-11 12:34       ` Zhang, Qi Z [this message]
2018-05-11 12:52         ` Ananyev, Konstantin
2018-05-11 13:33           ` Zhang, Qi Z
2018-05-11 15:43       ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=039ED4275CED7440929022BC67E70611531B14E8@SHSMSX103.ccr.corp.intel.com \
    --to=qi.z.zhang@intel.com \
    --cc=dev@dpdk.org \
    --cc=konstantin.ananyev@intel.com \
    --cc=wenzhuo.lu@intel.com \
    --cc=yanglong.wu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).