From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id 64ED858C4; Thu, 17 May 2018 15:18:39 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 May 2018 06:18:38 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,410,1520924400"; d="scan'208";a="42031211" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by orsmga008.jf.intel.com with ESMTP; 17 May 2018 06:18:37 -0700 Received: from FMSMSX110.amr.corp.intel.com (10.18.116.10) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 17 May 2018 06:18:37 -0700 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by fmsmsx110.amr.corp.intel.com (10.18.116.10) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 17 May 2018 06:18:37 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.210]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.40]) with mapi id 14.03.0319.002; Thu, 17 May 2018 21:18:35 +0800 From: "Zhang, Qi Z" To: "dev@dpdk.org" CC: "Wu, Jingjing" , "Lu, Wenzhuo" , "Yang, Qiming" , "stable@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] net/ixgbe: fix dcb configuration issue Thread-Index: AQHT7aK/d/bjkRA6QEa4eQF51BjeR6Qz508Q Date: Thu, 17 May 2018 13:18:35 +0000 Message-ID: <039ED4275CED7440929022BC67E70611531B406F@SHSMSX103.ccr.corp.intel.com> References: <20180517132235.5343-1-qiming.yang@intel.com> In-Reply-To: <20180517132235.5343-1-qiming.yang@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiM2U4MTNjYTAtZjdmZC00ZWQyLTk0MTktODdkMDQ5ZWRlYmRkIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjIuNS4xOCIsIlRydXN0ZWRMYWJlbEhhc2giOiJcLzU3NDdoR0hGVjRqdWxHS2lCRU1UQUNnQmlqZGkrU3ZtR2srNjFIWHROUTVQZ1UzM3ZOYTBIYVwvVzFmQ2MyeXAifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.200.100 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] net/ixgbe: fix dcb configuration issue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 May 2018 13:18:40 -0000 Hi Qiming > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] > Sent: Thursday, May 17, 2018 9:23 PM > To: dev@dpdk.org > Cc: Wu, Jingjing ; Lu, Wenzhuo > ; Yang, Qiming ; > stable@dpdk.org > Subject: [dpdk-dev] [PATCH] net/ixgbe: fix dcb configuration issue >=20 > This patch removed unnecessary check in ixgbe_check_mq_mode, fixed > historical issue. >=20 > Fixes: 27b609cbd1c6 ("ethdev: move the multi-queue mode check to specific > drivers") > Cc: stable@dpdk.org >=20 > Signed-off-by: Qiming Yang > --- > drivers/net/ixgbe/ixgbe_ethdev.c | 37 ----------------------------------= --- > 1 file changed, 37 deletions(-) >=20 > diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c > b/drivers/net/ixgbe/ixgbe_ethdev.c > index f5006bc..9e3ae95 100644 > --- a/drivers/net/ixgbe/ixgbe_ethdev.c > +++ b/drivers/net/ixgbe/ixgbe_ethdev.c > @@ -2300,43 +2300,6 @@ ixgbe_check_mq_mode(struct rte_eth_dev *dev) > } > } >=20 > - /* For DCB mode check our configuration before we go further */ > - if (dev_conf->rxmode.mq_mode =3D=3D ETH_MQ_RX_DCB) { > - const struct rte_eth_dcb_rx_conf *conf; > - > - if (nb_rx_q !=3D IXGBE_DCB_NB_QUEUES) { > - PMD_INIT_LOG(ERR, "DCB selected, nb_rx_q !=3D %d.", > - IXGBE_DCB_NB_QUEUES); > - return -EINVAL; > - } > - conf =3D &dev_conf->rx_adv_conf.dcb_rx_conf; > - if (!(conf->nb_tcs =3D=3D ETH_4_TCS || > - conf->nb_tcs =3D=3D ETH_8_TCS)) { I guess, we should not remove all check, for nb_tcs, it still valid, right? > - PMD_INIT_LOG(ERR, "DCB selected, nb_tcs !=3D %d" > - " and nb_tcs !=3D %d.", > - ETH_4_TCS, ETH_8_TCS); > - return -EINVAL; > - } > - } > - > - if (dev_conf->txmode.mq_mode =3D=3D ETH_MQ_TX_DCB) { > - const struct rte_eth_dcb_tx_conf *conf; > - > - if (nb_tx_q !=3D IXGBE_DCB_NB_QUEUES) { > - PMD_INIT_LOG(ERR, "DCB, nb_tx_q !=3D %d.", > - IXGBE_DCB_NB_QUEUES); > - return -EINVAL; > - } > - conf =3D &dev_conf->tx_adv_conf.dcb_tx_conf; > - if (!(conf->nb_tcs =3D=3D ETH_4_TCS || > - conf->nb_tcs =3D=3D ETH_8_TCS)) { Same to rx. > - PMD_INIT_LOG(ERR, "DCB selected, nb_tcs !=3D %d" > - " and nb_tcs !=3D %d.", > - ETH_4_TCS, ETH_8_TCS); > - return -EINVAL; > - } > - } > - > /* > * When DCB/VT is off, maximum number of queues changes, > * except for 82598EB, which remains constant. > -- > 2.9.5