From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id F12897CD9 for ; Thu, 17 May 2018 17:49:26 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 May 2018 08:49:25 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,411,1520924400"; d="scan'208";a="229367471" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by fmsmga005.fm.intel.com with ESMTP; 17 May 2018 08:49:25 -0700 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 17 May 2018 08:49:25 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.210]) by SHSMSX104.ccr.corp.intel.com ([169.254.5.240]) with mapi id 14.03.0319.002; Thu, 17 May 2018 23:49:23 +0800 From: "Zhang, Qi Z" To: "Wu, Yanglong" , "dev@dpdk.org" CC: "Dai, Wei" Thread-Topic: [PATCH] net/ixgbe: fix VLAN strip setting fail for per port Thread-Index: AQHT7aQ05faS5gi7K0mgNOK8S+zBmKQ0ENbA Date: Thu, 17 May 2018 15:49:23 +0000 Message-ID: <039ED4275CED7440929022BC67E70611531B4283@SHSMSX103.ccr.corp.intel.com> References: <20180517055205.58766-1-yanglong.wu@intel.com> In-Reply-To: <20180517055205.58766-1-yanglong.wu@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiODE4YjI2ZDEtNGUxNC00OTE3LWEwOTktZjJjNjU1YzFiNDQ5IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjIuNS4xOCIsIlRydXN0ZWRMYWJlbEhhc2giOiI3V1d6bitLa3FqTk51Um5WakdjMGxjV1Q2dGxPYW5YSjVZYnZyUWgxRGtYSFd5QldBNUhZNVdZMkhtdFhQNkdtIn0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.200.100 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] net/ixgbe: fix VLAN strip setting fail for per port X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 May 2018 15:49:27 -0000 Hi Yanglong: > -----Original Message----- > From: Wu, Yanglong > Sent: Thursday, May 17, 2018 1:52 PM > To: dev@dpdk.org > Cc: Dai, Wei ; Zhang, Qi Z ; Wu, > Yanglong > Subject: [PATCH] net/ixgbe: fix VLAN strip setting fail for per port >=20 > VLAN-strip should be set by both per port and per queue >=20 > Fixes: 860a94d3c692 ("net/ixgbe: support VLAN strip per queue offloading = in > VF") > Signed-off-by: Yanglong Wu > --- > drivers/net/ixgbe/ixgbe_ethdev.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) >=20 > diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c > b/drivers/net/ixgbe/ixgbe_ethdev.c > index f5006bc94..f27e777fe 100644 > --- a/drivers/net/ixgbe/ixgbe_ethdev.c > +++ b/drivers/net/ixgbe/ixgbe_ethdev.c > @@ -5228,9 +5228,11 @@ ixgbevf_vlan_offload_set(struct rte_eth_dev *dev, > int mask) >=20 > /* VF function only support hw strip feature, others are not support */ > if (mask & ETH_VLAN_STRIP_MASK) { > + on =3D !!(dev->data->dev_conf.rxmode.offloads & > + DEV_RX_OFFLOAD_VLAN_STRIP); In ixgbe_rx_qeueu_setup, I saw rxq->offload is assigned by rx_conf->offload= s | dev->data->dev_conf.rxmode.offloads; So queue offload it already cover port offload, looks redundant here , coul= d give more explain why this is necessary? Regards Qi > for (i =3D 0; i < dev->data->nb_rx_queues; i++) { > rxq =3D dev->data->rx_queues[i]; > - on =3D !!(rxq->offloads & DEV_RX_OFFLOAD_VLAN_STRIP); > + on |=3D !!(rxq->offloads & DEV_RX_OFFLOAD_VLAN_STRIP); > ixgbevf_vlan_strip_queue_set(dev, i, on); > } > } > -- > 2.11.0