From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 9976DF985 for ; Sat, 19 May 2018 02:19:05 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 May 2018 17:19:04 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,416,1520924400"; d="scan'208";a="225480483" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by orsmga005.jf.intel.com with ESMTP; 18 May 2018 17:19:03 -0700 Received: from fmsmsx126.amr.corp.intel.com (10.18.125.43) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.319.2; Fri, 18 May 2018 17:19:03 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by FMSMSX126.amr.corp.intel.com (10.18.125.43) with Microsoft SMTP Server (TLS) id 14.3.319.2; Fri, 18 May 2018 17:19:03 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.210]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.179]) with mapi id 14.03.0319.002; Sat, 19 May 2018 08:19:01 +0800 From: "Zhang, Qi Z" To: "Dai, Wei" , "Lu, Wenzhuo" , "Ananyev, Konstantin" , "Wu, Yanglong" , "Yigit, Ferruh" CC: "dev@dpdk.org" Thread-Topic: [PATCH v4] net/ixgbe: config VLAN strip on the fly Thread-Index: AQHT7sU8Zt+1bic7a0m/KpktZ1tOf6Q2LPnQ Date: Sat, 19 May 2018 00:19:01 +0000 Message-ID: <039ED4275CED7440929022BC67E70611531B4AEF@SHSMSX103.ccr.corp.intel.com> References: <1526658192-23106-1-git-send-email-wei.dai@intel.com> <1526659710-24420-1-git-send-email-wei.dai@intel.com> In-Reply-To: <1526659710-24420-1-git-send-email-wei.dai@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMzAxZDI5NGYtNWRkOC00NWM5LWJkZDYtNGI0ZDY3MDMzMTk1IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiSlV5YmhHSGFucVFZa3VLQzBXbGYxS0t6aTFcL0tPZGdcLzI3VGlsRENUZVE2SUhESWNwc3VyaFlcL2l1ZTRpR0tsNiJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.200.100 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v4] net/ixgbe: config VLAN strip on the fly X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 19 May 2018 00:19:06 -0000 > -----Original Message----- > From: Dai, Wei > Sent: Saturday, May 19, 2018 12:09 AM > To: Lu, Wenzhuo ; Ananyev, Konstantin > ; Zhang, Qi Z ; Wu, > Yanglong ; Yigit, Ferruh > Cc: dev@dpdk.org; Dai, Wei > Subject: [PATCH v4] net/ixgbe: config VLAN strip on the fly >=20 > The old ixgbe_vlan_offload_set() is called by > rte_eth_dev_set_vlan_offload() which is meant to config VLAN > strip/filter/extend on all queues. > This old function is also called by rte_eth_dev_start()/ixgbe_dev_start() OK, I think this is what we missed in previous patch, good capture, thanks! > which need support per-queue VALN strip on only parts of queues. > So add new function ixgbe_vlan_offload_config() =3D old > ixgbe_vlan_offload_set(). > New ixgbe_vlan_offload_set =3D codes to align VLAN strip flags on all qu= eues > with port level setting + ixgbe_vlan_offload_configure(). >=20 > Signed-off-by: Wei Dai > Signed-off-by: Yanglong Wu Though the code can be improved to remove some redundant , but I think it's= not a big deal right now. BTW, I think we still need the fixed line, so it will be added during apply= . Fixes: 860a94d3c692 ("net/ixgbe: support VLAN strip per queue offloading in= VF") Acked-by: Qi Zhang