From: "Zhang, Qi Z" <qi.z.zhang@intel.com>
To: "Horton, Remy" <remy.horton@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "Yigit, Ferruh" <ferruh.yigit@intel.com>,
"Xing, Beilei" <beilei.xing@intel.com>,
"Zhang, Helin" <helin.zhang@intel.com>,
"Wu, Jingjing" <jingjing.wu@intel.com>
Subject: Re: [dpdk-dev] [PATCH v2] i40e: fix corruption of VF stats via port representor
Date: Sat, 19 May 2018 02:17:59 +0000 [thread overview]
Message-ID: <039ED4275CED7440929022BC67E70611531B4B7C@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <20180518114948.24564-1-remy.horton@intel.com>
> -----Original Message-----
> From: Horton, Remy
> Sent: Friday, May 18, 2018 7:50 PM
> To: dev@dpdk.org
> Cc: Yigit, Ferruh <ferruh.yigit@intel.com>; Zhang, Qi Z <qi.z.zhang@intel.com>;
> Xing, Beilei <beilei.xing@intel.com>; Zhang, Helin <helin.zhang@intel.com>;
> Wu, Jingjing <jingjing.wu@intel.com>
> Subject: [PATCH v2] i40e: fix corruption of VF stats via port representor
>
> The resetting of stats on a VF involves the setting of an offset that is subtracted
> from future calls, rather zeroing of counters.
> However doing a stats reset on the port representor was also adjusting the
> values forwarded to the VF, which had the effect of corrupting the VF's
> counters. The fix is for the port representor to maintain its own stats offset, so
> the port representor and VF maintain independently-resettable counters.
>
> Fixes: e0cb96204b71 ("net/i40e: add support for representor ports")
>
> Signed-off-by: Remy Horton <remy.horton@intel.com>
Title prefix should be "net/i40e", could be fix during apply
Acked-by: Qi Zhang <qi.z.zhang@intel.com>
next prev parent reply other threads:[~2018-05-19 2:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-18 7:59 [dpdk-dev] [PATCH] net/i40e: " Remy Horton
2018-05-18 11:48 ` Remy Horton
2018-05-18 11:49 ` [dpdk-dev] [PATCH v2] i40e: " Remy Horton
2018-05-19 2:17 ` Zhang, Qi Z [this message]
2018-05-21 1:17 ` Zhang, Helin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=039ED4275CED7440929022BC67E70611531B4B7C@SHSMSX103.ccr.corp.intel.com \
--to=qi.z.zhang@intel.com \
--cc=beilei.xing@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=helin.zhang@intel.com \
--cc=jingjing.wu@intel.com \
--cc=remy.horton@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).