From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 36C38D142 for ; Sat, 19 May 2018 04:18:03 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 May 2018 19:18:02 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,417,1520924400"; d="scan'208";a="40536260" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by fmsmga007.fm.intel.com with ESMTP; 18 May 2018 19:18:02 -0700 Received: from fmsmsx158.amr.corp.intel.com (10.18.116.75) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.319.2; Fri, 18 May 2018 19:18:02 -0700 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by fmsmsx158.amr.corp.intel.com (10.18.116.75) with Microsoft SMTP Server (TLS) id 14.3.319.2; Fri, 18 May 2018 19:18:02 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.210]) by SHSMSX104.ccr.corp.intel.com ([169.254.5.240]) with mapi id 14.03.0319.002; Sat, 19 May 2018 10:18:00 +0800 From: "Zhang, Qi Z" To: "Horton, Remy" , "dev@dpdk.org" CC: "Yigit, Ferruh" , "Xing, Beilei" , "Zhang, Helin" , "Wu, Jingjing" Thread-Topic: [PATCH v2] i40e: fix corruption of VF stats via port representor Thread-Index: AQHT7p5VVbaq8z6qnkexTsjGbJE7mqQ2UPYg Date: Sat, 19 May 2018 02:17:59 +0000 Message-ID: <039ED4275CED7440929022BC67E70611531B4B7C@SHSMSX103.ccr.corp.intel.com> References: <20180518075948.3177-1-remy.horton@intel.com> <20180518114948.24564-1-remy.horton@intel.com> In-Reply-To: <20180518114948.24564-1-remy.horton@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZjU0ZDg0N2ItZmNlMy00MzNlLTk5MzctMmNlZTVmY2FhMzA4IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiOUJPNHRTb1Z1aGFiTjR6amlJeW5UMFB4V1dMWHN3V2llZ0VcL240NkdQNkYzczdXRzZXQWZKNTdNVXoyWVN3QW8ifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.200.100 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2] i40e: fix corruption of VF stats via port representor X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 19 May 2018 02:18:04 -0000 > -----Original Message----- > From: Horton, Remy > Sent: Friday, May 18, 2018 7:50 PM > To: dev@dpdk.org > Cc: Yigit, Ferruh ; Zhang, Qi Z ; > Xing, Beilei ; Zhang, Helin ; > Wu, Jingjing > Subject: [PATCH v2] i40e: fix corruption of VF stats via port representor >=20 > The resetting of stats on a VF involves the setting of an offset that is = subtracted > from future calls, rather zeroing of counters. > However doing a stats reset on the port representor was also adjusting th= e > values forwarded to the VF, which had the effect of corrupting the VF's > counters. The fix is for the port representor to maintain its own stats o= ffset, so > the port representor and VF maintain independently-resettable counters. >=20 > Fixes: e0cb96204b71 ("net/i40e: add support for representor ports") >=20 > Signed-off-by: Remy Horton Title prefix should be "net/i40e", could be fix during apply Acked-by: Qi Zhang =20