From: "Zhang, Qi Z" <qi.z.zhang@intel.com>
To: "Xing, Beilei" <beilei.xing@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "Guo, Jia" <jia.guo@intel.com>
Subject: Re: [dpdk-dev] [PATCH] net/i40e: fix shifts of 32-bit value
Date: Thu, 21 Jun 2018 14:19:59 +0000 [thread overview]
Message-ID: <039ED4275CED7440929022BC67E706115323B4FE@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <1527061606-10172-1-git-send-email-beilei.xing@intel.com>
> -----Original Message-----
> From: Xing, Beilei
> Sent: Wednesday, May 23, 2018 3:47 PM
> To: Zhang, Qi Z <qi.z.zhang@intel.com>
> Cc: dev@dpdk.org; Guo, Jia <jia.guo@intel.com>
> Subject: [PATCH] net/i40e: fix shifts of 32-bit value
>
> Cppcheck reports following error,
> (error) Shifting 32-bit value by 36 bits is undefined behaviour
>
> According to datasheet, there's PHY type and PHY type extension in setting PHY
> config command, should exclude PHY type extension when setting PHY type.
>
> Fixes: 1bb8f661168d ("net/i40e: fix link down and negotiation")
>
> Signed-off-by: Beilei Xing <beilei.xing@intel.com>
Acked-by: Qi Zhang <qi.z.zhang@intel.com>
Applied to dpdk-next-net-intel
Thanks!
Qi
prev parent reply other threads:[~2018-06-21 14:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-23 7:46 Beilei Xing
2018-05-23 15:49 ` Ferruh Yigit
2018-06-21 14:19 ` Zhang, Qi Z [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=039ED4275CED7440929022BC67E706115323B4FE@SHSMSX103.ccr.corp.intel.com \
--to=qi.z.zhang@intel.com \
--cc=beilei.xing@intel.com \
--cc=dev@dpdk.org \
--cc=jia.guo@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).