From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 781E31B52B for ; Thu, 21 Jun 2018 16:20:02 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 Jun 2018 07:20:01 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,252,1526367600"; d="scan'208";a="239109225" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by fmsmga005.fm.intel.com with ESMTP; 21 Jun 2018 07:20:01 -0700 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 21 Jun 2018 07:20:01 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.51]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.82]) with mapi id 14.03.0319.002; Thu, 21 Jun 2018 22:19:59 +0800 From: "Zhang, Qi Z" To: "Xing, Beilei" CC: "dev@dpdk.org" , "Guo, Jia" Thread-Topic: [PATCH] net/i40e: fix shifts of 32-bit value Thread-Index: AQHT8mor6yPKOtKJF0GfGk2DXJfxpqRq8LOA Date: Thu, 21 Jun 2018 14:19:59 +0000 Message-ID: <039ED4275CED7440929022BC67E706115323B4FE@SHSMSX103.ccr.corp.intel.com> References: <1527061606-10172-1-git-send-email-beilei.xing@intel.com> In-Reply-To: <1527061606-10172-1-git-send-email-beilei.xing@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiODJmMDQxNTYtODBhNy00YWFjLTkwNjEtNDE0NjdiZmQyOGI0IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiek9LcEZaVWRVK2pjNjBvaGJNXC9XeXhqTFE1b3d4V3hrR2ZjWUVPOFNCcDEwZFNNOVwvczJHSDFHNWVraWJSZHlpIn0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.200.100 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] net/i40e: fix shifts of 32-bit value X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Jun 2018 14:20:03 -0000 > -----Original Message----- > From: Xing, Beilei > Sent: Wednesday, May 23, 2018 3:47 PM > To: Zhang, Qi Z > Cc: dev@dpdk.org; Guo, Jia > Subject: [PATCH] net/i40e: fix shifts of 32-bit value >=20 > Cppcheck reports following error, > (error) Shifting 32-bit value by 36 bits is undefined behaviour >=20 > According to datasheet, there's PHY type and PHY type extension in settin= g PHY > config command, should exclude PHY type extension when setting PHY type. >=20 > Fixes: 1bb8f661168d ("net/i40e: fix link down and negotiation") >=20 > Signed-off-by: Beilei Xing Acked-by: Qi Zhang Applied to dpdk-next-net-intel Thanks! Qi