DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] i40evf: don't reset device_info data
@ 2018-06-06 20:31 Damjan Marion
  2018-06-15 14:05 ` Zhang, Qi Z
  0 siblings, 1 reply; 3+ messages in thread
From: Damjan Marion @ 2018-06-06 20:31 UTC (permalink / raw)
  To: dev; +Cc: Damjan Marion

At this point valid data is already set by rte_eth_get_device_info.
device field becomes zero and consumer is not able to retrieve pci data.

Signed-off-by: Damjan Marion <damarion@cisco.com>
---
 drivers/net/i40e/i40e_ethdev_vf.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/net/i40e/i40e_ethdev_vf.c b/drivers/net/i40e/i40e_ethdev_vf.c
index 804e44530..86b38d202 100644
--- a/drivers/net/i40e/i40e_ethdev_vf.c
+++ b/drivers/net/i40e/i40e_ethdev_vf.c
@@ -2182,7 +2182,6 @@ i40evf_dev_info_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info)
 {
 	struct i40e_vf *vf = I40EVF_DEV_PRIVATE_TO_VF(dev->data->dev_private);
 
-	memset(dev_info, 0, sizeof(*dev_info));
 	dev_info->max_rx_queues = vf->vsi_res->num_queue_pairs;
 	dev_info->max_tx_queues = vf->vsi_res->num_queue_pairs;
 	dev_info->min_rx_bufsize = I40E_BUF_SIZE_MIN;
-- 
2.17.1

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH] i40evf: don't reset device_info data
  2018-06-06 20:31 [dpdk-dev] [PATCH] i40evf: don't reset device_info data Damjan Marion
@ 2018-06-15 14:05 ` Zhang, Qi Z
  2018-06-22 11:59   ` Zhang, Qi Z
  0 siblings, 1 reply; 3+ messages in thread
From: Zhang, Qi Z @ 2018-06-15 14:05 UTC (permalink / raw)
  To: Damjan Marion, dev



> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Damjan Marion
> Sent: Thursday, June 7, 2018 4:31 AM
> To: dev@dpdk.org
> Cc: Damjan Marion <damarion@cisco.com>
> Subject: [dpdk-dev] [PATCH] i40evf: don't reset device_info data
> 
> At this point valid data is already set by rte_eth_get_device_info.
> device field becomes zero and consumer is not able to retrieve pci data.
> 
> Signed-off-by: Damjan Marion <damarion@cisco.com>

Acked-by: Qi Zhang <qi.z.zhang@intel.com>

Will add below fix line when apply
Fixes: 4861cde46116 ("i40e: new poll mode driver")

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH] i40evf: don't reset device_info data
  2018-06-15 14:05 ` Zhang, Qi Z
@ 2018-06-22 11:59   ` Zhang, Qi Z
  0 siblings, 0 replies; 3+ messages in thread
From: Zhang, Qi Z @ 2018-06-22 11:59 UTC (permalink / raw)
  To: 'Damjan Marion', 'dev@dpdk.org'



> -----Original Message-----
> From: Zhang, Qi Z
> Sent: Friday, June 15, 2018 10:05 PM
> To: Damjan Marion <damarion@cisco.com>; dev@dpdk.org
> Subject: RE: [dpdk-dev] [PATCH] i40evf: don't reset device_info data
> 
> 
> 
> > -----Original Message-----
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Damjan Marion
> > Sent: Thursday, June 7, 2018 4:31 AM
> > To: dev@dpdk.org
> > Cc: Damjan Marion <damarion@cisco.com>
> > Subject: [dpdk-dev] [PATCH] i40evf: don't reset device_info data
> >
> > At this point valid data is already set by rte_eth_get_device_info.
> > device field becomes zero and consumer is not able to retrieve pci data.
> >
> > Signed-off-by: Damjan Marion <damarion@cisco.com>
> 
> Acked-by: Qi Zhang <qi.z.zhang@intel.com>
> 
> Will add below fix line when apply
> Fixes: 4861cde46116 ("i40e: new poll mode driver")

Applied to dpdk-next-net-intel

Thanks!
Qi

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-06-22 11:59 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-06-06 20:31 [dpdk-dev] [PATCH] i40evf: don't reset device_info data Damjan Marion
2018-06-15 14:05 ` Zhang, Qi Z
2018-06-22 11:59   ` Zhang, Qi Z

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).