From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 4A2BB1B4E9 for ; Fri, 29 Jun 2018 13:44:04 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 29 Jun 2018 04:44:03 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,285,1526367600"; d="scan'208";a="52847389" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga007.jf.intel.com with ESMTP; 29 Jun 2018 04:43:53 -0700 Received: from fmsmsx126.amr.corp.intel.com (10.18.125.43) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.319.2; Fri, 29 Jun 2018 04:43:52 -0700 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by FMSMSX126.amr.corp.intel.com (10.18.125.43) with Microsoft SMTP Server (TLS) id 14.3.319.2; Fri, 29 Jun 2018 04:43:52 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.51]) by shsmsx102.ccr.corp.intel.com ([169.254.2.223]) with mapi id 14.03.0319.002; Fri, 29 Jun 2018 19:43:50 +0800 From: "Zhang, Qi Z" To: "Xing, Beilei" CC: "Wu, Jingjing" , "Yu, De" , "dev@dpdk.org" Thread-Topic: [PATCH v3] net/i40e: remove VF interrupt handler Thread-Index: AQHUDhjazgj0qhQu8UmAPB3kewjM2qR0YVMAgAK/K7A= Date: Fri, 29 Jun 2018 11:43:49 +0000 Message-ID: <039ED4275CED7440929022BC67E7061153241B40@SHSMSX103.ccr.corp.intel.com> References: <20180627131527.46190-1-qi.z.zhang@intel.com> <94479800C636CB44BD422CB454846E01321D03EA@SHSMSX101.ccr.corp.intel.com> In-Reply-To: <94479800C636CB44BD422CB454846E01321D03EA@SHSMSX101.ccr.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZTBjOTA1OTEtODY3ZS00ODMzLWI3MWYtYmNiZDgzNTMxMmZhIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiejJDNFBYZEtVTmlPQnhETndNZnZUa20zQTdYWHF5Z0xCcE9XODVpZzJqNEhVU0F3TmFtWnZ6OEROdndZSG5xTSJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.200.100 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3] net/i40e: remove VF interrupt handler X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 29 Jun 2018 11:44:05 -0000 > -----Original Message----- > From: Xing, Beilei > Sent: Thursday, June 28, 2018 9:46 AM > To: Zhang, Qi Z > Cc: Wu, Jingjing ; Yu, De ; > dev@dpdk.org > Subject: RE: [PATCH v3] net/i40e: remove VF interrupt handler >=20 >=20 >=20 > > -----Original Message----- > > From: Zhang, Qi Z > > Sent: Wednesday, June 27, 2018 9:15 PM > > To: Xing, Beilei > > Cc: Wu, Jingjing ; Yu, De ; > > dev@dpdk.org; Zhang, Qi Z > > Subject: [PATCH v3] net/i40e: remove VF interrupt handler > > > > For i40evf, internal rx interrupt and adminq interrupt share the same > > source, that cause a lot cpu cycles be wasted on interrupt handler on > > rx path. This is complained by customers which require low latency > > (when set I40E_ITR_INTERVAL to small value), but have to be sufferred > > by tremendous interrupts handling that eat significant CPU resources. > > > > The patch disable pci interrupt and remove the interrupt handler, > > replace it with a low frequency (50ms) interrupt polling daemon which > > is implemented by registering a alarm callback periodly, this save CPU > > time significently: On a typical x86 server with 2.1GHz CPU, with low > > latency configure (32us) we saw CPU usage from top commmand reduced > > from 20% to 0% on management core in testpmd). > > > > Also with the new method we can remove compile option: > > I40E_ITR_INTERVAL which is used to balance between low latency and low > > CPU usage previously. > > Now we don't need it since we can reach both at same time. > > > > Suggested-by: Jingjing Wu > > Signed-off-by: Qi Zhang >=20 > Acked-by: Beilei Xing Applied to dpdk-next-net-intel. Thanks! Qi