* Re: [dpdk-dev] [PATCH] net/i40e: fix tx queue setup after stop queue
2018-07-10 10:37 [dpdk-dev] [PATCH] net/i40e: fix tx queue setup after stop queue Shaopeng He
@ 2018-07-10 8:09 ` Zhang, Qi Z
2018-07-25 18:19 ` Kevin Traynor
1 sibling, 0 replies; 3+ messages in thread
From: Zhang, Qi Z @ 2018-07-10 8:09 UTC (permalink / raw)
To: He, Shaopeng, dev
> -----Original Message-----
> From: He, Shaopeng
> Sent: Tuesday, July 10, 2018 6:37 PM
> To: dev@dpdk.org
> Cc: Zhang, Qi Z <qi.z.zhang@intel.com>; He, Shaopeng
> <shaopeng.he@intel.com>
> Subject: [PATCH] net/i40e: fix tx queue setup after stop queue
tx -> Tx in title
>
> Currently, i40e_dev_tx_queue_setup_runtime checks simple tx and treats
> mbuf fast free offloading as No-simple, which is classified as simple tx in
> i40e_set_tx_function_flag. This inconsistent behavior causes tx queue setup
> fail after queue was stopped. This patch fixes this bug.
>
> Fixes: 399421100e08 ("net/i40e: fix missing mbuf fast free offload")
>
> Signed-off-by: Shaopeng He <shaopeng.he@intel.com>
Acked-by: Qi Zhang <qi.z.zhang@intel.com>
Applied to dpdk-next-net-intel.
Thanks!
Qi
^ permalink raw reply [flat|nested] 3+ messages in thread
* [dpdk-dev] [PATCH] net/i40e: fix tx queue setup after stop queue
@ 2018-07-10 10:37 Shaopeng He
2018-07-10 8:09 ` Zhang, Qi Z
2018-07-25 18:19 ` Kevin Traynor
0 siblings, 2 replies; 3+ messages in thread
From: Shaopeng He @ 2018-07-10 10:37 UTC (permalink / raw)
To: dev; +Cc: qi.z.zhang, Shaopeng He
Currently, i40e_dev_tx_queue_setup_runtime checks simple tx and treats
mbuf fast free offloading as No-simple, which is classified as simple tx
in i40e_set_tx_function_flag. This inconsistent behavior causes tx queue
setup fail after queue was stopped. This patch fixes this bug.
Fixes: 399421100e08 ("net/i40e: fix missing mbuf fast free offload")
Signed-off-by: Shaopeng He <shaopeng.he@intel.com>
---
drivers/net/i40e/i40e_rxtx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/i40e/i40e_rxtx.c b/drivers/net/i40e/i40e_rxtx.c
index 6032d5541..2bbb82fc3 100644
--- a/drivers/net/i40e/i40e_rxtx.c
+++ b/drivers/net/i40e/i40e_rxtx.c
@@ -2087,7 +2087,7 @@ i40e_dev_tx_queue_setup_runtime(struct rte_eth_dev *dev,
}
/* check simple tx conflict */
if (ad->tx_simple_allowed) {
- if (txq->offloads != 0 ||
+ if ((txq->offloads & ~DEV_TX_OFFLOAD_MBUF_FAST_FREE) != 0 ||
txq->tx_rs_thresh < RTE_PMD_I40E_TX_MAX_BURST) {
PMD_DRV_LOG(ERR, "No-simple tx is required.");
return -EINVAL;
--
2.17.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] net/i40e: fix tx queue setup after stop queue
2018-07-10 10:37 [dpdk-dev] [PATCH] net/i40e: fix tx queue setup after stop queue Shaopeng He
2018-07-10 8:09 ` Zhang, Qi Z
@ 2018-07-25 18:19 ` Kevin Traynor
1 sibling, 0 replies; 3+ messages in thread
From: Kevin Traynor @ 2018-07-25 18:19 UTC (permalink / raw)
To: Shaopeng He, dev; +Cc: qi.z.zhang, stable
On 07/10/2018 11:37 AM, Shaopeng He wrote:
> Currently, i40e_dev_tx_queue_setup_runtime checks simple tx and treats
> mbuf fast free offloading as No-simple, which is classified as simple tx
> in i40e_set_tx_function_flag. This inconsistent behavior causes tx queue
> setup fail after queue was stopped. This patch fixes this bug.
>
> Fixes: 399421100e08 ("net/i40e: fix missing mbuf fast free offload")
Is it missing Cc: stable@dpdk.org tag for 18.05 stable branch?
>
> Signed-off-by: Shaopeng He <shaopeng.he@intel.com>
> ---
> drivers/net/i40e/i40e_rxtx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/i40e/i40e_rxtx.c b/drivers/net/i40e/i40e_rxtx.c
> index 6032d5541..2bbb82fc3 100644
> --- a/drivers/net/i40e/i40e_rxtx.c
> +++ b/drivers/net/i40e/i40e_rxtx.c
> @@ -2087,7 +2087,7 @@ i40e_dev_tx_queue_setup_runtime(struct rte_eth_dev *dev,
> }
> /* check simple tx conflict */
> if (ad->tx_simple_allowed) {
> - if (txq->offloads != 0 ||
> + if ((txq->offloads & ~DEV_TX_OFFLOAD_MBUF_FAST_FREE) != 0 ||
> txq->tx_rs_thresh < RTE_PMD_I40E_TX_MAX_BURST) {
> PMD_DRV_LOG(ERR, "No-simple tx is required.");
> return -EINVAL;
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-07-25 18:19 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-10 10:37 [dpdk-dev] [PATCH] net/i40e: fix tx queue setup after stop queue Shaopeng He
2018-07-10 8:09 ` Zhang, Qi Z
2018-07-25 18:19 ` Kevin Traynor
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).