From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 8D3034B4B for ; Tue, 10 Jul 2018 11:10:52 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Jul 2018 02:10:51 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,333,1526367600"; d="scan'208";a="65768759" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga003.jf.intel.com with ESMTP; 10 Jul 2018 02:10:51 -0700 Received: from fmsmsx115.amr.corp.intel.com (10.18.116.19) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 10 Jul 2018 02:10:48 -0700 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by fmsmsx115.amr.corp.intel.com (10.18.116.19) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 10 Jul 2018 02:10:48 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.100]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.57]) with mapi id 14.03.0319.002; Tue, 10 Jul 2018 17:10:46 +0800 From: "Zhang, Qi Z" To: "Guo, Jia" , "stephen@networkplumber.org" , "Richardson, Bruce" , "Yigit, Ferruh" , "Ananyev, Konstantin" , "gaetan.rivet@6wind.com" , "Wu, Jingjing" , "thomas@monjalon.net" , "motih@mellanox.com" , "matan@mellanox.com" , "Van Haaren, Harry" , "He, Shaopeng" , "Iremonger, Bernard" , "arybchenko@solarflare.com" , "Lu, Wenzhuo" CC: "jblunck@infradead.org" , "shreyansh.jain@nxp.com" , "dev@dpdk.org" , "Zhang, Helin" Thread-Topic: [PATCH v3 1/4] ethdev: Add eal device event callback Thread-Index: AQHUF3rLH2PSE2VD8kSd8mu2Ei1K4KSIK2Tw Date: Tue, 10 Jul 2018 09:10:46 +0000 Message-ID: <039ED4275CED7440929022BC67E7061153257D49@SHSMSX103.ccr.corp.intel.com> References: <1530787185-5915-1-git-send-email-jia.guo@intel.com> <1531136777-9815-1-git-send-email-jia.guo@intel.com> <1531136777-9815-2-git-send-email-jia.guo@intel.com> In-Reply-To: <1531136777-9815-2-git-send-email-jia.guo@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiN2E4ZmUxNGItZDMyZS00YWExLTg0Y2MtNzY2Zjc1NzgyOWIyIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiVkNueVNsWkxtV3orZXpPN2FoYTNsaER1TG80SVwvVks5V25QRVpZNTJCSklYWEpUK25XejVoODVwOXFmQ0JtRGQifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.200.100 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3 1/4] ethdev: Add eal device event callback X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Jul 2018 09:10:54 -0000 Hi Jeff: > -----Original Message----- > From: Guo, Jia > Sent: Monday, July 9, 2018 7:46 PM > To: stephen@networkplumber.org; Richardson, Bruce > ; Yigit, Ferruh ; > Ananyev, Konstantin ; > gaetan.rivet@6wind.com; Wu, Jingjing ; > thomas@monjalon.net; motih@mellanox.com; matan@mellanox.com; Van > Haaren, Harry ; Zhang, Qi Z > ; He, Shaopeng ; Iremonger, > Bernard ; arybchenko@solarflare.com; Lu, > Wenzhuo > Cc: jblunck@infradead.org; shreyansh.jain@nxp.com; dev@dpdk.org; Guo, Jia > ; Zhang, Helin > Subject: [PATCH v3 1/4] ethdev: Add eal device event callback >=20 > Implement a eal device event callback "rte_eth_dev_event_callback" > in ethdev, it could let pmd driver have chance to manage the eal device e= vent, > such as process hotplug event. >=20 > Signed-off-by: Jeff Guo > --- <...> >=20 > /** > + * @warning > + * @b EXPERIMENTAL: this API may change without prior notice. > + * > + * Implement a rte eth eal device event callbacks for the specific devic= e. > + * > + * @param device_name > + * Pointer to the name of the rte device. > + * @param event > + * Eal device event type. > + * @param ret_param > + * To pass data back to user application. > + * > + * @return > + * void > + */ > +void __rte_experimental > +rte_eth_dev_event_callback(char *device_name, > + enum rte_dev_event_type event, void *cb_arg); I don't think we should expose the callback function to PMD directly It should be a function like rte_eth_dev_event_callback_register(struct rte= _ethdev *dev) which looks more like an ethdev help API for drivers. And inside the function , we do the rte_dev_event_callback_register ... And rte_eth_dev_event_callback should be rename to eth_dev_event_callback a= s a static function. Regards Qi > + > +/** > * @internal Executes all the user application registered callbacks for > * the specific device. It is for DPDK internal user only. User > * application should not call it directly. > -- > 2.7.4