From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id CDFB31B3A7; Tue, 10 Jul 2018 13:58:19 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Jul 2018 04:58:18 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,334,1526367600"; d="scan'208";a="56507296" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga006.jf.intel.com with ESMTP; 10 Jul 2018 04:58:18 -0700 Received: from fmsmsx113.amr.corp.intel.com (10.18.116.7) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 10 Jul 2018 04:58:18 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by FMSMSX113.amr.corp.intel.com (10.18.116.7) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 10 Jul 2018 04:58:18 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.100]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.17]) with mapi id 14.03.0319.002; Tue, 10 Jul 2018 19:58:16 +0800 From: "Zhang, Qi Z" To: "Li, Xiaoyun" CC: "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [PATCH v2] net/i40e: fix link speed issue Thread-Index: AQHUGDKtUsUQQAXo20mp8CTyycdO0qSHquWAgACu/1A= Date: Tue, 10 Jul 2018 11:58:16 +0000 Message-ID: <039ED4275CED7440929022BC67E7061153257E9F@SHSMSX103.ccr.corp.intel.com> References: <1530508681-50504-1-git-send-email-xiaoyun.li@intel.com> <1531215055-14795-1-git-send-email-xiaoyun.li@intel.com> <1531215055-14795-2-git-send-email-xiaoyun.li@intel.com> In-Reply-To: <1531215055-14795-2-git-send-email-xiaoyun.li@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiY2IzNjFkODgtN2QwYi00NzE3LTljMzQtYzZlZDA5MDMxNDEwIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiNm9JQ0pIRnZXeXFQd2poV3ZvaXJpckdCaXJHcnBFd0s3V25sV3JWOVVldkpJc245TlVTOVJsUW5IMVZUbVRiRCJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.200.100 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2] net/i40e: fix link speed issue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Jul 2018 11:58:20 -0000 > -----Original Message----- > From: Li, Xiaoyun > Sent: Tuesday, July 10, 2018 5:31 PM > To: Zhang, Qi Z > Cc: dev@dpdk.org; Li, Xiaoyun ; stable@dpdk.org > Subject: [PATCH v2] net/i40e: fix link speed issue >=20 > When link needs to go up, I40E_AQ_PHY_AN_ENABLED is always be set in > DPDK. > So all speeds are always set. This causes speed config never works. >=20 > This patch fixes this issue and only allows to set available speeds. If l= ink needs > to go up and speed setting is not supported, it will print warning and se= t > default available speeds. And when link needs to go down, link speed fiel= d > should be set to non-zero to avoid link down issue when binding back to k= ernel > driver. >=20 > Fixes: ca7e599d4506 ("net/i40e: fix link management") > Fixes: 1bb8f661168d ("net/i40e: fix link down and negotiation") > Cc: stable@dpdk.org >=20 > Signed-off-by: Xiaoyun Li Acked-by: Qi Zhang Applied to dpdk-next-net-intel. Thanks! Qi