From: "Zhang, Qi Z" <qi.z.zhang@intel.com>
To: "Horton, Remy" <remy.horton@intel.com>
Cc: "Lu, Wenzhuo" <wenzhuo.lu@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2] net/ixgbe: fix missing NULL point check
Date: Thu, 19 Jul 2018 12:35:37 +0000 [thread overview]
Message-ID: <039ED4275CED7440929022BC67E706115325C685@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <20180716124704.212776-1-qi.z.zhang@intel.com>
Hi Remy:
Would you mind to give an ack for this patch if no more issue, so I can merge to dpdk-next-net-intel.
Thanks
Qi
> -----Original Message-----
> From: Zhang, Qi Z
> Sent: Monday, July 16, 2018 8:47 PM
> To: Horton, Remy <remy.horton@intel.com>
> Cc: Lu, Wenzhuo <wenzhuo.lu@intel.com>; dev@dpdk.org; Zhang, Qi Z
> <qi.z.zhang@intel.com>; stable@dpdk.org
> Subject: [PATCH v2] net/ixgbe: fix missing NULL point check
>
> Add missing NULL point check inside ixgbe_pf_host_uninit, or it may cause
> segment fault when detaching a device.
>
> Fixes: cf80ba6e2038 ("net/ixgbe: add support for representor ports")
> Cc: stable@dpdk.org
>
> Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
> ---
>
> v2: rebase
>
> drivers/net/ixgbe/ixgbe_pf.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/ixgbe/ixgbe_pf.c b/drivers/net/ixgbe/ixgbe_pf.c index
> c381acf44..4b833ffab 100644
> --- a/drivers/net/ixgbe/ixgbe_pf.c
> +++ b/drivers/net/ixgbe/ixgbe_pf.c
> @@ -128,8 +128,6 @@ void ixgbe_pf_host_uninit(struct rte_eth_dev
> *eth_dev)
>
> PMD_INIT_FUNC_TRACE();
>
> - vfinfo =
> IXGBE_DEV_PRIVATE_TO_P_VFDATA(eth_dev->data->dev_private);
> -
> RTE_ETH_DEV_SRIOV(eth_dev).active = 0;
> RTE_ETH_DEV_SRIOV(eth_dev).nb_q_per_pool = 0;
> RTE_ETH_DEV_SRIOV(eth_dev).def_vmdq_idx = 0; @@ -139,6 +137,10
> @@ void ixgbe_pf_host_uninit(struct rte_eth_dev *eth_dev)
> if (vf_num == 0)
> return;
>
> + vfinfo =
> IXGBE_DEV_PRIVATE_TO_P_VFDATA(eth_dev->data->dev_private);
> + if (*vfinfo == NULL)
> + return;
> +
> ret = rte_eth_switch_domain_free((*vfinfo)->switch_domain_id);
> if (ret)
> PMD_INIT_LOG(WARNING, "failed to free switch domain: %d", ret);
> --
> 2.13.6
next prev parent reply other threads:[~2018-07-19 12:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-16 12:47 Qi Zhang
2018-07-19 12:35 ` Zhang, Qi Z [this message]
2018-07-19 12:41 ` Remy Horton
2018-07-19 12:46 ` Zhang, Qi Z
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=039ED4275CED7440929022BC67E706115325C685@SHSMSX103.ccr.corp.intel.com \
--to=qi.z.zhang@intel.com \
--cc=dev@dpdk.org \
--cc=remy.horton@intel.com \
--cc=stable@dpdk.org \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).