From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 680F937A2; Thu, 19 Jul 2018 14:35:41 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Jul 2018 05:35:40 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,374,1526367600"; d="scan'208";a="217283368" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga004.jf.intel.com with ESMTP; 19 Jul 2018 05:35:39 -0700 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 19 Jul 2018 05:35:39 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.100]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.57]) with mapi id 14.03.0319.002; Thu, 19 Jul 2018 20:35:37 +0800 From: "Zhang, Qi Z" To: "Horton, Remy" CC: "Lu, Wenzhuo" , "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [PATCH v2] net/ixgbe: fix missing NULL point check Thread-Index: AQHUHQMG6nmNCtP3OEyZbZHKF/t/waSWf7gQ Date: Thu, 19 Jul 2018 12:35:37 +0000 Message-ID: <039ED4275CED7440929022BC67E706115325C685@SHSMSX103.ccr.corp.intel.com> References: <20180716124704.212776-1-qi.z.zhang@intel.com> In-Reply-To: <20180716124704.212776-1-qi.z.zhang@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNTU4Y2FlNjAtMTUxMS00NzU2LWJkNzMtMjliZmJhZGM5NjY5IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiRkN4TE94aEMrSkxhWHIxeG1HdmsrQndpMTdPN3lXc3V0Rk1PZ3NPMzk2NnJKMjY3SFZCMlRpZkFNS1JXMERRVCJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.200.100 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2] net/ixgbe: fix missing NULL point check X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Jul 2018 12:35:42 -0000 Hi Remy: Would you mind to give an ack for this patch if no more issue, so I can me= rge to dpdk-next-net-intel. Thanks Qi > -----Original Message----- > From: Zhang, Qi Z > Sent: Monday, July 16, 2018 8:47 PM > To: Horton, Remy > Cc: Lu, Wenzhuo ; dev@dpdk.org; Zhang, Qi Z > ; stable@dpdk.org > Subject: [PATCH v2] net/ixgbe: fix missing NULL point check >=20 > Add missing NULL point check inside ixgbe_pf_host_uninit, or it may cause > segment fault when detaching a device. >=20 > Fixes: cf80ba6e2038 ("net/ixgbe: add support for representor ports") > Cc: stable@dpdk.org >=20 > Signed-off-by: Qi Zhang > --- >=20 > v2: rebase >=20 > drivers/net/ixgbe/ixgbe_pf.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) >=20 > diff --git a/drivers/net/ixgbe/ixgbe_pf.c b/drivers/net/ixgbe/ixgbe_pf.c = index > c381acf44..4b833ffab 100644 > --- a/drivers/net/ixgbe/ixgbe_pf.c > +++ b/drivers/net/ixgbe/ixgbe_pf.c > @@ -128,8 +128,6 @@ void ixgbe_pf_host_uninit(struct rte_eth_dev > *eth_dev) >=20 > PMD_INIT_FUNC_TRACE(); >=20 > - vfinfo =3D > IXGBE_DEV_PRIVATE_TO_P_VFDATA(eth_dev->data->dev_private); > - > RTE_ETH_DEV_SRIOV(eth_dev).active =3D 0; > RTE_ETH_DEV_SRIOV(eth_dev).nb_q_per_pool =3D 0; > RTE_ETH_DEV_SRIOV(eth_dev).def_vmdq_idx =3D 0; @@ -139,6 +137,10 > @@ void ixgbe_pf_host_uninit(struct rte_eth_dev *eth_dev) > if (vf_num =3D=3D 0) > return; >=20 > + vfinfo =3D > IXGBE_DEV_PRIVATE_TO_P_VFDATA(eth_dev->data->dev_private); > + if (*vfinfo =3D=3D NULL) > + return; > + > ret =3D rte_eth_switch_domain_free((*vfinfo)->switch_domain_id); > if (ret) > PMD_INIT_LOG(WARNING, "failed to free switch domain: %d", ret); > -- > 2.13.6