From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 7F8FD288C; Thu, 26 Jul 2018 08:16:11 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Jul 2018 23:16:09 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,404,1526367600"; d="scan'208";a="70461068" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga002.fm.intel.com with ESMTP; 25 Jul 2018 23:16:05 -0700 Received: from fmsmsx154.amr.corp.intel.com (10.18.116.70) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 25 Jul 2018 23:16:05 -0700 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by FMSMSX154.amr.corp.intel.com (10.18.116.70) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 25 Jul 2018 23:16:05 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.100]) by SHSMSX104.ccr.corp.intel.com ([169.254.5.81]) with mapi id 14.03.0319.002; Thu, 26 Jul 2018 14:16:01 +0800 From: "Zhang, Qi Z" To: "Xing, Beilei" CC: "dev@dpdk.org" , "Stillwell Jr, Paul M" , "stable@dpdk.org" Thread-Topic: [PATCH v2] net/i40e: fix device arguments parsing error Thread-Index: AQHUJIb+kyWJ56t4z02LbVSHZAgtQ6ShBMRA Date: Thu, 26 Jul 2018 06:16:00 +0000 Message-ID: <039ED4275CED7440929022BC67E706115326036C@SHSMSX103.ccr.corp.intel.com> References: <1532500602-130919-1-git-send-email-beilei.xing@intel.com> <1532571555-122490-1-git-send-email-beilei.xing@intel.com> In-Reply-To: <1532571555-122490-1-git-send-email-beilei.xing@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMDNmNjU4MzgtNTZkNC00YjM1LTk0NTktMmM5MzY0NGViZjMzIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiSEcrQ1pncHRKV3JXN1ZsS0JqZk9MWEplYytrOVNJdEhDcEVcLzFVMjkrWklDaTVSRElFN1RldDRJMXlCT0tPOFgifQ== x-ctpclassification: CTP_NT x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2] net/i40e: fix device arguments parsing error X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Jul 2018 06:16:14 -0000 > -----Original Message----- > From: Xing, Beilei > Sent: Thursday, July 26, 2018 10:19 AM > To: Zhang, Qi Z > Cc: dev@dpdk.org; Stillwell Jr, Paul M ; > stable@dpdk.org > Subject: [PATCH v2] net/i40e: fix device arguments parsing error >=20 > There's parsing error when using device argument support-multi-driver or > queue-num-per-vf or both. > Error log is "PMD: Error parsing device, invalid key " and > "PMD: Error parsing device, invalid key ". The root cau= se > is that device argument will be parsed in different parsing functions wit= h local > valid key . It seems the error log is hidden from the screen after some other patches,= =20 but it's good to fix this to only record those real invalid parameters. > This patch fixes the issue by combine all supported arguments's valid key= s. >=20 > Fixes: cfdfca493cae ("net/i40e: fix multiple driver support") > Fixes: ee653bd80044 ("net/i40e: determine number of queues per VF at run > time") > Cc: stable@dpdk.org >=20 > Signed-off-by: Beilei Xing Acked-by: Qi Zhang Applied to dpdk-next-net-intel Thanks! Qi