From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 727644CC3; Wed, 1 Aug 2018 02:42:38 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 31 Jul 2018 17:42:36 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,429,1526367600"; d="scan'208";a="250645063" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by fmsmga006.fm.intel.com with ESMTP; 31 Jul 2018 17:42:36 -0700 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 31 Jul 2018 17:42:36 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.100]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.57]) with mapi id 14.03.0319.002; Wed, 1 Aug 2018 08:42:34 +0800 From: "Zhang, Qi Z" To: "Coyle, David" , "Van Haaren, Harry" , "dev@dpdk.org" CC: "Richardson, Bruce" , "stable@dpdk.org" , "thomas@monjalon.net" , "Xing, Beilei" Thread-Topic: [PATCH v2] net/i40e: fix avx2 driver check for rx rearm Thread-Index: AQHUKCucTiwuJWFN9Ue2tOiynwaP7aSo3fyAgAEyi3A= Date: Wed, 1 Aug 2018 00:42:34 +0000 Message-ID: <039ED4275CED7440929022BC67E7061153262339@SHSMSX103.ccr.corp.intel.com> References: <1532971818-191870-1-git-send-email-harry.van.haaren@intel.com> <1532972059-191978-1-git-send-email-harry.van.haaren@intel.com> <6CC82E0EC574F343969147E75534348B1D908C77@IRSMSX103.ger.corp.intel.com> In-Reply-To: <6CC82E0EC574F343969147E75534348B1D908C77@IRSMSX103.ger.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMTQ0NDVhZWYtMmZjMi00NTFhLWE2ZjItMDEyNjM4MTZkZWE5IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiRERCaHJtakZUbENwaXhDVTJXdTFGeWphUHpDZHdZdSs3cGI4c0gxSXpJNTRzTGNLQUE1N0Ywb0tNZ0lFZytidyJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2] net/i40e: fix avx2 driver check for rx rearm X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Aug 2018 00:42:39 -0000 > -----Original Message----- > From: Coyle, David > Sent: Tuesday, July 31, 2018 10:25 PM > To: Van Haaren, Harry ; dev@dpdk.org > Cc: Richardson, Bruce ; stable@dpdk.org; > thomas@monjalon.net; Xing, Beilei ; Zhang, Qi Z > > Subject: RE: [PATCH v2] net/i40e: fix avx2 driver check for rx rearm >=20 >=20 >=20 > -----Original Message----- > From: Van Haaren, Harry > Sent: Monday, July 30, 2018 6:34 PM > To: dev@dpdk.org > Cc: Van Haaren, Harry ; Richardson, Bruce > ; stable@dpdk.org; thomas@monjalon.net; > Coyle, David ; Xing, Beilei ; > Zhang, Qi Z > Subject: [PATCH v2] net/i40e: fix avx2 driver check for rx rearm >=20 > This commit fixes an infinite loop bug that could occur if the i40e AVX2 = driver > is used, and high traffic rates cause the mempool from which the rxq pull= s > mbufs to become empty. >=20 > The result would be an infinite loop of checking if we should perform an = rx > rearm, calling the function and an error return due the the mempool being > emtpy. >=20 > The fix is to align the code in the AVX2 driver with the SSE driver, wher= e an if() > is used instead of a while(), allowing the thread to return from i40e rx > function even if the mempool is empty. >=20 > Fixes: dafadd73762e ("net/i40e: add AVX2 Rx function") > Cc: bruce.richardson@intel.com > Cc: stable@dpdk.org >=20 > Reported-by: David Coyle > Signed-off-by: Harry van Haaren > Acked-by: Brendan Ryan > Tested-by: David Coyle Applied to dpdk-next-net-intel. Thanks! Qi