From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 1EB565F13 for ; Wed, 1 Aug 2018 16:00:02 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 01 Aug 2018 07:00:01 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,432,1526367600"; d="scan'208";a="71711120" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga003.jf.intel.com with ESMTP; 01 Aug 2018 06:59:49 -0700 Received: from fmsmsx154.amr.corp.intel.com (10.18.116.70) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 1 Aug 2018 06:59:49 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by FMSMSX154.amr.corp.intel.com (10.18.116.70) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 1 Aug 2018 06:59:49 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.100]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.173]) with mapi id 14.03.0319.002; Wed, 1 Aug 2018 21:59:47 +0800 From: "Zhang, Qi Z" To: Chas Williams <3chas3@gmail.com>, "dev@dpdk.org" CC: "Xing, Beilei" , "Charles (Chas) Williams" Thread-Topic: [PATCH] net/i40e: stop lldp before setting local lldp MIB Thread-Index: AQHUKU03ItVmEoQkWEOTJBSKgdyYmaSq7IwQ Date: Wed, 1 Aug 2018 13:59:47 +0000 Message-ID: <039ED4275CED7440929022BC67E706115326261E@SHSMSX103.ccr.corp.intel.com> References: <20180801040712.13792-1-3chas3@gmail.com> In-Reply-To: <20180801040712.13792-1-3chas3@gmail.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMTE4MTQ2Y2ItZDc4Ny00ZGRjLWJmNDAtOTU4MDYzNTBkZDVkIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoieVVtY3R1M1NlZVlSSnpoNUdEQnRFaitHdTUzTlwvSXd3aEZ1bkxnV3IwRjRTM0hTWU1FdUhEUVZyajhrQnBTRDYifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] net/i40e: stop lldp before setting local lldp MIB X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Aug 2018 14:00:03 -0000 Hi Williams: > -----Original Message----- > From: Chas Williams [mailto:3chas3@gmail.com] > Sent: Wednesday, August 1, 2018 12:07 PM > To: dev@dpdk.org > Cc: Xing, Beilei ; Zhang, Qi Z ; > Charles (Chas) Williams > Subject: [PATCH] net/i40e: stop lldp before setting local lldp MIB >=20 > From: "Charles (Chas) Williams" >=20 > From the Intel Ethernet Controller X710/XXV710/XL710 Specifiction > Update: >=20 > Starting from NVM 5.02, if the Set Local LLDP MIB command is > received while the DCBx specific agent is stopped, the command > returns an EPERM error. If the command is received while the > LLDP agent is stopped, it sets the local MIB without exchanging > LLDP with peer, and returns SUCCESS. >=20 > This results in the harmless, but annoying, diagnostic: >=20 > default dcb config fails. err =3D -53, aq_err =3D 1. >=20 > So, always stop the lldp daemon when we are in software mode before we > attempt to call i40e_set_dcb_config. >=20 > Signed-off-by: Chas Williams > --- > drivers/net/i40e/i40e_ethdev.c | 1 + > 1 file changed, 1 insertion(+) >=20 > diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethde= v.c > index a340540ef..03bedf5c1 100644 > --- a/drivers/net/i40e/i40e_ethdev.c > +++ b/drivers/net/i40e/i40e_ethdev.c > @@ -11237,6 +11237,7 @@ i40e_dcb_init_configure(struct rte_eth_dev > *dev, bool sw_dcb) > * i40e_init_dcb we expect is failure with I40E_AQ_RC_EPERM > * adminq status. Otherwise, it should return success. > */ > + i40e_aq_stop_lldp(hw, TRUE, NULL); I40e_aq_stop_lldp is intended to be removed with below two patches. commit c6431c891d9e9691e3205fe5c5350071cbaeb852 commit fcbd40d4327b36725c4de9f33f57809edc359f4a Regards. Qi > if ((ret =3D=3D I40E_SUCCESS) || (ret !=3D I40E_SUCCESS && > hw->aq.asq_last_status =3D=3D I40E_AQ_RC_EPERM)) { > memset(&hw->local_dcbx_config, 0, > -- > 2.14.4